From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14634C74A5B for ; Fri, 17 Mar 2023 11:50:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD44C6B0074; Fri, 17 Mar 2023 07:50:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A84196B0075; Fri, 17 Mar 2023 07:50:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94B536B0078; Fri, 17 Mar 2023 07:50:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 85A3F6B0074 for ; Fri, 17 Mar 2023 07:50:42 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 58FEFC0AFC for ; Fri, 17 Mar 2023 11:50:42 +0000 (UTC) X-FDA: 80578223124.13.EC2982B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id 77B69A0004 for ; Fri, 17 Mar 2023 11:50:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eoboMQBI; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679053840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3i9UwyFvr4R4Jsi3I159LHWPmGYVdiEC3QnNPI/tKqE=; b=8OaEotLbUXbhmK7v3m+omfFcBfjwkri8yNntlUdwNm2z4hPEdFf8dxYQQqKPLqtq5tspj+ c3Qd991ZDtKdMIbcrItySk1dq3MBDE73Vl2Be3H4kLgqY0LNn5ZzOCLPOPVimnBnIL4s/O 8gV7jfKgnZATPlhxTa5sRfn6SweG0MY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eoboMQBI; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679053840; a=rsa-sha256; cv=none; b=pEYOBptyW2UoRMFAVn0LkUrNLNsvXBarKOwizlHGvidYkqucAlUJoDzV938CBFPfcjLfMB JxhCaK2K19+PQm3vbfuVeHYrZX+MeRLzKkF+XCNBtn6eTSru5n3VwNSieIJpg5l3b/W5fI IoqQUqdLDQ7XesFsy6rTZN5upvvQ5jA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8D992B82560; Fri, 17 Mar 2023 11:50:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93C39C433EF; Fri, 17 Mar 2023 11:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679053837; bh=P6v6r6R1v/vIPhHbXwX6vrqG7HQxKQSoSr5UuD/sfe8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eoboMQBI4H1dstMVVfHxogZFyfyDPor1l8SW8xAl6lz7GE1lpr3O6sa9m/r3REcSb HHduvUkjIF7zmVcgJOGYZ77vsfhPvDntALJNAeRj16xA3FJg3ZbJs0M98SnFyYtSCZ jaoH3BarvXIzLDi9aW0OTdeMD7zPAmeqonzv1vjuLZGuis6+DZp9yVk4RAG5JJ2Ejx DshL6F1s26EDKFNdYR06vV0v/exEx0rSIP7VRIvc5mr6PivwRQe+2sjiincEM8nFK1 ec29bKOekazQ6d5Tpy5GrCPEeAVTa6ga2/MvPFyG8UmwaGUPamAmUpZwHsvLtUvNQe rELVRh+ukTDmA== Date: Fri, 17 Mar 2023 13:50:22 +0200 From: Mike Rapoport To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, linux-doc@vger.kernel.org, Lorenzo Stoakes Subject: Re: [PATCH v2 2/6] mm, page_flags: remove PG_slob_free Message-ID: References: <20230317104307.29328-1-vbabka@suse.cz> <20230317104307.29328-3-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230317104307.29328-3-vbabka@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: m74ogsunnseboauk9i3qt3mg84sz7aur X-Rspamd-Queue-Id: 77B69A0004 X-HE-Tag: 1679053840-285328 X-HE-Meta: U2FsdGVkX18uIcjaRZj9NM6z/uof+Sah/MG7ARt8PexEvKqFrz1XXf6Ywl/STRNdLSJOJsX1l2SAzBCKDtZ7MMw6HqWR78HylpCZrxrdCtsdHI61L4rqN9PAG8629XEjaPOPA5j/uleAxtZ6LclqzgCjTbcEuMgtuC+PI7z4YRKLtMUIF+PzpeAHVYa71IuE7mJ33txeM9PM6kIl5cPqOeqXD3nKSCbpa8Lxrle9Y9AeaQomKpfWL9elmoZWC5wSO0OkdZHefxTjdt5ZO1arbuJrjhFxHfquWcldIWCLty67Y0AExl3ChQQGbNnzxwstqsar3VC6tVXsv+ZkKO2vE7gWoGgic4mTnNveBxf9KfQgbpL85jcpQgwrdvFWCmRJofxGqdbDCslGPrW7nMlx5bvMrl88xb4x3IxRR5vLIP5QK7JByTxSY1bepjglSb7iY+SlQiU7lO1XsCZcn6p83V1B+Li+o9+cyHSjuICzKzXnrGma5JviO5SeZOYAEBt1u1JezeIiB0Dn1CpXeaBTwAkDyBPP01Ty9OLIZJIOjLJrCzOFoloLopkQODUU+iN5HDG6zOgBfI46+Vo7yt1DUIdEHdzr5y8gW+gCX1E0UDykb9xC/WIke0Sdv2yLNqEwEcek9sdVjTtgLo5fTq/z5YDoNeLA891GInVg1s/GMrtEBSczxTOY0G5jz/86pvNBFwI0iqnV0WgIjWB2jAlLe+0ptkQosRYjA/WpzEWLuTiVLD0vH21SPaBWlzVth0ZzsQsQjNpI/8wFhZASAx+1aLE7KPc+/NmDu3ZTV6qiqgrdGHkuiMdFkRwNV1LrmfofRAE/5avOxAdFr8uybUTm1P4xF1yzPOIVO3arxKAojngfVgAKZVE/WJ8EfqiXRf+BeG0RSngbRZRXhK1s1cKzZbW5ApqaCEnZNSQMNMtYYDCzk9PSxwn6n/3zeZ0O31SMXYuMwfv5f38OmnexVox YTADimfB 268kYKrlRrYNsrjTy+OwuNRa/+BSPnqNJZH7Dh80P3kw2kNeQU+aNXXMf30Q8PieuPHMIHI2xVDthr2HRcDS35lsucHzpFzoIdtWVCdmw18f6YBkwevOC0Gaba7/NbhXuHEU5psynTAvot7iTJtMK1E5Co4pJOCl6x1lweB3EunY8G1n0cxK/HgV3COGbEuiKmm1WjnRmZhrNrvdZhdStOUEkqunf8UpcETsTI7qPFlGpv8ehVyIeIW8IYLg3TStxNYeT3x9RA5/o2dnmfqy4uXynrI1O/jBfYKqEUTyF5Y6ACOmCf2PrWO3m0pTF9HrQyInZBJSW+kbwYCgJ8cjjApl+2RWX+/yKQplrvcjqlQFYpFd58SAQaNYsnuC6bn6quRQ08AYUZDkIN4V+Qfa4KWmzKn/dKWo65uTB+YcTf45MQhT3N21AvaIjpqo/JkiOHGTrsUdEEhayEnA63lqoJsY/nqU19X3J2b5TnIvGcZMgBaf7Jrgo3xujCFJ3qkwLaOU/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 17, 2023 at 11:43:03AM +0100, Vlastimil Babka wrote: > With SLOB removed we no longer need the PG_slob_free alias for > PG_private. Also update tools/mm/page-types. > > Signed-off-by: Vlastimil Babka > Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Acked-by: Lorenzo Stoakes Acked-by: Mike Rapoport (IBM) > --- > include/linux/page-flags.h | 4 ---- > tools/mm/page-types.c | 6 +----- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index a7e3a3405520..2bdc41cb0594 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -174,9 +174,6 @@ enum pageflags { > /* Remapped by swiotlb-xen. */ > PG_xen_remapped = PG_owner_priv_1, > > - /* SLOB */ > - PG_slob_free = PG_private, > - > #ifdef CONFIG_MEMORY_FAILURE > /* > * Compound pages. Stored in first tail page's flags. > @@ -483,7 +480,6 @@ PAGEFLAG(Active, active, PF_HEAD) __CLEARPAGEFLAG(Active, active, PF_HEAD) > PAGEFLAG(Workingset, workingset, PF_HEAD) > TESTCLEARFLAG(Workingset, workingset, PF_HEAD) > __PAGEFLAG(Slab, slab, PF_NO_TAIL) > -__PAGEFLAG(SlobFree, slob_free, PF_NO_TAIL) > PAGEFLAG(Checked, checked, PF_NO_COMPOUND) /* Used by some filesystems */ > > /* Xen */ > diff --git a/tools/mm/page-types.c b/tools/mm/page-types.c > index 381dcc00cb62..8d5595b6c59f 100644 > --- a/tools/mm/page-types.c > +++ b/tools/mm/page-types.c > @@ -85,7 +85,6 @@ > */ > #define KPF_ANON_EXCLUSIVE 47 > #define KPF_READAHEAD 48 > -#define KPF_SLOB_FREE 49 > #define KPF_SLUB_FROZEN 50 > #define KPF_SLUB_DEBUG 51 > #define KPF_FILE 61 > @@ -141,7 +140,6 @@ static const char * const page_flag_names[] = { > > [KPF_ANON_EXCLUSIVE] = "d:anon_exclusive", > [KPF_READAHEAD] = "I:readahead", > - [KPF_SLOB_FREE] = "P:slob_free", > [KPF_SLUB_FROZEN] = "A:slub_frozen", > [KPF_SLUB_DEBUG] = "E:slub_debug", > > @@ -478,10 +476,8 @@ static uint64_t expand_overloaded_flags(uint64_t flags, uint64_t pme) > if ((flags & BIT(ANON)) && (flags & BIT(MAPPEDTODISK))) > flags ^= BIT(MAPPEDTODISK) | BIT(ANON_EXCLUSIVE); > > - /* SLOB/SLUB overload several page flags */ > + /* SLUB overloads several page flags */ > if (flags & BIT(SLAB)) { > - if (flags & BIT(PRIVATE)) > - flags ^= BIT(PRIVATE) | BIT(SLOB_FREE); > if (flags & BIT(ACTIVE)) > flags ^= BIT(ACTIVE) | BIT(SLUB_FROZEN); > if (flags & BIT(ERROR)) > -- > 2.39.2 > -- Sincerely yours, Mike.