From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7BAC6FD1F for ; Thu, 16 Mar 2023 15:18:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43C70900003; Thu, 16 Mar 2023 11:18:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EC43900002; Thu, 16 Mar 2023 11:18:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B428900003; Thu, 16 Mar 2023 11:18:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1864B900002 for ; Thu, 16 Mar 2023 11:18:33 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 99F3D1414AD for ; Thu, 16 Mar 2023 15:18:32 +0000 (UTC) X-FDA: 80575118064.19.BF87B92 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 8781616001E for ; Thu, 16 Mar 2023 15:18:30 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ef5xiSlv; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678979910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OVbbKS3+tPMZpE1iJ+dqvHnT8StGQDNMadrwZpVRXgA=; b=NBSS/L/UD6AftgK77PLpG+SiB1YUN01+JFqP8m36kx37QA4ILWXYSfijre2X2QXYyXHFMq Gh2Kwk+i4U7D6fzRAlQuzWlGHhiSWV9KWT1BqcN6FHmP1SUzJbtgqXvy4wG2uepeNXVbHS vuY57Kmjc/j0XcdXH8/2toe1CYh0FBw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ef5xiSlv; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678979910; a=rsa-sha256; cv=none; b=uLfJkp1hTgYJtsAWabwFwOGVZxSbhPA8jdzEN1xsKtw0K8mWMuA1mxsSiJNOsng3Ve88tx BtvNrZZnvEsmOlfuZb6g5wqvDrzwlHET7ibhG1cvq9IKoWGR3fxPVIhcFr+5UT6c34bwOq NOB74Scc85WqjI+LjJMndt886fVBoMU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678979909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OVbbKS3+tPMZpE1iJ+dqvHnT8StGQDNMadrwZpVRXgA=; b=Ef5xiSlvGd/f9LWYq+tgbyQPd8YUur2ADihPNOvqLRQK1T4Krewf5q8GRnu2ebhmtkOK7/ L4YB9Pj1n9ZY4TR3DGOJwyB706I1H4ZtMZlctUTcgMF5HZJZpLdyo0VbHvfMcZTyyGervK xP5oLdFQdu84la2lUrWVNHxkDukx0tY= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-U8z3-1gwPPy1YVXzYoQ5YA-1; Thu, 16 Mar 2023 11:18:28 -0400 X-MC-Unique: U8z3-1gwPPy1YVXzYoQ5YA-1 Received: by mail-qv1-f70.google.com with SMTP id j13-20020a0cc34d000000b005a37f812e48so1219613qvi.12 for ; Thu, 16 Mar 2023 08:18:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678979907; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zk9KdCyCrYHmFVK1vb1UQg9WuTwY/vbXMs8lYmla1FA=; b=ckmGRVwTW2M4mAoe4lmftP5BN12fX9+qDWhhtwDOAnSXeiUcX2y5k9c/8bwB0kxCb9 WTKk0x5ap2ZnnGJ2ArgG/BcW757Yod7NmZCTURJ962Yi3IEl15bzLSo7y+p0yEZKQ5FX ydfAybzeceqSPs8NPoewSs1u5F0AROISyksLH09cvMIAL/uERBAXVp2hAnl846Q/OZ3b b5k2deIDSQeatgHEemH6wPvqz1ZbbJRpFfNm2gi6wHau8YGr9tSrzmCreQcl47jtJcDU u6Y7XBpv5xYfvLpyte6UIMpqcPuTdFZRtNv8M+GkL7U9kfS6SiBhDg+kSo4uBLxCvUlI y6Eg== X-Gm-Message-State: AO0yUKW5VW2VXpWDUHWJhg2rYhI0EAAfUnP2K2+9WLlWQ2uq89IRowgO /rBSifysT6BLZ1iJhk3rhDO0SdzUDJ1tocA67MqtELxwLOAbNWaMbM/o4/H0dtBV7JrOKimy0pM cOYbZi9apiLJ/JwVA5a4= X-Received: by 2002:ac8:5f8b:0:b0:3b9:fc92:a6 with SMTP id j11-20020ac85f8b000000b003b9fc9200a6mr5627933qta.6.1678979907380; Thu, 16 Mar 2023 08:18:27 -0700 (PDT) X-Google-Smtp-Source: AK7set+odfYRpP33cKjai6UkPs9JzY9bzO4d71Nnx6DHJNlPPBdosWt4TG+KSxTh4IguRUSCcm1nyQ== X-Received: by 2002:ac8:5f8b:0:b0:3b9:fc92:a6 with SMTP id j11-20020ac85f8b000000b003b9fc9200a6mr5627901qta.6.1678979906963; Thu, 16 Mar 2023 08:18:26 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id z201-20020a3765d2000000b00745c2b29091sm5853490qkb.93.2023.03.16.08.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 08:18:26 -0700 (PDT) Date: Thu, 16 Mar 2023 11:18:25 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Aneesh Kumar K . V" , Yang Shi Subject: Re: [PATCH] mm/thp: Rename TRANSPARENT_HUGEPAGE_NEVER_DAX to _UNSUPPORTED Message-ID: References: <20230315171642.1244625-1-peterx@redhat.com> <83625129-26c9-8885-7367-bb56bc5367f3@redhat.com> MIME-Version: 1.0 In-Reply-To: <83625129-26c9-8885-7367-bb56bc5367f3@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="Rhi7qt2LvjtkimrJ" Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8781616001E X-Rspam-User: X-Stat-Signature: xf7resnf94m6s6kfhac4qfdegfekx4ke X-HE-Tag: 1678979910-748006 X-HE-Meta: U2FsdGVkX1/+gtpeVPqVUA+y/Mg5OoZ/iZXEYtgECAxQLZejcqXmYd9b1XxfIwGXRT++m9hB4cwokEHGi4qGVMWbjgW5LyZAd5vztalQ4G+iJv4tiZIbHo/jauci6ucjKrEkxRZu6Y9C3/YPF6sEg4KXqJXVzTc0axRGVnag9AQTnRUZXMhJY6b5halA3to/WyodAJFxpMp1Ge1euJ+BTvWGr84HbBGPqg7n7LOjSTRAyjWS6LyvyIqeFjFDFZg1ZSsFIPIWruMtfNDw1zo5gRXeDKhfwr6SdvCnrKzJlH6geOCbAtDWMOmueMpU1ikLINrxj8CK7t8EMK7lnTJwvleXvJzuUV5AUJHzxImfxNqf8/+0FWySZpG2mbuD4m7hEqVu7LIpzXsfi9U3bPoLlFmeeBqFTIVtLdR+p30E/+Tl0mdDNXFzxDlc8D82QMriJSR5Oxg07Np915MoCDsZW77nQ5ZmKvU//pjBmAFaNhqHM7J2uDIjtoXI6/QyuXZlVJ2OxKMueattnakelENXelKAaeiTq0xdQX6trZv/VKO/XJmvIE8uPn1L+6sRNqLgzDfkV2OArVfmaaWpCuqAh1onhdYvDjRVfq5Og8OCyRWWsv9jUPpTuhoutWegzAhsAzr5BdsZgK+r4GhyZYNzJwxmbbR+yh1yz7ouCeC20isD4r/KYY09KKGbQBz+yb5MzRa6J+nSoBvcwu4SvKh2HKtleAq01HnV30RNp59E0iMPsAhG8Rg+gWj9Sc6we7KnSPstkmGdkWIt1aQ71JjZLUcRVq2lobrfqT+5s35KRb7I8wq4RbW3i7AFiS2/n/ruEF1uKGR2DYzm6/cOfzXffA/uhoPZAWB0x8PPqRywkw6R28DfghADTV9Y+9/gwHKNU562mO+wafYLEVzeRWgp09wHSHIO4InUffHSWS3wSf8vFNt8ioNtjaO+zyCqGWlwK6XeEpLuM9scDIcPqab X1xrl537 lfCRDAu7ruu5j1nA1KBA6JEVeHA4YTfFoK3sd/+J0q+HDWaXBU3jUixSCDXpS/dmsnJdFnFx65B7oszOPA+jFlLWtdAF5BJFUlB0eQbtHn5+nA6Gm/HSmaeGIwaf/mA8EkyiOO/e4xctIdykCXVD4Alw5ipb/pu+v5vtlvGBTdsksfWlaMZVnMZe13UE2Mvkrnwuo4REJMRINYpTHps3/uef6jjs/GuVH8rL+2PlVeCM9eUO1A9+vsSkR2h9q8mIuytn87rFIHfrWtjKy+NE8EfRncfMy8pljgKf12d24v5XlXQWO0dWxWyc3ZKaCY83q0t7MNF5yD0KVc7BS4JZ5MDiiYVh0FCSPmQme2nFWuq1w5Vt5PWrWsZ33RNnMM7MJsa3j+jyG0tzQ1abK/Y7N6jj7oDBwMbYC+APuFqvLtJUgjrs2152u6L1jPR7NqtPqgEs+G8eaQVV7eNFTm5IphZP9Kc8GwQIQaXcUl8npVG1CfRUscCje8RYSj6tbdUXbURAuQiFCaKSakq18x1SOpZYuBtmrUefBJnD2FPVf0oV60wHZbk7WzsLlr3h8KfZdRNE+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --Rhi7qt2LvjtkimrJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Thu, Mar 16, 2023 at 03:57:12PM +0100, David Hildenbrand wrote: > On 15.03.23 18:16, Peter Xu wrote: > > TRANSPARENT_HUGEPAGE_NEVER_DAX has nothing to do with DAX. It's set when > > has_transparent_hugepage() returns false, checked in hugepage_vma_check() > > and will disable THP completely if false. Rename it to reflect its real > > purpose. > > > > Cc: Aneesh Kumar K.V > > Cc: Yang Shi > > Signed-off-by: Peter Xu > > --- > > include/linux/huge_mm.h | 2 +- > > mm/huge_memory.c | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > > index 70bd867eba94..9a3a3af2dd80 100644 > > --- a/include/linux/huge_mm.h > > +++ b/include/linux/huge_mm.h > > @@ -79,7 +79,7 @@ static inline vm_fault_t vmf_insert_pfn_pud(struct vm_fault *vmf, pfn_t pfn, > > } > > enum transparent_hugepage_flag { > > - TRANSPARENT_HUGEPAGE_NEVER_DAX, > > + TRANSPARENT_HUGEPAGE_UNSUPPORTED, > > TRANSPARENT_HUGEPAGE_FLAG, > > TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, > > TRANSPARENT_HUGEPAGE_DEFRAG_DIRECT_FLAG, > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index b0ab247939e0..913e7dc32869 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -88,7 +88,7 @@ bool hugepage_vma_check(struct vm_area_struct *vma, unsigned long vm_flags, > > /* > > * If the hardware/firmware marked hugepage support disabled. > > */ > > - if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_NEVER_DAX)) > > + if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_UNSUPPORTED)) > > return false; > > /* khugepaged doesn't collapse DAX vma, but page fault is fine. */ > > @@ -464,7 +464,7 @@ static int __init hugepage_init(void) > > * Hardware doesn't support hugepages, hence disable > > * DAX PMD support. > > > We should also fixup that comment then, no? Yes, I'd drop the comment since the code explains itself. One fixup attached. Thanks. -- Peter Xu --Rhi7qt2LvjtkimrJ Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-fixup-mm-thp-rename-TRANSPARENT_HUGEPAGE_NEVER_DAX-t.patch" >From 0d01260fedfd9d99c1eeac10f9bddd52477823bd Mon Sep 17 00:00:00 2001 From: Peter Xu Date: Thu, 16 Mar 2023 11:08:47 -0400 Subject: [PATCH] fixup! mm/thp: rename TRANSPARENT_HUGEPAGE_NEVER_DAX to _UNSUPPORTED Signed-off-by: Peter Xu --- mm/huge_memory.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 2bb16cf4cafa..81a5689806af 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -460,10 +460,6 @@ static int __init hugepage_init(void) struct kobject *hugepage_kobj; if (!has_transparent_hugepage()) { - /* - * Hardware doesn't support hugepages, hence disable - * DAX PMD support. - */ transparent_hugepage_flags = 1 << TRANSPARENT_HUGEPAGE_UNSUPPORTED; return -EINVAL; } -- 2.39.1 --Rhi7qt2LvjtkimrJ--