From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D165C6FD19 for ; Thu, 16 Mar 2023 13:14:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C605E900005; Thu, 16 Mar 2023 09:14:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEB7F900002; Thu, 16 Mar 2023 09:14:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A63D7900005; Thu, 16 Mar 2023 09:14:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 971C5900002 for ; Thu, 16 Mar 2023 09:14:21 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4EC6440A0A for ; Thu, 16 Mar 2023 13:14:21 +0000 (UTC) X-FDA: 80574805122.05.8B305E8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 083ACC001D for ; Thu, 16 Mar 2023 13:14:18 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=F7JDAF+3; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678972459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/aWedzsw7s5dh5oPwPfRoS0tq8TyVis1dtJ7OKpO1Dc=; b=XCjJVf8N1L7NqD1Vy79vdvT1iDBSl9tRL5bGWcN3frqU3Q1no2FxLgFgqqRoNh7sEc8eWW okPr18MwbvMAUyxyI0c2TYLz4dTXXRgmyDfC69VSVe6ZcOe/1XoLroLlzSCjYxK2K0A2zQ Xx4yZ2N5MALA/I973YYIHuvrMb4qbZo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=F7JDAF+3; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678972459; a=rsa-sha256; cv=none; b=fYBaE7zVEw/wTLlGvFX/E2fs9ZUqZpVxthGlbyVKtUkTjWa0R3ON0s7luqcznz+k2KrY6c nd2Ue8bfKzANDYSpoYkSE1xYT2JPJXMPrOS+x2pZK70yTuKQ/MfKtzcpVTL2X9xf2/VGkz lP4HcamTJjxLgVBhoji0FIHEKIeiF3k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/aWedzsw7s5dh5oPwPfRoS0tq8TyVis1dtJ7OKpO1Dc=; b=F7JDAF+3N4UWoW/9MmOE/cinBW YRLtE3ctmv5dizaO+XGmKATzdOkAdXS8brbF9tZIRRadpypqsnqkTl4y7PsEr2jFiVVUPmH63PwNV 6ymi5FwwLOxXfimYVjg9wtyy+iklrSDsLuGiZTtGIwouFj2u/u17zpDH9H7JDciyZ8uBA0k900WKX 32/fo4ZT/QoaFaypjz4NN0Y0MVGoFvbRWqA+RCOSbtcEjtLKpGWdgEQ01dPmDxDwGN9s0fugk3m0z BIbujheg0Se9qKFA/UXIVm00QgT/2nG1mhv6h77PA2PqyD3z2LggYkV2XKeq/on+P7XmV3vBEnbWC QQ+cB8XA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pcnQj-00EqgY-Jt; Thu, 16 Mar 2023 13:14:05 +0000 Date: Thu, 16 Mar 2023 13:14:05 +0000 From: Matthew Wilcox To: yang.yang29@zte.com.cn Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, iamjoonsoo.kim@lge.com Subject: Re: =?iso-8859-1?Q?=A0=5BPATCH_linux-next?= =?iso-8859-1?Q?=5D_mm=3A_workingset=3A_simplify_the=A0calculatio?= =?iso-8859-1?Q?n?= of workingset size Message-ID: References: <202303161723055514455@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202303161723055514455@zte.com.cn> X-Stat-Signature: isruq7k8qjyiwf83gpxgqaqdu68qs7b6 X-Rspam-User: X-Rspamd-Queue-Id: 083ACC001D X-Rspamd-Server: rspam06 X-HE-Tag: 1678972458-883465 X-HE-Meta: U2FsdGVkX1/oXmd/KS3yK8fpasgwJ39dAOpU1piCvpJcD1aEpVuZHqPy4/XneoprDXHXecT3c6Ar2RmVKur2ou/YhjatmbqGnhybBH+FAG7eox4goyVbB2Nes0tIMnfkuCwpTSI0gygq3Ke2EAXhFnIk+J1fGvaiIWBazaTagdVluMQ3ooR6W6QTWy9pVkDWW/WJx8+I6t6xN0sLvtvu6GpyvCRfm9uXXGRInc66nV4x944RXXmRH516+Zh8MkhSCmAmIIFrTz17RZcqgkyl5DX4T81zyvcnSW+6hUZAYG6WoBy6v1H7DVpCw+vXo4oFezbMU8vXXGrx4AwdY/N7R5MsqX6CM9xxA7oB3kdp3FEruVZ2cdSMp5K7Apbg9YN9b7RJZGohBdwKCiQKjX0Nj/AiiI/QEJp/g5mGLPbCrmv3TnR+/gvtNoJk8/KtyniD7ue595bOvvTWK2i1ZhHine1e7iDaLBocHlvSWQyjWyT2ADDVJPzZRGrln5GXnoGncRUUKH5/a54/ItVI4BwMClP5KaKHQMBVxpg2sQqyYCiiZPtncPEPDibnnWJpLBep+IMy/RN6A184lmddMesAsVrpVWBu0ih2emW2IFrPHLjzDLGAoKE9cNAnlbT49HdwBOj/cDwOe/FMJd73dyRGpNobaSaz5kLmiSqMV830+bzTD5mvK1+Hmt75Oqdsv92eaDpueoqdJmTRPcYpLVXkNYaiZzNH2qVFzdU5lG/GIc6L1dkM58FgaYkWH58ACxtmKPAcm8/nB7CE4Qrh4l6NxHHDRW0xoerz3egPz4Kq25VcRvOfSwlolpCuhVzMmpaIK/df/kIVE3O6lay707zdeo2hW/m9iUNRnYS8J4PzZB+wQe1gnN13IF3Kd/zyL8muEon3fuj9S2qk/4HbuNS/t/A1pmUKV3RN5NpRh5LB1CDFgwBj5qIy42+k6oCZQ0DAvLO7qEdm6fNzhhHPRUo udFRA9A8 aS1GRl8iegdQ/I7ndg4eFnIiE0AZNmeTU9NcCrcNfalrPGw5zBg5pwPhgYUR6ThjGXZGlDMWXq79/Ee0AXlT03KIPvbl0eBWeV3QnjcKrfPn9XHnWxGuzaUYcAfThQ6yIZyBdsaz6HfC6lmpDB0b/bY2qsR6u+PZ3a36uJPFw0ksxGIFC6Q8gn156owWhh/5nD39pj2C2lDNvtFTOBz6tEJcDMYG4cxKHznTAaZBUHAXl5TA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 16, 2023 at 05:23:05PM +0800, yang.yang29@zte.com.cn wrote: > * Compare the distance to the existing workingset size. We > * don't activate pages that couldn't stay resident even if > - * all the memory was available to the workingset. Whether > - * workingset competition needs to consider anon or not depends > - * on having swap. > + * all the memory was available to the workingset. For page > + * cache whether workingset competition needs to consider > + * anon or not depends on having swap. I don't mind this change > */ > workingset_size = lruvec_page_state(eviction_lruvec, NR_ACTIVE_FILE); > + /* For anonymous page */ This comment adds no value > if (!file) { > + workingset_size += lruvec_page_state(eviction_lruvec, > + NR_ACTIVE_ANON); > workingset_size += lruvec_page_state(eviction_lruvec, > NR_INACTIVE_FILE); > - } > - if (mem_cgroup_get_nr_swap_pages(eviction_memcg) > 0) { > + /* For page cache */ Nor this one > + } else if (mem_cgroup_get_nr_swap_pages(eviction_memcg) > 0) { > workingset_size += lruvec_page_state(eviction_lruvec, > NR_ACTIVE_ANON); > - if (file) { > - workingset_size += lruvec_page_state(eviction_lruvec, > + workingset_size += lruvec_page_state(eviction_lruvec, > NR_INACTIVE_ANON); > - } > } I don't have an opinion on the actual code changes.