From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D87A6C7618A for ; Thu, 16 Mar 2023 07:02:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62A6E6B0075; Thu, 16 Mar 2023 03:02:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D8FF6B0078; Thu, 16 Mar 2023 03:02:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A06E6B007B; Thu, 16 Mar 2023 03:02:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3B0736B0075 for ; Thu, 16 Mar 2023 03:02:35 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D97CF16134C for ; Thu, 16 Mar 2023 07:02:34 +0000 (UTC) X-FDA: 80573868228.25.D084B06 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 0AAA340019 for ; Thu, 16 Mar 2023 07:02:32 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TNPhUyiQ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678950153; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eMKtlRutds6wlH1cKZ6ZmyawBZZ06fOqF9Z8JONkB+c=; b=wT/9Tc+OORFYpNHup5wNrfyaM3ol6bYV9DY/K1jFRZ2DupleUX7PB52fhEytrso8MQnuAN vex6XTjKX3jzIAlNLJYLygnZ8caVCo05F2ycQzu8jHODEdM9jAVDENfJITRZ2usM2Xk1cx Dv5pXp5/aPhnDSVN/T+a/T+DdAGIs2I= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TNPhUyiQ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678950153; a=rsa-sha256; cv=none; b=zYz1IYVDmNoV3Z/u8uzsW/6FUmWCAh1Qag5huOw9zoYl5uL/0t+bpHje1gi1ubvtC+BIy2 iQ8Ttg8XZ4KGJrgt2CDevg6TnC4UdeSjLEwkarYF2YOSLgExiRha4VT02lRSkFDl/WHiUf wel+fQmg60PRM0l+CZPIupVaWeLZuzc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CEF9C61F34; Thu, 16 Mar 2023 07:02:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B9C8C433D2; Thu, 16 Mar 2023 07:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678950151; bh=oyu2Kf+xnN2T5vtUW9pLhUslgU39oPBN51+0UsfURbU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TNPhUyiQBTLe3keDiMxW0p2heZwA4vnfSWQXtHqxNbeyoRSzAFnJzhOYHUNbm1Evw 7VdQxZlbitsH9VSYqA+ANSm4J4B6VAUQphiQdFheBNAufgnq5golNODuG4Gw37Ca5+ kxGnpfvElDO3y/WwxvrIKmimKAFpqvzzuYkqaWLWBLewa/GeNP2ld9UbjFRXbQz2uv qI7t0D6iuIs2k3TJdXDF9/wAS7a6khdqb/6z+l1NIj80z2Hdjh9QCxZI9oEiMeTFwO Nt/jaVWtBwdkoX8zOUG+d8YsyEsOy81/D1OYEoBiZ7jAdHj3DyRLZDna4H3LFXBXmH svsGf3H6sTuEQ== Date: Thu, 16 Mar 2023 09:02:11 +0200 From: Mike Rapoport To: Muhammad Usama Anjum Cc: Peter Xu , David Hildenbrand , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Subject: Re: [PATCH v11 2/7] userfaultfd: Define dummy uffd_wp_range() Message-ID: References: <20230309135718.1490461-1-usama.anjum@collabora.com> <20230309135718.1490461-3-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230309135718.1490461-3-usama.anjum@collabora.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0AAA340019 X-Stat-Signature: kwe4sw51jx59xeggenw3k3axfdtjf8s7 X-HE-Tag: 1678950152-29648 X-HE-Meta: U2FsdGVkX18RPvuYPOczvWgSAdR2hGJm73ARKy7ZM2d/35AfI6K5gP8XyLKLBaY/TOPP0U7QpiQ4Ve2PA4eeDOeeGz+LuCJvj01sVEZpQ2yBG5X7ov0zzWxkjG8mwfgpKrmk7KwWPLplPosT5MYtKiUcthcF+o1O1ojOQ2V/ryQlwg32IBK8qobPBzMJtVRAWmGmhNM57OpchDvz7Mn2P0KofoqJflGFD8gv2tFTC4sNOij1I5bgprsBTrWQJRLAkehKYueFUJDPKJz65a/k/UcwOiy26KEvwYuKBTTeAGZO0nI/Upp3cnBbgfghsPhTUY+91r+6Z2gWnuCPoIejpKNOpDqaSLyO8V4XO26Fq+fr2h9Mp190znVP/Scc8bc4iCzcNmVG4vWVwEAn+yib8ziA0lm/ZLvdfJUjcrL4VfwmhhQ9auAQ4ayvjXvog+ofBnjsExEACfD637xyvl7eDVFwVhitGvzOM3lgTG3WBdgDSTdI7zKsBs685egfSRYPk1trHYAvwRVbby/5YlpG9YkZKHBlIXdwcecEhlG0/Mv0b2V3fEy0Dxe2sHwnJWPzaKSBsjmOc5S2JDN6rkCDyCRTWNBuNTdnV9W7SOjFVEiqJ4zy3GnnCnyj16o/8KQWCID1/8i7/ZBoRFbFu51vho8rISMXtOe7RcnsZaPGZPlzIE3EBGOETNXU5SRKZcFgDZVu+bBjGSdoywh0tM7sPdCD4/tyTyRpCUIp9iR8i+bSa7ETfUOBQMYlRh8Vw8e6KWeaxEyuL5Z55ADYg+keMk0dfhYPrVdgS4c63beySFbWSm26aKVrbUwCynG5DK6+wpZIqe+Kr9z/CY9AwQ9937IwaLRpeBmhoi8e2ITd5qKSJX5nYmjs+Na+wxCesvAAO+UPXgkHyxk1byoqERgfI0vh/kascNHb3xkX9bBSe09XMIiXNFpeJSR1IRmA7VMXKlZCfk6puFKIo+BZwOa YnhkC/nO BsvazRdwHjh7jIK41ApWoC/Nd2EYPI+OyntYQY9Oloy8BDLOMMoQIWd7pbtdfD1CeKlGzEliG9xiQO5x0SOrFftck9rOulxE6TO205kM4r+FLh2rPynPH1Th4tKb1jMaHaY4AjF8Z4Bl/A+128qeCWow3YOOM4JYa85MS1k5nGk5A92RoyuPTb7iIneKGilGYhmDBQ+XNfTzQE7vJZbnNLiLVfJnO/kT0POHiw6gGvgnCaRKZTswsGZHzfceZoWHpYTZ/Zpi1rxwPfLvc1DNmxp5iQwzaL9XYLMZ1YCpNe4Q9jw1DZOw3ujK6DvfkRmP4K0jsaYw/9TgvtYqBltKgPZa3fK9f0dxwc8tgrBMW093wh09gToy35FDx9yG33+Lhw3PIMW4iocscd8a9G9LuEpvcHl8FzLQQgAad X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Thu, Mar 09, 2023 at 06:57:13PM +0500, Muhammad Usama Anjum wrote: > Define uffd_wp_range() for the cases when CONFIG_USERFAULTFD isn't set. > > Signed-off-by: Muhammad Usama Anjum > --- > include/linux/userfaultfd_k.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/userfaultfd_k.h b/include/linux/userfaultfd_k.h > index b680c0ec8b85..fd1a1ecdb5f6 100644 > --- a/include/linux/userfaultfd_k.h > +++ b/include/linux/userfaultfd_k.h > @@ -182,6 +182,14 @@ extern int userfaultfd_wp_async(struct vm_area_struct *vma); > > #else /* CONFIG_USERFAULTFD */ > > +extern inline long uffd_wp_range(struct mm_struct *dst_mm, static inline > + struct vm_area_struct *vma, > + unsigned long start, unsigned long len, > + bool enable_wp) > +{ > + return 0; > +} > + I didn't see uffd_wp_range() defined in the previous patch. Could be a rebase issue? In any case, the stub should be defined in the same patch as the actual function in order not to break bisectability. > /* mm helpers */ > static inline vm_fault_t handle_userfault(struct vm_fault *vmf, > unsigned long reason) > -- > 2.39.2 > -- Sincerely yours, Mike.