From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ECA9C61DA4 for ; Wed, 15 Mar 2023 16:08:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 821176B0071; Wed, 15 Mar 2023 12:08:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AA686B0072; Wed, 15 Mar 2023 12:08:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64B496B0075; Wed, 15 Mar 2023 12:08:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5128E6B0071 for ; Wed, 15 Mar 2023 12:08:58 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1931EA0C1E for ; Wed, 15 Mar 2023 16:08:58 +0000 (UTC) X-FDA: 80571616356.15.E2D7137 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 5A09310001C for ; Wed, 15 Mar 2023 16:08:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QPZrdM9w; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678896536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=narI0Kzzf814XY8EFz2CHLlHOwVpJgEJht5/vy7eNPg=; b=g6VkDffDyTQHELyJ77xk5uDtdlZTGlO+lXUBDkqKuLOxKhp4i584Jrv/GhzQzzYIDvDAIQ 8P6K6HrgrI7DPHfXIMXYtaqripqkaY9xkLjRkEbACpCbf329T4PLgptmVjurGcJvIZ/w3X jw1pUbLmIQIGquEtccRGUhlxEc7tfKo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QPZrdM9w; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678896536; a=rsa-sha256; cv=none; b=pSkxNKA/IvN1hFWhDfz/McAwl9ZAgnAwYacK9rECnbrDKD0v4gZiD3cZ+tEKSkWvs/xxdT TfVVqPMPTLcLIQjNB2iRCQD47u+r16XB7WSLfG4IJf0gpdZ8IHZPsCuTtMdsHYmeV7QfRT t1aOEssdz92zvOujo2hfBXZoi1P0M6c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=narI0Kzzf814XY8EFz2CHLlHOwVpJgEJht5/vy7eNPg=; b=QPZrdM9w8rQ7+F0DIyWNH69HBa WqivpYrlq9+bf1aQAZoGwRpPki/msVvMlC4cxTdD1gfLpnjd5mZdjVLDT8K92whqduduTJqUQgQ9X M824RtUrRn6WaRvqVtJApcVFhdluWsjwQ6hedSKpBzGqDwzol58496pVh0GaYlatw5hHJN8k/APLJ TFgOp2+UlsQyp0qsU+3pso9VgwhHaqt8EDBNe3cpPlHlNyRGk8Zlg332G3lXfZXG2Pc/uTCpLkcCT 7wYPygjWvJ7DtE/qMescqFHNE8cNf70qCP4nu6PltvUWhE1CPrd2muYclIdjQo1LCx+D+pcUPVGFl 6vDnlirQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pcTgE-00DyRp-IK; Wed, 15 Mar 2023 16:08:46 +0000 Date: Wed, 15 Mar 2023 16:08:46 +0000 From: Matthew Wilcox To: Hannes Reinecke Cc: Pankaj Raghav , hubcap@omnibond.com, senozhatsky@chromium.org, martin@omnibond.com, minchan@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, axboe@kernel.dk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, mcgrof@kernel.org, devel@lists.orangefs.org Subject: Re: [RFC PATCH 2/3] mpage: use bio_for_each_folio_all in mpage_end_io() Message-ID: References: <20230315123233.121593-1-p.raghav@samsung.com> <20230315123233.121593-3-p.raghav@samsung.com> <64a5e85e-4018-ed7d-29d4-db12af290899@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64a5e85e-4018-ed7d-29d4-db12af290899@suse.de> X-Rspamd-Queue-Id: 5A09310001C X-Stat-Signature: 7t1apzuymo7skmz51crfxbob7wsq8a9i X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678896536-563780 X-HE-Meta: U2FsdGVkX19XcCm7zshs8pe6e2nhIxpcTJzDjhplvI6dBzVfcLwHAENGVOPXxk4dlXoo6Ld72mS0fMjuB7Mz/EwnnKGYEWnZO4wLaI/wZVzcn7/CQ7rFpqGcAgnCllg1deCDr+ChvAMC84dadEnfbx8mRIpwqWdMPZW86SBypfOsIUAMakR75+yYcMLxWE6M29MGpELYVJEKtCZNz4ADukQVeCPnltusnwfUizIMIffIEGPa56+Q5lQccExTMkuqKVAa+hN9MKlRUCrr+XLqZ3ALUJ7XpyxR1H/NiCl6P/J+/khO7eV3PETQiJKXIuA5Q5DJ8BLJzyCcIbemibnduicLCimLwETIcVtcjFsa7k0jU+thzQTzkIzR+baQUwlHCPc+5R0pX6n59YkS94NFEx6wrkXgq6KC5qhy4EzMrNChxJrBBoHEMLfzCtykK8q30nDQSWIqei/D2/OsG7HC4Pu670TNwI3q3TXECDvNes+oWkdWEU9LT2ykr2YRLyZDi8GPP0m7mMygCbBpcSg8JC0v/OLdun48ggnWpZTJBmYNOyY/hHGTWWZJR7Cht9TyXedBKBFWELTd83Y41dmeFOyQJD13HlzE6pFNIWpa1duXLVnWepqfkL9IXvceGT8/jIgSeqiGb6QWBw2ka4adHpKVioZ8sf80XDvKaC2hwH4ALjkNLt8w9m1uZI1dclOezX9fLMxGOnJn/TFU+e1zr7OAA451btjG5o3d9teT0ciucn5zhAw+apTeYSIoyFgz+hJObOvoENG6nhZwGLPLrmkWBDh6we/CiKBarv9oFFeJArP7KHgyfX6vL6+vKaEBh6bgGkpC5rbYljeey4yUozEv1HAsrTn0NG2niF1t58+m/CNzGjliDd15kDgNA6JJ1vm3JqC/ajmhNMjA6kkBOYJVpIxR1BKcpg9gE1dXsOCBxqJxbt9Gs+sfWIIcpEGfqG1u0xOk0Q+4ZHDl2hr pwaXkab1 JiYMnw2SnNojR/J+2EVzkXHv6FeGuE9t8f0qPuJZqxaRtlVFG73Idg0KXVsGzKiNKZob++13shSoW1ZPLSkVKRDFSam3Tpdu9uxPVQevhJvHEkjQVo5VAPb9y4/3RenoKIsnp+R5ARiUMe/VVUhzMP98nn0iLUHSgz4IfWpbrcvgniEob17aNgHfQd/7dJYYRLAH41jfqfrQzqWg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 03:52:15PM +0100, Hannes Reinecke wrote: > On 3/15/23 13:32, Pankaj Raghav wrote: > > Use bio_for_each_folio_all to iterate through folios in a bio so that > > the folios can be directly passed to the folio_endio() function. > > + bio_for_each_folio_all(fi, bio) > > + folio_endio(fi.folio, bio_op(bio), > > + blk_status_to_errno(bio->bi_status)); > > bio_put(bio); > > } > > Ah. Here it is. > > I would suggest merge these two patches. The right way to have handled this patch series was: 1. Introduce a new folio_endio() [but see Christoph's mail on why we shouldn't do that] 2-n convert callers to use folios directly n+1 remove page_endio() entirely. Note that patch n+1 might not be part of this patch series; sometimes it takes a while to convert all callers to use folios. I very much dislike the way this was done by pushing the page_folio() call into each of the callers because it makes the entire series hard to review.