From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E443BC61DA4 for ; Wed, 15 Mar 2023 16:05:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 711D46B0072; Wed, 15 Mar 2023 12:05:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C25C6B0075; Wed, 15 Mar 2023 12:05:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B1656B0078; Wed, 15 Mar 2023 12:05:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4CD476B0072 for ; Wed, 15 Mar 2023 12:05:43 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A5FB0A049E for ; Wed, 15 Mar 2023 16:05:42 +0000 (UTC) X-FDA: 80571608124.25.8AE164A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 3962218001F for ; Wed, 15 Mar 2023 16:05:38 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=a9CDszIp; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678896339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LemH/L8r2JaTZW4Kj2EjaBRWtIOBQhwvYigOva+l0PM=; b=Der3FfXrZWwLYCFgPukaUNWOF9a30nG+BPtSP7UiNDRM/oUq1Hu4iFP57kVa0Y7eX9HXE9 xDFpiwT58wXZNU0F4RQ49R+Mr1f7mIri2+65oTTFLIvo2pdCUBY+MpsQfgz9bjcWBg+9Iv IUWIH912LHjIBmGrKz/3l+0sbXzA37k= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=a9CDszIp; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678896339; a=rsa-sha256; cv=none; b=rLkie7N1HXtNvWmMljW5nDnqrfw5sl4163TDi5EyueNv/lnO9YphXUJnEzMSXH/t/k8FKa dF9SaYhdsD0Sb2zyue+WiOSXYkikq72qJl4AlDapOCboFHzW7wHsav8L+6rflkcwg+YwV0 QM+gMFYpmLDCp3c69sxE6bQlQBA8m7k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LemH/L8r2JaTZW4Kj2EjaBRWtIOBQhwvYigOva+l0PM=; b=a9CDszIpr2YISddgNRMXQAn4xA MJf6XCK9PumL5aatchYlNFQqp9ILg7TZ3w5eNBee+5MyBZvIu/LQsZUAg/1m66B93T39k+CanOJ5L GM4tUup3okoF1a7ZGAWu70KS9HRn8WoN1o9t8yz0amg9nfhFE022O87lOxbyy3bkrvQvuKLnU3BG2 9cPvXsOfZ4uVh+8rx7WKzt6gW7hIjX5/wuqb21KjP3PGNh6Vgy2ytTZM5XxRDVu05DwD2yy1tYWCb jJ5pcU+271Bs6PnaLVRnjSAbIraDYq/8OklpvVzme75x7fJGgIKmI6UT0KoXG2G6rNFzF8sf7nm9Q PfPIQV3w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pcTd0-00DyFu-Rk; Wed, 15 Mar 2023 16:05:26 +0000 Date: Wed, 15 Mar 2023 16:05:26 +0000 From: Matthew Wilcox To: Pankaj Raghav Cc: hubcap@omnibond.com, senozhatsky@chromium.org, martin@omnibond.com, minchan@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, axboe@kernel.dk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, mcgrof@kernel.org, devel@lists.orangefs.org Subject: Re: [RFC PATCH 3/3] orangefs: use folio in orangefs_readahead() Message-ID: References: <20230315123233.121593-1-p.raghav@samsung.com> <20230315123233.121593-4-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315123233.121593-4-p.raghav@samsung.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3962218001F X-Stat-Signature: r5p51s5dnq1ns9jbejk4s3zaahihiimk X-HE-Tag: 1678896338-63203 X-HE-Meta: U2FsdGVkX1+mPbMHCMvLi0ZBkbij/O5fxVPgQRs3JWRZE2lNx28qW1Vgs+ZBlTzpXSdC2Ja1HYAGEZ5ROQNw+1IzwDCWhFnSpamYpXDXPjSrZP3BetCF6ys0b+V9aPDN6gXQt4Ux5LiB5ziPcD3MIhB8J+E4u9sOgyFyyK/l60UdO7zEQk/lAYHG/2x+SKxPklYkTpTmU+oWTIDHFdJrF5y2mpdzcUzqmFo33KnarWex8PR94c09l9vmwEWvaEdIBXFfpCYedvqfgAUMXXep9Da3QRU+q2dOUFcHLD6jhrTwHZkszAw9U3e6nqJVPWgDPT4N6pqaW4haPIR2FcHZTaCbB5Hn0qNIVxkpzte5eWoqLJ8Pt4fIC0XTBGLlfeDQqftdCMhjJahnEd0hApkUosuYLHXmXao6Nv4n7TWlAR7sSJ84m42f7K+TkxaC8ECsiWbiCql5hMsOS1rbJRE7l1V/ZjxYm0Hcfkr26Zn/Qt5d1832xoOwueT0xWKplLpEZbI8JIk6HJVU/Syk2Iz2ixZ+XQqsnP2xxQXu/c2fzCaY1/Wao8+NIsEzuHKxqJDaRQKeKyd2gf+HhHzQ2EYAYyXyAg3lgQ6be3fzp4QLjVedOy3WP/Qq9xkITaRBOzdiAFHQ1DoX+7oibIIaMotE9alYXDQkmLjotuHCzt6ycHovcOsebNt1gM8Rt0DQuYyO2MJZAQqE58g7/jH2GtdZOKVebrOYZHgraiBsfSE9kWRud71dG4yddHtXvjRBTQSzfxJ8QTmlhI2KF5VLJ94fBFSPhNGTiMK1ND0lZeXFucnakbeNQnI5+lDefGAS379D3kjpcXxgvcVemCrWIq33MPtNdkSBp3IehdZSf8Nw9iIUcFBT0atGHHYjcnQ7xttdWi1F0TE7sBugegUXScTF0ZJ/j5CJD5wwnAZnUfPgzH3clYvob8wsXkBme6N3W2cu5OVDE7RBcgH3A87xhtO cdV1TxJn /aM9F0HmOWr88gSmr02NEReyBZLNTswyZTPFFjgzDKpFRwFPzRkmVFTehlU+vTIR8I/POHqTk2hO9Yjy/4nd+5kW8UXcqHZ/6MIoZ9VWTV2l37ZX6f1S/cWNCujrpvnGe2lzIWvMs65YewUorIsDz9SeSzF846HNlERucCzPp6Y66jQzeBopYLIZxgmxuse12bD0GKPDNnXNgX1U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 01:32:33PM +0100, Pankaj Raghav wrote: > Use folio and its corresponding function in orangefs_readahead() so that > folios can be directly passed to the folio_endio(). This is wrong; you need to drop the call to folio_put(). > /* clean up. */ > - while ((page = readahead_page(rac))) { > - folio_endio(page_folio(page), false, ret); > - put_page(page); > + while ((folio = readahead_folio(rac))) { > + folio_endio(folio, false, ret); > + folio_put(folio); > }