From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74CF3C6FD1D for ; Wed, 15 Mar 2023 10:11:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3AC46B007D; Wed, 15 Mar 2023 06:10:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC4046B007E; Wed, 15 Mar 2023 06:10:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C653E6B0080; Wed, 15 Mar 2023 06:10:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B2EA46B007D for ; Wed, 15 Mar 2023 06:10:59 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8FF57140495 for ; Wed, 15 Mar 2023 10:10:59 +0000 (UTC) X-FDA: 80570714238.04.7CBE59A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf12.hostedemail.com (Postfix) with ESMTP id 441C34001D for ; Wed, 15 Mar 2023 10:10:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ETB3fwhz; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678875057; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xC9XManymOkH3Zlvu1HCDBbUVe+vmO5Grbl51hH9ztQ=; b=oizRkRwLqs429oq2S/+uQL5HAP6iYy+QVVPYFXyb7KeiyK9Jm/vqRIjTrlJp7OGTbUUl8/ yKQy7Ls4SAwurc5VO7Ixt2rZ1/4Qjjj2QljQtGKhW2kG1XtAJN9LvJE+0XpJeBEjaqzxlI A/mwdoatWEy888ePeERXTlVr/DNAMBw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ETB3fwhz; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678875057; a=rsa-sha256; cv=none; b=Fa8ZuxEY5LWZ23zudR6ZuQdXEgklNI+by24NeRES0lYFKkU01D6mAM2Hu/DZbh3B16QOaO fGf0fbIXj0ywoSjQq2kAk2ZSibTCQbUj4JyZTiIQIMCOm5hD+GtRG5iqKtK29/IrQ2sU2B POvJEN95l8QBqLKb02j6s57DBZvkJnk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A48C5CE1989; Wed, 15 Mar 2023 10:10:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BBEAC433D2; Wed, 15 Mar 2023 10:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678875047; bh=efFtqZ85QX1KX7IpsyvuE1LJJUr1EdgVSqdLZFKpjgE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ETB3fwhzyOBxjmWjhd6GP0MOWk31jImdIVBTbC7Z04hYLFly3I1Jton6V0u8oF8ta f+w8D3yvxNWf3oScfsd71NxHO8IF6+tqxDyLfoJW00GuNBDeevod+iajjRKwWy6MzA G7o9c2SlS6A4Hb//fxXtYpdTOSTgV6cau/yTf45BEAAKFtuKMCz3zrJRHBYvl6kQZh m2wkIYSImRD+VCWBr7fthwCgTj8W9MZOQ7qB6uzzILdSi6wYbHYtotmpYXbPvdjRpX 8ldIQ3JJ1GH8ky/Ffphfuztmapb4uYh4BECD94Iw2blkIcfjOntHDAQ5uF7qU9k+Od yzyL3J0lp5uXA== Date: Wed, 15 Mar 2023 12:10:34 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Subject: Re: [PATCH v4 22/36] s390: Implement the new page table range API Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-23-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315051444.3229621-23-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: b91xotwww8oxia86yssksp5hx5keoazc X-Rspamd-Queue-Id: 441C34001D X-HE-Tag: 1678875055-504611 X-HE-Meta: U2FsdGVkX189+dHfjhCmYeja6+WnTvrW4o86zbtrSQ6BPDAMjTNugciAYgJJ9IA4L9dr8pahX+PimP7WblpaD/Q5ttqEmtNBvY9QsKscYLHiplx2kxf0W4Y2fHz76Lz2V3QhXRRBtvJOB4H921axqzOX0QiAa0A+7qYDm1+7/of7/EJrGrEoHm4IksepbfHaKKZk/60GWDGEQCY4h5p3MnHbRrWc10ryFZwu4MNerIyeHpnR/xYk8NkK/jwYVxk6eJv1Jz5IUKe03TzfCqKvUJs+BrKlqXqNsqZR8rP8/hkshkWapDlPNsO4dAMIVObSZwxjJMC1Uv4snYHtC0pRIjBQhgZFyFr50lQuZs6/HfCnsj8uGHeWuiaGkMJ69fhgiQdL9yy70VxlaIuzx0MO0U4ZAmPXDU0OFQ60HzZfWzTv7boGphPAJbMyNyWSo6f/Vdzq+Sax/+CJcV3HhBInrj3j+5eN6Ca2A+fE4XbkLKtnemdB+nNA0MlJWdL0x3caePxrwtyBNqm+K2BLcmmpfnd1gNbKcfkELRsG25IPjI5pdQOIm571zdSPKIjrhUrlm4dekdpBREtohYNdITI+0Nb7mZbqgrTTM4BYWWxMwW7TkpImGKg+W0TI0F0jcwCZz1oZQ8LvjywxHFy6Ob85w3mHZ+iox8aS5VOKXB/en/mgHbKRop3TXprHRvaRWTKlSb6BkxwvbNPz8+Y35i777ifKsTEdChv/3rcFOmZrez9pgpb0mNP+6PSow+OGI+zoncm1Pzf8VM5fXz0KZzdwUnwaXFX2gU9zJ7zpv4xhKdNEhCQX6oqvO1O5voVvfCwSmixxljGiRL/8GKHQPHywCjfUEIE88oflTwPMBYwbvTWTn1HO4bmdHiPTmWLe79el27rYDDonHYTY+MlfdhlwBHnFCGrf462BTHD2VdlMPqdEPXHaVXZz5Mv4l0YhOYW2jTUzVZDQ5B7RAPNZ11i 09fwPd4P EkjhGQ2aqC9GPc+dAPzTUTzUitUZy8ReZEUpRdcdlTx4KHYRfLk6Qhxml+N5o0OHSvK5w2V8mRUJzcSuPsiJw3XZsO/HD7DNdfRuAvba4RqNO6xymz5meOR96hXK+k0sD1tB6xqhj2Tt+8fktwbNwMgKZJAS3S1Fv6TznNQnncTLzjf/2xK20gmRUIfBESe0f0uRAb5sC3KxSNA6egocKcsPE5VzWj9Ii8XHZ8pjJ6oE5+AYL+79BUGWrMR7aKTfDxa066wswOjX/CVEIVEaRkLwkmYdTYJkqjRHq8rRq/Pu3GuXX7VkXpewQ3IhklSgJq0VmcTXWlYMFBbj83eM1CEMPbkemTpyTbshq6BucFWGdU4+EfDnYdwvHYQ8TF79ybSR/bD/kMZLNw7HRi51knIMhLpEukcH9rWCx9KDJ/cK2Y9ogPUIW+4N16mlUt8C3tJ+/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 05:14:30AM +0000, Matthew Wilcox (Oracle) wrote: > Add set_ptes() and update_mmu_cache_range(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Gerald Schaefer > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Alexander Gordeev > Cc: Christian Borntraeger > Cc: Sven Schnelle > Cc: linux-s390@vger.kernel.org Acked-by: Mike Rapoport (IBM) > --- > arch/s390/include/asm/pgtable.h | 33 ++++++++++++++++++++++++--------- > 1 file changed, 24 insertions(+), 9 deletions(-) > > diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h > index c1f6b46ec555..fea678c67e51 100644 > --- a/arch/s390/include/asm/pgtable.h > +++ b/arch/s390/include/asm/pgtable.h > @@ -50,6 +50,7 @@ void arch_report_meminfo(struct seq_file *m); > * tables contain all the necessary information. > */ > #define update_mmu_cache(vma, address, ptep) do { } while (0) > +#define update_mmu_cache_range(vma, addr, ptep, nr) do { } while (0) > #define update_mmu_cache_pmd(vma, address, ptep) do { } while (0) > > /* > @@ -1319,20 +1320,34 @@ pgprot_t pgprot_writecombine(pgprot_t prot); > pgprot_t pgprot_writethrough(pgprot_t prot); > > /* > - * Certain architectures need to do special things when PTEs > - * within a page table are directly modified. Thus, the following > - * hook is made available. > + * Set multiple PTEs to consecutive pages with a single call. All PTEs > + * are within the same folio, PMD and VMA. > */ > -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t entry) > +static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep, pte_t entry, unsigned int nr) > { > if (pte_present(entry)) > entry = clear_pte_bit(entry, __pgprot(_PAGE_UNUSED)); > - if (mm_has_pgste(mm)) > - ptep_set_pte_at(mm, addr, ptep, entry); > - else > - set_pte(ptep, entry); > + if (mm_has_pgste(mm)) { > + for (;;) { > + ptep_set_pte_at(mm, addr, ptep, entry); > + if (--nr == 0) > + break; > + ptep++; > + entry = __pte(pte_val(entry) + PAGE_SIZE); > + addr += PAGE_SIZE; > + } > + } else { > + for (;;) { > + set_pte(ptep, entry); > + if (--nr == 0) > + break; > + ptep++; > + entry = __pte(pte_val(entry) + PAGE_SIZE); > + } > + } > } > +#define set_ptes set_ptes > > /* > * Conversion functions: convert a page and protection to a page entry, > -- > 2.39.2 > > -- Sincerely yours, Mike.