From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9050C6FD1D for ; Wed, 15 Mar 2023 05:02:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D33E6B0072; Wed, 15 Mar 2023 01:02:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 383456B0074; Wed, 15 Mar 2023 01:02:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 272406B0075; Wed, 15 Mar 2023 01:02:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 173F76B0072 for ; Wed, 15 Mar 2023 01:02:43 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E1A131A0F0B for ; Wed, 15 Mar 2023 05:02:42 +0000 (UTC) X-FDA: 80569937364.01.1CECA1F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 42020120006 for ; Wed, 15 Mar 2023 05:02:40 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gFvcXaDv; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678856561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ahxRYQ1+4b3SShQsQkAVmdrJ+ZogUunkpbD0sM5voZ8=; b=Ci3rZwWi9H7sXSxurqh/QGGBliwHwiaQbhHhQrOVom7wEkKGh4YnH9xxoYGukqjgGAMvK5 B27Q/YyxqgVNwzgTkp3zPF0LqerkHn6wdMaNrYAuwtuHZRSBi992Ww++y1XbNBwDjHiwsb kirOTnTpA6DlybDx37LA7SoYZDp+VEI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gFvcXaDv; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678856561; a=rsa-sha256; cv=none; b=hXtJsFMzMEcQQ7MdY1PnT7nRO/HvkvqF6CjsKsusCA1AC/38THKA5iDD1iflJhPHVbdIaV nBaqR5FPHtj1qZwYFYqVKDYy+hsyu+ODPzhTSZUv5hhhPulGMTEQlVzTidQfw1WEm0CciH CGGUAU1EqBO1/SpRUx47sNVzfqPI3vI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ahxRYQ1+4b3SShQsQkAVmdrJ+ZogUunkpbD0sM5voZ8=; b=gFvcXaDvg32/Hvg3izMFoYnjbm WPV+qU1/4jrUVdF9F8CNR2FIHFUFZ/glIL6SJRcsY6dR+lSG8wfJcv/IXZvNzknTHpVRTBX+4en9f iTOA2K6hJ75j2VLawDl6xrHMX9M75dBvPoL2YHgQY1rJg7cZOlKwKz8w9eBL0c4L6TlUsIfUKZBW/ gqN2tDHzYjKaaaoxmDdhsWomPM0m/lcKqQxJ8OAbW4uGDWXCrkximAdJYy2ciJGhPiR23NTqKRd8S vwSp6d+kxVGIWzJDBtLh/AwELdoIvhB0G0w89CmpDtVa8mGEk79rLznUTMaVXFnbShCgFTi8uHwDR 649jEg5g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pcJHZ-00DXlj-8v; Wed, 15 Mar 2023 05:02:37 +0000 Date: Wed, 15 Mar 2023 05:02:37 +0000 From: Matthew Wilcox To: Palmer Dabbelt Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tong Tiangen Subject: Re: [PATCH v2 1/6] riscv/mm/fault: simplify code for do_page_fault() Message-ID: References: <20230315030359.14162-1-palmer@rivosinc.com> <20230315030359.14162-2-palmer@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315030359.14162-2-palmer@rivosinc.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 42020120006 X-Rspam-User: X-Stat-Signature: xerabwnjmjo9x1db1dmo84zwjw79nkni X-HE-Tag: 1678856560-82323 X-HE-Meta: U2FsdGVkX1/gSs/qOmu3bKdiSQcp/mmaMCsMrHki0eNCrG8FAtqaaGPQlmqdlI6YK8Wsqht/+nmcjt9liJjMBgRhSh9uIZDQwpQBddPOnQf9aj0f4FBqO8uGCdKd06c7G+XIQ0HEtLXIK96YeG3rl/QX9nqMZSx2rmxVC7goWIXB9cPBD4DjKm4nwRCequjpQXhXxQ5D7anT9maMpi0GDBkcpZUthGXxboLrFOPuFaWlLPJ0UVPsSWmELPOwWXXgDKj+9gMNGsfbsWBBkJj8+8e2M2JiBXCcZFPf7fV4Wr9iUwYFHJ7RnBxIMdEjGMqUJIUQQ7+JLzsYV0eWzyC50TJ7lvZFThgJ5SIKPLcMIXWrJIkVnudQ5uWZSjj9YswN8bWJN0XwKGa5s+y6ZBjq/Wvv5APJ3GDVevSRFrl8IqVA4s5mpNGm5YvH+fG/KZbbN6zMlD42uXRwq2XdTMsKKHzrYfPv1FCzwQdY9+jA9UpvzbiQemOnpoyr/GB9tB1Y27NNy6hNQ4lxGdQmDYHqT+pQT0FcmW5LH3GI3rm+KyLiABbdNZwSaCwQRk3sDzlVylRtwm4hVIv0pswB/W2CV5DY74JCjaaeglDiYdeCnnfl9ZCyFaVTS55ZI4jg3lMcRN1vRH7M0rNXLq1/hqQCAQELi8Qq0aJEDhDUDwMzVNZirHS1CBg5UM9ArzE5rQTdOncpOgtBPaQJLqEBtYQ73LMjp5sIZTGeXOGDUGpFmqpqSNab9C31GcRlIbkVbtV60p4LrFcmFzAvOcqFN3wQru+8U7MWEN5qojh0/M+DQjvZdCfaaiby4GcmG+CyaQbPGxV6JtqU6gyKbnVQWKqS24z0H0+K0sci5Rjsq8541Ft6DFhUuOIsuzeOpr90YlQrANCLfSJEz7AQpiJ4n+afTOGyRUN8wb5pKyX7PF5YjhsNR4sIj1tirANlvXzlcgICgJ2BQb69uBxi9H46tQQ TrIG0HUC 3I6fkEm01szR0/iuEKNpAl8X0d7CQg8tClxYDiqKS9eK1lgPj6N5Xv8EY7hetmWWmNzW3YuPGTMCcu8a5+DwyLpqUhck2v0JhNbFx/17iEFZ1IRFx6GghPyz81dgl0ttNZCdqDZ6ZcNpcMvqukvUJMw4gXup6sOmgUPaqp+rWAn/XPsZxA4wYLHTJZ5xUroXbNxZvygEYowx+120= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 14, 2023 at 08:03:54PM -0700, Palmer Dabbelt wrote: > To make the code more hierarchical and readable, we fold vma related > judgments into __do_page_fault(). And to simplify the code, move the > tsk->thread.bad_cause's setting into bad_area(). No functional change > intended. I think this is exaactly the wrong thing to be doing. Please _stop_ using custom internal VM_FAULT flags, not adding new uses!