From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFC11C7618A for ; Tue, 14 Mar 2023 17:32:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BEBF6B0072; Tue, 14 Mar 2023 13:32:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66EC16B0074; Tue, 14 Mar 2023 13:32:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 510288E0001; Tue, 14 Mar 2023 13:32:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 416226B0072 for ; Tue, 14 Mar 2023 13:32:37 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 06773160E9F for ; Tue, 14 Mar 2023 17:32:37 +0000 (UTC) X-FDA: 80568198354.09.48265F0 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 51D11C0019 for ; Tue, 14 Mar 2023 17:32:35 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ezQ6b9Wz; spf=none (imf22.hostedemail.com: domain of BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678815155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=28j9WYgvln7aRho0OI6duSimvP4MftIELf2uPURKALY=; b=ZlqsPVgouApUD+mwjtrgbcgAmL3Lb44vI0PcYDLjTNeEPG6PLhrcKEQDCQmXmlDq0vY9I0 XR5eigmvfa5U/lxaKypgAPoxKnhXKR0WzVqHkInHSUXZaupa0d1kTBe1rn9VoYIfzWdAtq WizkhsPCtTomzHX4mOzA183eBVdPzgQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ezQ6b9Wz; spf=none (imf22.hostedemail.com: domain of BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678815155; a=rsa-sha256; cv=none; b=t+lNIgjcBspFCAzsRHXpF5sFcWpaIxP1kgGl2BCwb/wGuTcOWgW3uUE3RK7VRN1QrurzK6 M6oTCAQAuHCz7f/er6LSus+hCRINOXMOb88O5RByV55AeTM+w5yZNS9qbef9NrDwv0wWNz savDv/IJ2Wjy9Xu/P9iNUfDqeUTwN3U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=28j9WYgvln7aRho0OI6duSimvP4MftIELf2uPURKALY=; b=ezQ6b9Wz3oP3LuIChxz62KzWUd UfTh6YVtINaWGSDW4lKRlfb17SBRw1phWauX5F3WS0AMcb7IIz0NhrPvxAhoGrUvPIc9JxfcbfOzx KtMntx4IBgWsjg48yvjhEikc81whrfdeDIMNptNa6JQG8OveNmDKW6EVBDqtyURwlLm5ftY/lO9BI ZDnI5cZh1SVUj7BgcdAEOd9YtFenDxYENUFrNDpHv7tbWngE031S4BaPGdaYSIXByEyfro3Dw68q7 S7hTk8FiTPK0bubryasAgXrRt5LPpvAbSjQSqXKAykY4UxEz32B7PAkYikrMDRCBTcVrtM/TSvGs8 Pfr6sIqg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pc8Vd-00B1ba-2g; Tue, 14 Mar 2023 17:32:25 +0000 Date: Tue, 14 Mar 2023 10:32:25 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Steve French , Christoph Hellwig , John Hubbard , linux-cifs@vger.kernel.org Subject: Re: [PATCH v17 07/14] splice: Do splice read from a file without using ITER_PIPE Message-ID: References: <20230308165251.2078898-1-dhowells@redhat.com> <20230308165251.2078898-8-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308165251.2078898-8-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: b9bcubm1h339b6pw34b9s4cicfxdq1nw X-Rspamd-Queue-Id: 51D11C0019 X-HE-Tag: 1678815155-185228 X-HE-Meta: U2FsdGVkX1/3oIKWb5LjExb84RFRoJdnAoAK5ppLHzNo+3SK2x9cbL8Nnv4YmFlZLySgt2nncLGaa8GeWBH5uByl4JvPRQQavyTd1T/nWrQIuwWhv60sa1UmtWfjcLdVipuYq6q04/H0/z5YBDAGq6u4qkyNtTuNpDhXnEAR/eQ3ICm8nF0SVE1SP3K9LRdfF6ihfQN1Htf8E+flSaUW1/iiw84cbKl3kQWKUNfCRC7OlGy20yQSdHmhLUwaDk8+m38zVvzFX7f403KY7gcD7+7YyvEwg3ldr+v28FtwOH53rEQ7tj6VU9DEmjiNb2ED0qWI7HSi4LV9OJWKbu6uvk12haszwhM3ytk1QcevT3dyxUf8eGQOobPxrzboURVmfDKViSPEQ0ZNNPJa0CKF+RcoMvO8Jwh6Mvy/ZKTfuAqXDd9GU9DXn8ICP5+RqYbdbVgXEMrLWbvOhP1ZALtqgDhP3lDAVuAuHq7cCfZPuvRz69dIX62Z8npsuvMEEw+pmDOU4fpUL7FCsV5bVW0uePgO0pitG18v9udA4MKDzsKSZUuV+UICHoz1NO26kkVs+G0USzvg/L5LZYdFdDRemgg4Q1TlZrfPx3biMkA4W2DPuVw52rdF9KZnVliqE9244d9eewr2MzHAfv32UfV4m4WPihbdL1N78lQEWJHBEv4x2KwbofBtQfmqn00JPWFvgk/9CXKy3UW7sPLWc9ybXIHCTPCazBhwETrDZBp18V94c56D7bahboCyT4apdlS3E/vKdrXpsuixM/6FpxurUiAC6tNbBS6UJpGSIpRHKwYr3ejcqJA0Iz6svKEhTeKsfXfTyj9zapM4B+MU6/hZHmCRxbQJe+j+HZjr67VUnYP2telFuAspTDtCyuKSrF7Olkoslwh3HgB7tw2vpZH4w3OjGj5G9M7CSgbEM61p1r3B7VK0UXy1s6eyVHixtQ6pkeL45gf62gO759EkAjd SHTxHAjQ NISNlq+U+3Y6ytQ8D849XiO8/WPEkKuoTuzjPonBvdmpETws+kgV785OZq8g/fM+az4cdrPujlOTYVT/FpH+ah0bM4AlKkhXcRmlzF2Dv9BNUlpEiG2nvBtA99RgDHsplMBeDsA//cUwwEjpAhrsVLidxQxPSOHb1rghDN9mYyCweTFTEj0FO8QDmlpGqb7RInGki/jpSLBzOg+uLoUzoKbbNgrroobQ6yo0qWWrG7twa55CizLZgblf+WmF/bvcBn/xsHvC7slUdPFepKZpoRfCACWSqLhHMlqa2OGCEcn7AUFzSIZLAJREMUv4Nps/9I47BMfK1IIa9W1AslZtNwZruPqSNqrPKlKYmgWM1guP4dCPpBrnW3kbf0tiMi9rRVS+824tv0yVhVu7BkWJO/nRO9gW/CCvIEYID/w/GqJnHfbqWo5h17L/hZCzEfvtZTyzJ8kbwxNrTWk25ZWHtUpxfUa97IYF7CcgPzKbRB7HbtR0/eGkRRUpzVGsJwWKqQ/44yDT1kji1VJ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 04:52:44PM +0000, David Howells wrote: > Make generic_file_splice_read() use filemap_splice_read() and > direct_splice_read() rather than using an ITER_PIPE and call_read_iter(). > > Make cifs use generic_file_splice_read() rather than doing it for itself. Please split the cifs patch out into a separate one. Otherwise this looks good: Reviewed-by: Christoph Hellwig