From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0744BC7618B for ; Tue, 14 Mar 2023 17:31:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E20F6B0072; Tue, 14 Mar 2023 13:31:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 892886B0074; Tue, 14 Mar 2023 13:31:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75B738E0001; Tue, 14 Mar 2023 13:31:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 682FA6B0072 for ; Tue, 14 Mar 2023 13:31:48 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 380BBA029C for ; Tue, 14 Mar 2023 17:31:48 +0000 (UTC) X-FDA: 80568196296.03.EEE7B06 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id 65496100028 for ; Tue, 14 Mar 2023 17:31:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Uzb0eoUX; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678815106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hrjqNDyAxanW6Co1Z6mFKhPGQa8P4t5dCZ7joNbFdBE=; b=72xk4GeGOZrDucwFirr82I7pD3H8kptWD/Holsp3B2/z0hZwo75dgkVSLhRMDSRogxgfiJ y5Cy8cWXovS675V7lDVzzMSCbyQ9NbXEe0zf/oILbKm32zFpsiY95UBGSDJukdC8GqxVZ2 8bU5eVAST7+FKR7tT/yFbkaT6Tc1hNY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Uzb0eoUX; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678815106; a=rsa-sha256; cv=none; b=jAUMCVxFNVeE77IJgECKG1KfkQbJ40uJf2O1MfmoI9Esz7r87KXDbWyB0NhM2NfJtBlqCk mc4OopxAGmVptntv8wmdgAjfcnJCyk52i4kdk+gPxKmdkKNlH2se1pCGwTTbx1iwf0aVqH s3RZ+5pYEykbE6cNdjdhiT6BDROb3Rc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hrjqNDyAxanW6Co1Z6mFKhPGQa8P4t5dCZ7joNbFdBE=; b=Uzb0eoUXwE1MCiBG8y/Yd2LmbS 10U6878KSXCi+r53vZ/MsWmXAHA6cqZ58eA8y6i/1rL9ZD7ZXyz9/bHMKqT4nW1hSojmG/xUalFdb w1bqloAOrptDtSsWc0NpHL8CMYnM57qw82GtEs5b17l+VFh2dX2+SxC/VqGUJVxYgWMIzO32zkeNP xHdizoj+vjVm/wQvZrxsj7H5oManfqiqhsk0Jihs3lDf06GHisha6OiQ1mHPgb7db+trGTHUdmOkx K0m17FVRBtF40lPOemVEhLvT/bkmYKX8yjSCMyGenvCZQU+vOguUgcygyTVsFCRW/Nn0cVVR1RG+p /ANrQYyA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pc8Um-00B1OQ-1v; Tue, 14 Mar 2023 17:31:32 +0000 Date: Tue, 14 Mar 2023 10:31:32 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Miklos Szeredi , Christoph Hellwig , John Hubbard , linux-unionfs@vger.kernel.org Subject: Re: [PATCH v17 02/14] splice: Make do_splice_to() generic and export it Message-ID: References: <20230308165251.2078898-1-dhowells@redhat.com> <20230308165251.2078898-3-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308165251.2078898-3-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 65496100028 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: xogtdxw11d5bwtjrem5bwc8cbd89roau X-HE-Tag: 1678815106-777002 X-HE-Meta: U2FsdGVkX18TzFhYH4Ng+3lmydbq98ePRssFzBPhSSwidN1ItnO6kExJS7V48d8DgAqY1A8Wn54kTVMTi3x9wGOrD5AW3tyR9spRQFTHZTr1j2kA1HS2k2RiQd//CLyti9PutMNz+e2pM1+vUnkX8l6lYf4czi053+2g8nVnFxrb+lh6eV60LasGLW8jQYZp9nMZL7vhAwva2u5pTZa8a3tgWRKZNCAtkhO/Ats/q+4tiVL+piwg+8zeU+0R7W7GOJ2euUUQ9Gnq3UeVtQneYesYIdt54C6U9belLndmcjtKGDFqE1HvJZV/wBChKhuYo/BwWV8YWsjOaeCnxy2+JMy5t93RaEMWj1m/6rDG0FQxR6kio97ioILE0oeJycNAE+emSnRui2xCPfuMga349+ylN/89JeEH4ik727FVX2QOxltNZMabB8hu3PT7FQNbN1xYY9Tp7gFNILLmlZfgMskqVdxBbPxgJigXD/EoSNTyKx5ZkXZbWVVZvzpgraFmTpVoU/RNXRfCC3PS5wG4Cqs5dh58caeIyQ9h2/69Er0cRPhJX3oQjOJpHHgMzDqwdKuuZ3XFg0FcOvliNwm96sK25OfTZEN08FAhDe9MI9hLd70kZfj5V25Ky5fbEqiyXa/DmpUSIi0++6E1E1Q8Lmyt6mqnTOA054+dKaXcURsjfnFWbAfnEA07T0J11jm68XAnxtal+NbNRYg8xpvi42loJhIJOI6Af4j/HDT/UOODPCpqbMa40oSgDAfgeep/7X38uEcmKEUS6NzrC2sT6XwpEhx+olkrnIU9BrbZIiwR0/TAlTXH4vPt1KJCdvb7PoQIPo0Fb7fS2bpNH1kG98wTUK5cyTWx7RbmRk/j6AU8RPWSAza5pii5jmGQs8Cvb+a6mNE60ulDhhjrMHS2chjXL6F2LmNwQQNZrBxfWuHgvjEDA67XH8kzBFRw6oBWMfcb3CuOT5XKxnr5RS3 7Lf8zXLa NtOlGBt1mw6QVaxU/8IHVoqw1A7CMmB//dYNeqo7/5PjhPr6OmUlU4MOeLgFewzlYSEXLnh1YGVJsx6B34mEkyhf3qgxYR+PGLC46Asbe/SBm+Yllg0wU11cavOItohcKQsheT2h8fWpHL892w+DT3Yiil8IWgBHCu3AyVq1vhmgaOG0h7oJ8uRU2viBfLwT0EId5Jc2UZgI0xd392oNeO4AuRDve4enJ6yc8YR0D9opDukWI0pvx0bfxyhgiK4yFcGricP7vnIEYyQqIZIei5vO7ec3lQdkjlR9H68tl7SxL3IND1DdXZGBaIEvA/ku1Uyd/bv/I8LzWXmyLadNC7EZ5k5BliP3vIGWe8XYYnNcpUZjubvReqk7U3Ks4rPHX7qZIrTU2Rqc1zrW6PicW1JriWcokK2FkBrwDNwtu35FRCEt49Q5TGpjStNsE5zZyIeJb8TigOCpJGdE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -static long do_splice_to(struct file *in, loff_t *ppos, > - struct pipe_inode_info *pipe, size_t len, > - unsigned int flags) > +long vfs_splice_read(struct file *in, loff_t *ppos, The (pre-existing) long here is odd given that ->splice_read returns a ssize_t. This might be a good time to fix that up. Otherwise looks good: Reviewed-by: Christoph Hellwig