From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E001EC6FD1F for ; Tue, 14 Mar 2023 17:30:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 624E26B0072; Tue, 14 Mar 2023 13:30:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D4F06B0074; Tue, 14 Mar 2023 13:30:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49C298E0001; Tue, 14 Mar 2023 13:30:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3AAAC6B0072 for ; Tue, 14 Mar 2023 13:30:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 10CB940943 for ; Tue, 14 Mar 2023 17:30:24 +0000 (UTC) X-FDA: 80568192768.30.D769FD9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 8C354120021 for ; Tue, 14 Mar 2023 17:30:20 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eUIJTM7T; spf=none (imf29.hostedemail.com: domain of BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678815021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=uF+c9PsGden5q8l3NoPg/5UQr9W2YCj3wTn14+4tA2uXobxlGK3K+LY4DZKvbTVmQZJfzU 3SBPHm9rpohLdrCovJg0PtpVMqehUOkfMhQh8vZUJlu1QggqjJAmdMC8jul4PTa9OqkP1y pr5I4Tzd/omgZs2pendE12kmO+y4P+A= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eUIJTM7T; spf=none (imf29.hostedemail.com: domain of BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0b22a7292ad1da11de48+7142+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678815021; a=rsa-sha256; cv=none; b=uw6gfa6XonxH27YZZlIgdUAwew4HfenC42xybKHEqdg0rq5JckYlCKbEvRsirRCir2kjd6 tAAaIlX5GKMTxY+vtJ8jalLSp9cdAolDUQBeZRdbeyJAncfHyXST3qLQt2RHYXd7hziN7i MoSWJ0a3Tm3EKdMXrosKBlAo3HEAk+A= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=eUIJTM7TbkoVZI0j+F8ZKH5X7e B48XJw0RR2yz6tT/PjMswRJjY+dkDmxXc6sCGMg1C4CJ+8iLnpXKbc9rjBY31/jFlSDcFMlYN5QTY py+Kqj3Rzd3f3kql64+bwRMuY9kLTUrfKeM6ZgF7F/8W3SQqxKwU/Cqa8/CSSFnM8vCKld3ya7DGe 2NxmNhXY0cnZAykUsRNZWJX808kO4UWXMEX84GCM2OubDaDuEDia+lUiYBY0qjgXi/JkONUgD5K3d GzAqabDZKA5aVb570+V/GNZjWtQdrYslTi4Nhc2MyDvsqjPGjwryuJJQZcM1nKFS2N8XvJBpL9sj/ q5NH2PIQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pc8TJ-00B16H-0V; Tue, 14 Mar 2023 17:30:01 +0000 Date: Tue, 14 Mar 2023 10:30:01 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v17 01/14] splice: Clean up direct_splice_read() a bit Message-ID: References: <20230308165251.2078898-1-dhowells@redhat.com> <20230308165251.2078898-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308165251.2078898-2-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8C354120021 X-Stat-Signature: wttbznuhmfautgmmkbidopbpzffs7m3q X-HE-Tag: 1678815020-686651 X-HE-Meta: U2FsdGVkX1+n8q/WvXIjWoHFGuw+8Zh0BKnb8nUDGGF17vg4uyMHVxvn9iAw0wXOAgh3ea3GpQhZyJUpDTHBeSpZdYqoEcf3XNzGsR9vlIGMXfYj0xRIUK/FXf1A2k2wujUzEJbu1WPRNYIg4Z6dfwZEkSvFZ7+/zFCjaArG5bwyGpMZCE/pbohdbgAWB/FQ5fUDNyFM2rtq02e36aLbKQinlzYhh34+WeSe2iqcOF84M4Eae78YAJmvMxHkMAeJQRxPhcxWUx9SDNccu7rb1YC19/AR45HGJ9/7lJ2E1wCD4SuzV1Wqw3QCpvW30nf0EUAi9TRgETT2CVi6cT76ZVkZqRwciiFOuhlhP5MdgwyTjr3c4rCvPh8OFLIKwepYMgeiLVbkIbKZjjaIvsKwJKqJfGGy5Dh/QIDnVsaN8OKYiKqnYQrQC0FQrNpAGD5CHDC0dnNh+wqiWJiUbAiN9o7gz+WLDm15zncNZ3mtQAGrMPkOsNraSKk4FkRG1dWG6w0K7iyDRS7jNCJ2s+a2tHYFbFLTc1Z0yK619cortiLHzov/snqQjcfE7YWBhH8AY6c9pIqHM6SBPuXqS0/eqqAx6C7rgb6EET/8w8Ox4mlCuTDSRrdGtx0UCBXj79rT2BADctcMrPPAZeM/yBt8yZ7j9FoMYFE58RSP4/SSMuGQwsZS9TKz/I+K0PSAl9XfWQRXv/EAIP29nBZqerZWi4lTYmso5PwqoyCwhzyD/b7VlzNu+Aol3rIwlZmCirG7Gdvao1nMSIIc8hJ7myqnQHWKklNJub6CJbC+NRm3z9zvk5FJMYfP6wf3nlHRIDv2cVWr7V76jH2Oe6kHn/5C/6KjA5DWM5pwMNNPGkpsomiF553dE6oIHo7SVHHHYYRUP/8xPa48RZi+w9ukB3Kw+uYVTqtNsqUHv297g/dccrT6vCfnCjlcDeHs1khKXUWrWYLTNWwsLVrMqfmK5HD bGv0x1ta rBX0WsdeB2r/ajbVmwg5tokyGSRZUcPgBoHmPENiFWtkfp3saYR1Da/AseVSLCNbiLar5fuX+5G9JtKwkr1e/E22kn/55ccx29Ex3v/WojkF0Lft1oL6F3A6UegVOKxJETwUQOfpUMvFnCOdyjEv15SLs5zARW/2MMBoQAu22KabRJXtFJzBiuAa1GqMGvddcGksMh2NimFgymmn0LZJ8mmhe5IIlVc7iX11itOfnwLjAqX0shUKgl/arSzuSxOEIF2pvOM3iylB6X9zbWt4sEsnEWryl+jjYbfvEnap2LOhqTwa8hachtW5RL2IV+P4KCU7a1z2ri/ywXCsQlLIu5+AdGOoW4fqVvw6+RhyZxhD1l3/5EVpz4CQ9Gaq5p6EQE9yokvzCrXHJpdojC87Z9oVQ6Uic+RrxZi0kXm50+0rwGKPN1Fq6AJchSOaaaa2yRwwsBHMPGmRfi9tXCP9NF2GC13u4W0EozByNGEVaspBf8kVTnhUD1oGd+uk5BqMfD7J9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Looks good: Reviewed-by: Christoph Hellwig