From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F011AC6FD1F for ; Tue, 14 Mar 2023 08:19:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 611DD8E0001; Tue, 14 Mar 2023 04:19:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C1C76B0074; Tue, 14 Mar 2023 04:19:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4635B8E0001; Tue, 14 Mar 2023 04:19:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 335AF6B0072 for ; Tue, 14 Mar 2023 04:19:35 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E91F11C68E2 for ; Tue, 14 Mar 2023 08:19:34 +0000 (UTC) X-FDA: 80566804668.05.7D2B319 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf24.hostedemail.com (Postfix) with ESMTP id 2D40E18000A for ; Tue, 14 Mar 2023 08:19:32 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="QCEaXsu/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678781973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8uO2pb0aT1NnyTIVfLkUifV1o9o6G5xDatiTfXnW8OM=; b=RxrBGL9thEsnqLQ2AFYFQcxP3Qn6buzp9PrCom9vDex1xwfEZ8he5yxpmp74OKVG759IoX toHl/YEfJd04KjorX7IEUi0PPGz3XMTF4Dl8s/lKCEHYQ3Hu86pN8QgWbBqU68L3FQyJwq EZ5Yjx2JmQc7RZeq6m0m2DiXKmNdmVw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="QCEaXsu/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678781973; a=rsa-sha256; cv=none; b=mWK6voO9yn5Xzu84HV1Ch89tFmtkgCHwITJd12IKwuB8/eWmbe6JpaXAA7x/jEjyKDBxR6 pHmIBANw7iNUnfdUeQoJFCmx0ffE0GM0onyyzpLmiACVJZjHLsiszVmd+Njm11hRI4TTJ1 lCoWzXuaCOkGjDKSyvGG3u3+lrnpL/Y= Received: by mail-pj1-f45.google.com with SMTP id e15-20020a17090ac20f00b0023d1b009f52so4246548pjt.2 for ; Tue, 14 Mar 2023 01:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678781972; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8uO2pb0aT1NnyTIVfLkUifV1o9o6G5xDatiTfXnW8OM=; b=QCEaXsu/OjbQKOKTYOcfuHjvGyeHK9nYJiXxfEUWECrdKCyWwPq0L0FNqeK2N9n0Ae EYhweA0WDiVCNFTXO/Wu2yt+0iX/rIGOjay3O9J0T5PfyRcM9Od/wAOnZeMKsTEccNB1 kBPODFp6Fy5xfTTUhVz+KrAXlcmQwZdHP+yI41uKkVWzMoTXmLqYZGqI2hHTgzIP5M4q /RAASByDELA1VcinP8SU4Nnn47z78AHy+V6TX7KQ4FM3dvquhkssjsbw6ytwlZpCQ4zG C1OUBzTPW44akruzEoyygVQ3dj7HZ9nnKMlsFkidV34OJTbRtTmlN9/8JVCA/Jd6/d8K AasQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678781972; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8uO2pb0aT1NnyTIVfLkUifV1o9o6G5xDatiTfXnW8OM=; b=EiV4Bt7Vq1/UJecUHpaIrMjjObOenc/BYgoPtWDJDBFg/D5aTLOEec+Kst9bFqSe+H f/MUMXUWor5QDs7LuXY2SZs5TOzvUqVVykpuwDb6rbZdqA3RAuDFZr4uh72PE8d67shN 2gjNiftjKTCgGAJ/gqIUXzFIGkML1NOTs9WqfcZn5btHo5PukGxralzCm1rYRnKwad26 jB5ycvODNo7pGGeZaAv/Ug7suJ/5mdykPapcfMnFM3H/eEmyOKLnJ2PGfLnX6XNThxLy 6AQtFS7681YdM4CeLPnBcgs+9jTsgev11WWGbQ3WKx9RwbJsBaHWwMa/m2pG217kJKev zWAw== X-Gm-Message-State: AO0yUKUguA81oodBG/3/NUC/7BuLjyLeQTwYhg+Ve6R0mCgxgMR5GGyX 05raSydbEuyGb7SOnv3GoVI= X-Google-Smtp-Source: AK7set/EQKyfrynoi8fEAytH0KIk6OtEN1YHKRHZ+aytWMZMlLInWc+g/9ht3BCMiq8qdv6zEI7rTA== X-Received: by 2002:a17:902:c407:b0:19e:7490:c93e with SMTP id k7-20020a170902c40700b0019e7490c93emr49670592plk.63.1678781971870; Tue, 14 Mar 2023 01:19:31 -0700 (PDT) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id w5-20020a170902d3c500b0019fcece6847sm1113921plb.227.2023.03.14.01.19.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 01:19:30 -0700 (PDT) Date: Tue, 14 Mar 2023 08:19:18 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, netdev@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 4/7] mm, pagemap: remove SLOB and SLQB from comments and documentation Message-ID: References: <20230310103210.22372-1-vbabka@suse.cz> <20230310103210.22372-5-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310103210.22372-5-vbabka@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2D40E18000A X-Stat-Signature: gpz9egy6dhpmwess6e13knp8qaz3aedw X-HE-Tag: 1678781972-687178 X-HE-Meta: U2FsdGVkX1+6NMFWgctOgaRIiQtiy+mCJn4yBfaQZlPIeEyafIgFEqyZLpQozjyg4ZFTTrgzz6nQDStIXgZB5Rwe+bXDOHeKdYsaFoa74b+1AQNr/am852m5GDBFeDFNg1Si1kIZ3ARPVjRnm2lxCR9wEiBA6JTZ9V8d4YB6d1whZT+iAqH9wbOimhbDSg44spogln8R4AoX0kzmLg8cba6aCkfKEB5i9kfxptjhKfP2+dpA4UVF8rbIMQXiNLiwpCVbKKEVjrjAB1Mv42Hw842bLtC1/36WMC74zb0BJAzOycubdgvu89QwV7VwJuXGd9jBnvvodeAD02Yd/lTs8T15Fd7DI/JHZPf8JEHi0Xtlynku0pPUpF0BsCGVm7nRsNRdOsb8Yp9eDBT7alrgxGdD9z7MqVei7NC4GCdxy64HEZ18LDXDyBJ4TSeFiT2Y5WITfnuZps4k/1on+FFUjBVz85oRFR9SZMS8h0lmFRvxdEVpTE0zvYVZUQeB1fVkS0kpiZO9VT29tdfOUWArfms/vQGGuAbOX+rtqtA29bkcPMscPFiDXFLbANnyhiw/q9kZMep4CZ/Kd4dWGAYsmZed6fyVNSPr5ENRxTo5rmG4drJ5/61h8pRlGjyzju4vecPQQAuWyxSF+dFYjVuaccDZ+Wmb1w8AllGRt9uLnWbzPvNfSzJO0k7zSVbDuwqulBsruBEM1iPxQ7IvPexwBWqPQ3EGl0fjXIojo3cuvHxLomu0Y90pl2OHUhytEmDIFkeRUcGRXVRzuLfALRnzL/FfBGYST2trPOLbfiSD1x8Ljgz+W0jIz8upfysXzD1aFBqFqjsBmrZbBc0dvPK59uH5JnMJNUSeCqE+8E/J+KtlVTlbjTWEqhrRgHX/UPioyS4n/YBrtwL3TZvH3t76WPAui6ob1Qo4zXLiykX7tZ504tQ42TajyJWTNLVXUcG/e9xfqCTdwK1idGp4Ak9 illd1fi2 s/yOknlkwpAL9ABmrgut41lS3EeBFu28laJWGvc34DEhraW6yFP3uO1V418k2Eb2IV78dwNN+h8B6KNFFDTRFgT6/C1NXgC/jQ16250YEUqjfMY6eoESQ7zLuyl+uJSfPEbM4dv5+hRLtpr0FQiWpMSOzznWquCSOISI6xCrX3lVYux1dXsiJSt1GNhjWvFS5/UqCyYaazybNAMYH2N6wYa3jHN1TO+DTrW8zE9jz0tnfKH/NuhbVJFV02zyaydaefWFhKm76LOik7LXCzXQ23N7JW5yIUsFjdQzH8hY60JtKyHg4Y2ww+A5Bax7mLKz4Dyod8TEfUvXRZM48g8vfvxbtT1R3ofstCLzik6ofxwAde5HuHYMK2O5TJbhzrskO2owfUSESHJ6kzYdbBylWG9cRT2gwd50g112KasFMx4fJXHVgW1SZDVZxRXDkGm7QuEWaPbD0ATrPPj2iFjPsVlqRTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 10, 2023 at 11:32:06AM +0100, Vlastimil Babka wrote: > SLOB has been removed and SLQB never merged, so remove their mentions > from comments and documentation of pagemap. > > Signed-off-by: Vlastimil Babka > --- > Documentation/admin-guide/mm/pagemap.rst | 6 +++--- > fs/proc/page.c | 5 ++--- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/Documentation/admin-guide/mm/pagemap.rst b/Documentation/admin-guide/mm/pagemap.rst > index b5f970dc91e7..bb4aa897a773 100644 > --- a/Documentation/admin-guide/mm/pagemap.rst > +++ b/Documentation/admin-guide/mm/pagemap.rst > @@ -91,9 +91,9 @@ Short descriptions to the page flags > The page is being locked for exclusive access, e.g. by undergoing read/write > IO. > 7 - SLAB > - The page is managed by the SLAB/SLOB/SLUB/SLQB kernel memory allocator. > - When compound page is used, SLUB/SLQB will only set this flag on the head > - page; SLOB will not flag it at all. > + The page is managed by the SLAB/SLUB kernel memory allocator. > + When compound page is used, either will only set this flag on the head > + page.. > 10 - BUDDY > A free memory block managed by the buddy system allocator. > The buddy system organizes free memory in blocks of various orders. > diff --git a/fs/proc/page.c b/fs/proc/page.c > index 6249c347809a..1356aeffd8dc 100644 > --- a/fs/proc/page.c > +++ b/fs/proc/page.c > @@ -125,7 +125,7 @@ u64 stable_page_flags(struct page *page) > /* > * pseudo flags for the well known (anonymous) memory mapped pages > * > - * Note that page->_mapcount is overloaded in SLOB/SLUB/SLQB, so the > + * Note that page->_mapcount is overloaded in SLAB/SLUB, so the SLUB does not overload _mapcount. > * simple test in page_mapped() is not enough. > */ > if (!PageSlab(page) && page_mapped(page)) > @@ -166,8 +166,7 @@ u64 stable_page_flags(struct page *page) > > /* > * Caveats on high order pages: page->_refcount will only be set > - * -1 on the head page; SLUB/SLQB do the same for PG_slab; > - * SLOB won't set PG_slab at all on compound pages. > + * -1 on the head page; SLAB/SLUB do the same for PG_slab; I think this comment could be just saying that PG_buddy is only set on head page, not saying _refcount is set to -1 on head page (is it even correct?) > */ > if (PageBuddy(page)) > u |= 1 << KPF_BUDDY; > -- > 2.39.2 >