From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33AB6C6FD1F for ; Tue, 14 Mar 2023 07:26:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D5DD6B0072; Tue, 14 Mar 2023 03:26:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 885F36B0074; Tue, 14 Mar 2023 03:26:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 726FD6B0075; Tue, 14 Mar 2023 03:26:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 60A186B0072 for ; Tue, 14 Mar 2023 03:26:05 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 30ECE160C3E for ; Tue, 14 Mar 2023 07:26:05 +0000 (UTC) X-FDA: 80566669890.02.68BAEB9 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf16.hostedemail.com (Postfix) with ESMTP id 582D9180006 for ; Tue, 14 Mar 2023 07:26:03 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lczv1+oC; spf=pass (imf16.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678778763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P4btLFxdwo7HqZYxM4e3XDdeo+DTrgbyuCAt7JOXufA=; b=8QYz92xkIdjIGQZegwU5tksujx+bVlPrSFbSQB2tZKf+KvqfEKeWX09xvEzqeidptzWeSp 1YeJC5u2/7NXMJRmP02ydoN2Af0GGY4qdKpldutB/NXYkpr8iJqGwmPTPHeE8DO4WifJBi smEMIut+Xqj36XR8RpiZmXrzcQIcKmE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lczv1+oC; spf=pass (imf16.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678778763; a=rsa-sha256; cv=none; b=gfX3QiMhLW1IwNdw43aZxg2BawklgS10VFgSh03a94r+t1/uqfgzDoNJ7B46t6/RIl9bi+ UT6PdP7cgPWhNwAjV2ThhCHQ8VhEk3wlDTbzeyrpcnHtcSA+3wxCsEVVhWY3GImYh1SSvE nZ0EC/PSL73kYxhyXQXxOHcPVJ71JQ0= Received: by mail-pj1-f52.google.com with SMTP id d13so4464266pjh.0 for ; Tue, 14 Mar 2023 00:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678778762; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=P4btLFxdwo7HqZYxM4e3XDdeo+DTrgbyuCAt7JOXufA=; b=lczv1+oCjA44tNBOXDuZb6ygf8VSugMU6SI4f3m4RkNiRBcKFtF/kAxXclBRAPKP8B M/0j99Xagn3nWRglvofL8CNl2IX2uyNzs3OsDdxT8GkAT/ILtxTcLB+Vjamhuf0yc58z hpd1OAyI2vqMtBI+oVFj2hKq7nkNYFHdmVEnU79S0Gjcorj7a6d34QqlN5bis3OyKhmk kp3XzQXtVR9Ddc6fqEhJjD6nRuiePRIsAX5U8mnaXz/nnpq0CGR/c9RZvb1Ik5DfOOA0 S2TV3diroWan8IfHdVDY6rRKIpMvad79Rdt8/Icjq6QYxvmGhsfAtQiXQ3RHVi51gz9D dF+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678778762; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P4btLFxdwo7HqZYxM4e3XDdeo+DTrgbyuCAt7JOXufA=; b=NANro7hr3eWV388S8ONxsH428NdYMvJtPpwHALXXltNevXx1Hz+2U81dv7wI6KMhN/ Qk6yVN8FUvx63ISMdCJYMkLi+o3zCQqx7OgMLelDMsvaQp+Ksm3Ja9eDq3GWSYCtPoAz rxLtZVonD3joXjGfivgmRhzp4Fk/sUeQoqO+1R/19qC+dvAiULh1ciq+VgNAd10UbvHb 2kbZFR+40Nb2sgrYE4ETy0vvsaLNjPY3i3bIv5H/XruIYrW2qhvZft7K7cSuJgdsPy7/ a4R4/NbeToVTnh3ZPbPfhnbuUScF0gZVenFAJ4H0SelRWeHVao/4THDTZ6eGweItPsr6 Z/ag== X-Gm-Message-State: AO0yUKUfa6NteaDe72ewOLW8Y1xBTZxN2bf4+8aK0alS4e4AwZZ8EVoU jgR1jKKXI98LWbckCN9+n0A= X-Google-Smtp-Source: AK7set/kZq/B2QShY0y1HE88ddus1pElLywW15Ta+0oYzLvi6YuddzUADJuwEfCk9yGr65u+O8CuGQ== X-Received: by 2002:a05:6a21:6da6:b0:cb:e8c6:26a0 with SMTP id wl38-20020a056a216da600b000cbe8c626a0mr49148859pzb.11.1678778762183; Tue, 14 Mar 2023 00:26:02 -0700 (PDT) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id l190-20020a6388c7000000b00502ea97cbc0sm888625pgd.40.2023.03.14.00.25.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 00:26:01 -0700 (PDT) Date: Tue, 14 Mar 2023 07:25:54 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, netdev@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 3/7] mm, page_flags: remove PG_slob_free Message-ID: References: <20230310103210.22372-1-vbabka@suse.cz> <20230310103210.22372-4-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310103210.22372-4-vbabka@suse.cz> X-Stat-Signature: tc3x5ifq88c4pxrsirj1to1r53bnax44 X-Rspam-User: X-Rspamd-Queue-Id: 582D9180006 X-Rspamd-Server: rspam06 X-HE-Tag: 1678778763-869725 X-HE-Meta: U2FsdGVkX18Rl4n20A+1zrVRR0R4mMvBp5JVxRchVVC9bUdk6mJxEh99yiq/O662HrhWLrddaAR7ciSpsRvNREBIulynbx7vWfaub6irQkj+kHjywPcgL5UN9dNPbgvJzbzTQGYwAG4T7DjcRR3goMq8SHIDkDm7N4jK36SX0u6Iu/tGRp+6lOBbfgCgU9EyrRmXw0VB/n5XS0EDf5LY9v7dMSU+Y3Zi2x2N9/wui09yc9PfxhkQVJR9csMf+bG/oEqTdIo4anFfDdyCd5gJcc8GWXVoM2kqn1gBb6hLKwcoeAYQh0So0WecNRb0yeTnEIxbOsaVHVSAqF21Zokq9M+w5Qgl+RpMNFvFeP/Njp0Xa0ff2GRBDcRyO9ySDZNqxULaB/QO7HBvhk8LnS/CAp5pBeNkFdlyi4RQS/JWWOG/ozI9AngOSwzXE7JU8s+csEqEBmd7QFPIUE8JZJxEPAR7Ph/Y5xafM3CdbDS5gU9Y2GiqVZYgQizlzNhhlU/rRX70NuzV/qW+zFoD20ugcpIvUDB3umFbDikNE+n3MssavqpRn1mqr08h2lbd3QJc1DZZotjgdhpEt10dJUrGzON2g1Jno/yv/RKYZzbrwoQh5Re0PAEq+D/MR3HrQckFk9JoKREb1pRXuWA7b/kfiDWFDN6o8lcjSn89kJZq8tV2eCbnpHSQxApJQCIraJErzjb8n0itIVbV+WlUqa4Tz8fanB16Fj4DRXUdTsN/iel37uj9xmi2jxgfgAxG3HW43NBnkx2GmRyX9e/ynvyW0RJ2152RNSwY8oA9eVMbQW64j8U0NSSC6e3Ii91m7c42Sf+dg0On3T/AOoBft2Aum6EbT1bfh2brl0XMMlt1O2vVuPHGmAGANpr04Vsm5lhRPoJQZGC08ltsCpNbaglmeAdgyTy43BZB/cQTiwtvGTjJBwHxf95z00ZGmZLqmZSeSil5yfo/uhRyjlL0yJ8 Gsy54jxo vEgjX6RftJz9kJRMIYVj8N4Zca5RqiFhRPFble62RPtajg3tTavbjte2BUOQdDWV/2fjRdnomEEGlTDuKjPA//nxGVeAc48s+1PGVC9S26o8bWg1gAJ0RvLAgbWCySlfXrhsVmH8Y/L8Y1x8gNNzjctFgjl7sg0R30cYK4W0zFrXuTVNPLoKMsv9xdRsek2iwrKRVzeegqz8wcQoenCJzocpQzYzB2HFFqIezST1f/TLQafscxJ+Hb99BqyCn9wlqKPH6CxShwanjMIS9mn6LH5AuHed/0uKoy3/Po3WvrF9Vavj1Gz30LuQ2Vinb3Sy1JJ9LBKmmGhAGiAQTlETc7+8qr7uD+/mrJxz+whXuoMfWbHHKnJXZWZwuvJhd7sxO1sbBqvMhT69Tf7ubwr3LSifkYfz8KIJNTn52t+S52WAGt7gter2csuf4COa0YmSanrymafJ8W0Ey5p+dInxIQY5582EiGHoLk4BfO53MC0wJk3pc5G4/nZzlHM+CzdHhcZgsMZHne/VoWwl5eLK0C2QB8g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 10, 2023 at 11:32:05AM +0100, Vlastimil Babka wrote: > With SLOB removed we no longer need the PG_slob_free alias for > PG_private. Also update tools/mm/page-types. > > Signed-off-by: Vlastimil Babka > --- > include/linux/page-flags.h | 4 ---- > tools/mm/page-types.c | 6 +----- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index a7e3a3405520..2bdc41cb0594 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -174,9 +174,6 @@ enum pageflags { > /* Remapped by swiotlb-xen. */ > PG_xen_remapped = PG_owner_priv_1, > > - /* SLOB */ > - PG_slob_free = PG_private, > - > #ifdef CONFIG_MEMORY_FAILURE > /* > * Compound pages. Stored in first tail page's flags. > @@ -483,7 +480,6 @@ PAGEFLAG(Active, active, PF_HEAD) __CLEARPAGEFLAG(Active, active, PF_HEAD) > PAGEFLAG(Workingset, workingset, PF_HEAD) > TESTCLEARFLAG(Workingset, workingset, PF_HEAD) > __PAGEFLAG(Slab, slab, PF_NO_TAIL) > -__PAGEFLAG(SlobFree, slob_free, PF_NO_TAIL) > PAGEFLAG(Checked, checked, PF_NO_COMPOUND) /* Used by some filesystems */ > > /* Xen */ > diff --git a/tools/mm/page-types.c b/tools/mm/page-types.c > index 381dcc00cb62..8d5595b6c59f 100644 > --- a/tools/mm/page-types.c > +++ b/tools/mm/page-types.c > @@ -85,7 +85,6 @@ > */ > #define KPF_ANON_EXCLUSIVE 47 > #define KPF_READAHEAD 48 > -#define KPF_SLOB_FREE 49 > #define KPF_SLUB_FROZEN 50 > #define KPF_SLUB_DEBUG 51 > #define KPF_FILE 61 > @@ -141,7 +140,6 @@ static const char * const page_flag_names[] = { > > [KPF_ANON_EXCLUSIVE] = "d:anon_exclusive", > [KPF_READAHEAD] = "I:readahead", > - [KPF_SLOB_FREE] = "P:slob_free", > [KPF_SLUB_FROZEN] = "A:slub_frozen", > [KPF_SLUB_DEBUG] = "E:slub_debug", > > @@ -478,10 +476,8 @@ static uint64_t expand_overloaded_flags(uint64_t flags, uint64_t pme) > if ((flags & BIT(ANON)) && (flags & BIT(MAPPEDTODISK))) > flags ^= BIT(MAPPEDTODISK) | BIT(ANON_EXCLUSIVE); > > - /* SLOB/SLUB overload several page flags */ > + /* SLUB overloads several page flags */ > if (flags & BIT(SLAB)) { > - if (flags & BIT(PRIVATE)) > - flags ^= BIT(PRIVATE) | BIT(SLOB_FREE); > if (flags & BIT(ACTIVE)) > flags ^= BIT(ACTIVE) | BIT(SLUB_FROZEN); > if (flags & BIT(ERROR)) > -- > 2.39.2 Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>