From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3B8C6FD1C for ; Tue, 14 Mar 2023 06:33:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94F5B6B0072; Tue, 14 Mar 2023 02:33:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FFE16B0074; Tue, 14 Mar 2023 02:33:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C8106B0075; Tue, 14 Mar 2023 02:33:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6A66F6B0072 for ; Tue, 14 Mar 2023 02:33:42 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3A3A5A06F4 for ; Tue, 14 Mar 2023 06:33:42 +0000 (UTC) X-FDA: 80566537884.02.3FB5F3F Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf17.hostedemail.com (Postfix) with ESMTP id 6BF6B4000F for ; Tue, 14 Mar 2023 06:33:40 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WZMLxYnO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of vernon2gm@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=vernon2gm@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678775620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eWhc5GI6KxiqzBSNgylF0hu+tPDYSfgvHUxc/4hzpYk=; b=H+6PcgyfLc9joJyRbN6Yd6o/wL+RXKDCzoKwraXZzsado+nyV5Dv/dW4a57bHHWazgdnTf vFcGE4VAZdhjmn8ivcZjiK0pJPTWngxUupsdgEe2ZA2dRSVLO5c1xn2SjsIvx9G3kvunIN k21JSrgmISSOSApnTgIF5GSmo9EEC5M= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WZMLxYnO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of vernon2gm@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=vernon2gm@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678775620; a=rsa-sha256; cv=none; b=51vR3jz3VEL93/b+lHqjV+TWyhcYXnlRLEiS2YnOOwNr3QJfD95Df4hyNio9iioVwYDD5A Io9BaYU2cOTguqvLO5tx1FDlNn3uHkNiGmKsq3XcyVjR9is1OwqemuUVbBr/IPBBjXHOY3 BK+x05ncmFop4W1d0sQrUMgCPtdvkGU= Received: by mail-pj1-f53.google.com with SMTP id y15-20020a17090aa40f00b00237ad8ee3a0so14126030pjp.2 for ; Mon, 13 Mar 2023 23:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678775619; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eWhc5GI6KxiqzBSNgylF0hu+tPDYSfgvHUxc/4hzpYk=; b=WZMLxYnO9qDcaaIsZ5nrDoWGNVvWDi3HDW/6rytnUzEHGwOP61EefD91KkRmH8LiZL vaIfbkwNIhj9vqgZdW5mnSWASh28uh632JY8/rbJDkDPup7CjGt3WsX5vnoJx2CyAVaO g9nzjuMgF3DEixBOT0/F0vLNz9JwSOWDwSpGZKdu6t7A7e+r0w7mbuTj1wt52q9KXSra iulVHi9lX+Mb8lEcM3vbFvszIMPfjcrQrq7CuKiz/YYnGszlD4eMSX17nHpmw57uJgTC 40azU5JuwbT50om1OiQVnIhb/+hDxK2QnZ0x930YzPViFewwhrNvyj6jZct4SxNPIsI0 l3eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678775619; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eWhc5GI6KxiqzBSNgylF0hu+tPDYSfgvHUxc/4hzpYk=; b=0Q9ffD58kQHX8B0spko3B93xvvQB2ue1DQBHmH08twT+5pA898iZrinx7vuqYz5ph7 u/38e6UWK65jzKLPhEVdzX0sXjOgu2w4rTTI4Gf4A/siu+Lx/rVsaxb/y2SA7xJmhZ4W sQFr8tMJ5FsgFNRAjO0NsCb8QOOAK3eYwwuheLl2J4zsFIOQqrrCkG6t2bDOa1jTADPf 8GwHgFR7Qa7rWwDKvWiF3ef1K4rI8HIx/mA6yQIznvUL0rtVBUx5S3xclfMb7ieXptDS 3JQrbpXWqNYtFsn4UyjBOkctDxdgt1I3x31Jb56sM47MLMwUMuuGtXpewEx/D7W1woXd 892A== X-Gm-Message-State: AO0yUKUh8ebif/3t6TZL6X0EBVCHHlp3/1DqLfMCFSLO3nTkKhyIPucG rydg7iUOXpAgdVSPHPRRXOc= X-Google-Smtp-Source: AK7set9KQw3OEZASJWg5oP+D7flBYwBxNKRCMplbGTp8Mq535lr4GErZimI1rD4DC7SpEYRme2T4eA== X-Received: by 2002:a17:90a:498b:b0:236:84a:8d9d with SMTP id d11-20020a17090a498b00b00236084a8d9dmr38144469pjh.39.1678775619182; Mon, 13 Mar 2023 23:33:39 -0700 (PDT) Received: from vernon-pc ([49.67.2.142]) by smtp.gmail.com with ESMTPSA id kj11-20020a17090306cb00b00198ac2769aesm893531plb.135.2023.03.13.23.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 23:33:38 -0700 (PDT) Date: Tue, 14 Mar 2023 14:33:34 +0800 From: Vernon Yang To: Vlastimil Babka Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: fix help comment of SLUB_DEBUG[_ON] Message-ID: References: <20230222232058.66971-1-vernon2gm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6BF6B4000F X-Stat-Signature: m91sfchjs4te5hqa9697icbp5peoe66r X-HE-Tag: 1678775620-510947 X-HE-Meta: U2FsdGVkX18WiwQrbRgUrvM0M944cSMaj2/lcRx7cO+gAjKZkRn+8Kr/1rlwTbLiQ+6yqjuyq+uWlB5KvUEcEz/kZKSqocREDZ6On2w1DV6Co2Emjq/eu/SOHi8Zp8FWmWgDyKRSwOydipEIicsQTcgmOOAVEwMg4M5qCNGK0lcuOoR5ELaAqduMlh7ZA2b0t+y2R6Homj0m+bgDlPG/O6zNICthqFN2WUbV8xTa+q6rM0I8TWdQqe9Er5gKmeonJUnyfr9DuvTgNSYFZ2u42Qw8+fHkTRIShv0ATMpFg75xYedDuvQ87lofn1V0hD3rXc/TkG2Qp4cG62MYJTOyyPQlYiy+7Kygzs6DkwMRIcdyYazqYjuymP21I/0HPiAWrZcKjHjJukrq8FgIp+5BreSjK4IOxTgTURpwRMMmsr7E8O8Z185+UYgPGYkUqbL02sDX0+YtLJSO4LNmBN8Ioo5HDGljgYrUgmfs210iAwNSZxQ8XyB1Ff023od/aROZHkRaD5hLhxTHJ+1oOONtf2aaM1WErEVX4aJKlXuJ6Vy2relDvDhz6vrivKrp412NeLseUwIJCXcAaYZObKzOPa3A8cRaJOuo5JDNJyVABQW8lwWe54BpXooiq1TIgJfIk5pmW6SuzMIUs7wcQ93rW3UQ7NiNkkLQH/jBebxTyZppUY/oBzddYgkCz4Os49AiXdoc136bdqpezV9BAwhQM0/qDAmijTgre8KBqJVbK9WNcoWRPIAweXbQPocXgqUQqdW3vHC966SmE/tGd4AlGSbhx14JB6uCXFXSiQ1tXD0CBdFnbXtmK/yZXR5fjlkV2s5bOB07HclSW9ocOdVKsaoCKprQcxIat6vg97kzOCCwXAmqdj/jsB8cZbN5/Lv8hqo/VUTSGdQBuGlGC6X49eDfNOUG6SZNqPohjOTe/UiKC7YHvYkEqswQJJ6xveRKreWRSnaw4JjrvVfcn4c l6SnMp9c aAC1TAlV/nGkDAQ73lbkDG1Q72+WbVGwTiCK0uI/BwwwQbjIZS9mZIxYUt0iyOt3fw28N9k9oGIOda9+VT/wXwBDjPxAPyyZxSOPVODKANncQQ3/EghsgY1VuzpBcGAZpDcoaJmvFtIbZoaDPOGuBqDQ9pvB5kmdy3jSOe1j2Ro3PSta03amlxGEcExCLADbdn85IFs1FJfL7oeYOw1TEpsUVwUWN9hegW3j2XC7BQ9TqdrmqSj9mlOF74xAhir4IdRtAPoqTJhmd5HgA+O+HuykqCAz6iVe4YhUpazTrI9X8ptdQ9Jh2yBaqi3rZ9aM9WSsDN2IELggVRFPphk6QqyEiZo+yTKg1XTizXXu+o/AiFRsqOYxY6jJK42exlq7xliC9sEk/JhJs2Txb/SCZL2mRl1OXyJ8OaMTmMqQrPH7MP5S/CWuSZY32BR0pU4e4XOaiNDEjwTQI91V8D/Amda6OVpjYL/FZIG8+2GBKhh4vFEN9ePO0uekz0QtV9cvgs1mX5Xu9nXmrM12vepC9c3hdYVn7g8K8Fxl9QWbCyJym7Dyofbm4s8s3g5CWfNqbDLA9HfG+20721q8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 13, 2023 at 05:26:19PM +0100, Vlastimil Babka wrote: > On 2/23/23 02:03, Hyeonggon Yoo wrote: > > On Thu, Feb 23, 2023 at 07:20:58AM +0800, Vernon Yang wrote: > >> Since commit 081248de0a02 ("kset: move /sys/slab to /sys/kernel/slab"), > >> the SYSFS path of slab was modified, so fix up the help comment of > >> SLUB_DEBUG to use the correct one. > >> > >> And now the "slub_debug" parameter on boot that is support for more > >> fine grained debug control, so fix up help comment of SLUB_DEBUG_ON > >> for "no support" to "support". > >> > >> Signed-off-by: Vernon Yang > >> --- > >> mm/Kconfig.debug | 12 ++++++------ > >> 1 file changed, 6 insertions(+), 6 deletions(-) > >> > >> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > >> index fca699ad1fb0..732043bf56c6 100644 > >> --- a/mm/Kconfig.debug > >> +++ b/mm/Kconfig.debug > >> @@ -61,8 +61,8 @@ config SLUB_DEBUG > >> help > >> SLUB has extensive debug support features. Disabling these can > >> result in significant savings in code size. This also disables > >> - SLUB sysfs support. /sys/slab will not exist and there will be > >> - no support for cache validation etc. > >> + SLUB sysfs support. /sys/kernel/slab will not exist and there > >> + will be no support for cache validation etc. > > > > After commit ab4d5ed5eeda ("slub: Enable sysfs support for !CONFIG_SLUB_DEBUG"), > > "Disabling SLUB_DEBUG also disables SLUB sysfs support" is not true anymore. Yes, You are right. Thanks. > > Yeah we could say that /sys/kernel/slab will exist but will not provide e.g. > cache validation. OK. > > >> config SLUB_DEBUG_ON > >> bool "SLUB debugging on by default" > >> @@ -73,10 +73,10 @@ config SLUB_DEBUG_ON > >> Boot with debugging on by default. SLUB boots by default with > >> the runtime debug capabilities switched off. Enabling this is > >> equivalent to specifying the "slub_debug" parameter on boot. > >> - There is no support for more fine grained debug control like > >> - possible with slub_debug=xxx. SLUB debugging may be switched > >> - off in a kernel built with CONFIG_SLUB_DEBUG_ON by specifying > >> - "slub_debug=-". > >> + There is support for more fine grained debug control like > >> + possible with slub_debug=xxx, details in Documentation/mm/slub.rst. > >> + SLUB debugging may be switched off in a kernel built with > >> + CONFIG_SLUB_DEBUG_ON by specifying "slub_debug=-". > > > > I think this is a misunderstanding. SLUB_DEBUG_ON is equivalent to Yeah, This is a misunderstanding. I remove this. > > passing boot parameter slub_debug=FUPZ, and what the help text says is that > > > > "You can enable slub debugging by default using this config option but > > there is no support for fine-grained control like what slub_debug > > boot parameter provides." > > > > IOW SLUB_DEBUG_ON cannot be used to have same effect as passing > > something like slub_debug=F. > > Agree with both comments. Vernon, will you send an updated patch? Ok, I'll be sending a new patch shortly. > > >> > >> config PAGE_OWNER > >> bool "Track page owner" > >> -- > >> 2.34.1 > >> > >> >