From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA68C6FD1F for ; Tue, 14 Mar 2023 09:19:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 544F08E0003; Tue, 14 Mar 2023 05:19:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F57C8E0002; Tue, 14 Mar 2023 05:19:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BD688E0003; Tue, 14 Mar 2023 05:19:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 280008E0002 for ; Tue, 14 Mar 2023 05:19:54 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DDF98140640 for ; Tue, 14 Mar 2023 09:19:53 +0000 (UTC) X-FDA: 80566956666.30.9E54D25 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id 0AA7420016 for ; Tue, 14 Mar 2023 09:19:51 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=jzRq+GyB; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678785592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gtLd46OIrgmZYAXx0MQF0O9mmYT+bX7aUyCHRdJ8Qnk=; b=HNhnmL7LE5ub4P1cPPsI34hvvD4rJNyaRpvtWyvjFxfUOp5oSuGohaeg7kGHVp3WuyTDTf 07Nv2Ncw6ltGhZCluUp2oWLBvrUAiA/VtzVGgNTbCrYBT7VZxwYoS6f3uyKIYrCquKSgAQ yR+t97Fe73oft87vSFaVZwLorPTB6P0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=jzRq+GyB; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678785592; a=rsa-sha256; cv=none; b=6G9uR311ivv59OxXrklnk2k2l42iErgjs9IpzxnLaGntegM8gAsq5upNnERZAtiSdp4EoF Hzh+mDoHR0H0yFUQNxUPSziJ/LzjG+cx3UIaemjQG9MuFfr5C4kaRwQbiiL3G5q1N5Hzfl ndU55GiwiKNVgjyJMaFQfqPL3QcLUbI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 75FA221A1B; Tue, 14 Mar 2023 09:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1678785590; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gtLd46OIrgmZYAXx0MQF0O9mmYT+bX7aUyCHRdJ8Qnk=; b=jzRq+GyB5/xUQp7ane+Z4iYT36MHRc+0dxdh4NWT0jF22SHHJ7jkt1Wld5Z2NtZdVLJMAK FYDH/zJBtV2iQcTL/tjnPvtC4kSeUAYvX8tyx1mO9qXW322i32BsjgJrj7FKoHkVZut7dD wsXCAnasDEbgnBN6RyYcpo4v2TJfcwM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6721913A1B; Tue, 14 Mar 2023 09:19:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UTVQGDY8EGQJZAAAMHmgww (envelope-from ); Tue, 14 Mar 2023 09:19:50 +0000 Date: Tue, 14 Mar 2023 10:19:50 +0100 From: Michal Hocko To: Haifeng Xu Cc: shakeelb@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] mm/oom_kill: don't kill exiting tasks in oom_kill_memcg_member Message-ID: References: <20230314091136.264878-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314091136.264878-1-haifeng.xu@shopee.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0AA7420016 X-Stat-Signature: r9tnbrpsdigp1ipinj4pdxr9qr5od7o1 X-HE-Tag: 1678785591-693205 X-HE-Meta: U2FsdGVkX1/JpHHVqz0mQCuz0acApjSiW37LKi3sngDTJWThB85zUeBelVdv27bUCPkYwhS4M+m+wv+iGv9w3E4d5Uogd6lp2E2RZ7tbHSqfm+175Lac71/y95frXrFmz5iuOjdp1rQWKW7HxTLyVnTS4aU4zsxYX6FPTHVAcyz7aMC+7TJeNvLaFEUgYGH4Q+UK7YtOZDYo3FYxL+so9R58l/RS2SKuQghNKDp6WiHBJUZ3iK8YYpKbZ29dieo7ThQv7IiPWsF5HO1hBOn2+YP/MaGTmGRapOHUpfIFgoFN3mvCHhB5WKNLemDDiBYVuAMJs6WnrBK90aDGl1F2/lMIgWeen+Tz8JHFGE8Ef7jq1xi6oBeelWELiEqhf4gPGSAjol7MWVdKOyPYqCBfOzMJQcvQLgDsxromUycTAcy55sCKu0SGNsarXnNBy5O2sYyuEuiGJ5ubezA7MUhcDg/zDKF+UCYsReC5bGRS52415OYsXDKWD91PBKGLemAHzYOOu9qtI+ZfP8mgBeD6aVlMEo+Zh2GErCHrNGsRLNGDTH0YYybdRhdkShc0FaadT7u4U3o06DH92elvqHOsD4Qx2ytoMWhnSt6bYQ8ZauDe6FxtBEh8tZN/zXU3W/MEO1MxuAYrR4EtDMkXifhrnKPMSPVtQw08fgSFSP5Aesap21vxg5sKdQGOyEfixorE/5k6bF5mXpqWJAsMd+1OzyAF7yRq8zyr/xdXF6CmWRx0msnStxHZMClPdzmevF/S4xx5tdcSVTtgh/jsNoGuoFXA4lTkZmSd4a0c6usHYgzUISVgdKz2HqcFYVW0AQNL1CX/eLJqZdKgrZaVk9mL6nMHrLMzZdZjUB0vrdhrFgqVKYap6tKt9VGqAgh7zRPc8hWlf9Lo0cD8VXnVZ9hZNa05LfpZWNjZO92ctM4C3RC4dmXlX+dJF3j8Nt38MYs2VSdBI38fPxQ/Yn87pod e8UE8err rVTyZGog1vJtrmAQd27JLb/2OF17Zspc1VERNQK+8cr63nRXRrTYV6B4jtRoBH8nry9QhD879JAfPnDAE+huSAVsXk/1u/LU9GOh+2lnj4nCsV3Za5MVWNKBL2D4te9AqqSGGmCG6ydWNRCsfvi4S15AVA96LT2vp0O2EY9Oyf2FuitKMgh0PUY/NAjUN8x2UXFBNTf7OrsAbn06zvei2qaLgqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 14-03-23 09:11:36, Haifeng Xu wrote: > If oom_group is set, oom_kill_process() invokes oom_kill_memcg_member() > to kill all processes in the memcg. When scanning tasks in memcg, maybe > the provided task is marked as oom victim. Also, some tasks are likely > to release their address space. There is no need to kill the exiting tasks. This doesn't state any actual problem. Could you be more specific? Is this a bug fix, a behavior change or an optimization? -- Michal Hocko SUSE Labs