From: Michal Hocko <mhocko@suse.com>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: shakeelb@google.com, hannes@cmpxchg.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] mm/oom_kill: don't kill exiting tasks in oom_kill_memcg_member
Date: Tue, 14 Mar 2023 10:19:50 +0100 [thread overview]
Message-ID: <ZBA8NlwBTprShO3e@dhcp22.suse.cz> (raw)
In-Reply-To: <20230314091136.264878-1-haifeng.xu@shopee.com>
On Tue 14-03-23 09:11:36, Haifeng Xu wrote:
> If oom_group is set, oom_kill_process() invokes oom_kill_memcg_member()
> to kill all processes in the memcg. When scanning tasks in memcg, maybe
> the provided task is marked as oom victim. Also, some tasks are likely
> to release their address space. There is no need to kill the exiting tasks.
This doesn't state any actual problem. Could you be more specific? Is
this a bug fix, a behavior change or an optimization?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-03-14 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 9:11 Haifeng Xu
2023-03-14 9:19 ` Michal Hocko [this message]
2023-03-14 10:07 ` Haifeng Xu
2023-03-14 10:16 ` Michal Hocko
2023-03-14 11:07 ` Haifeng Xu
2023-03-14 12:00 ` Michal Hocko
2023-03-14 13:27 ` Haifeng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBA8NlwBTprShO3e@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=haifeng.xu@shopee.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox