From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2470C6FD1F for ; Sat, 25 Mar 2023 06:42:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4355D6B0071; Sat, 25 Mar 2023 02:42:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E5586B0074; Sat, 25 Mar 2023 02:42:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D5216B0075; Sat, 25 Mar 2023 02:42:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1A0E76B0071 for ; Sat, 25 Mar 2023 02:42:24 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DC32D8010A for ; Sat, 25 Mar 2023 06:42:23 +0000 (UTC) X-FDA: 80606476566.16.D3F1643 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 30378C0007 for ; Sat, 25 Mar 2023 06:42:20 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oaSo5cqg; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679726541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7JeTZd97ItngZqc4lp6/3WilahqcTVF2zdF31IPQD6Q=; b=lpMyBTzux6t2v8DQuz4D6Ar3rRjUfA5XAPSXZncCrbzHQS2n1HnzhKehxX8JT96rOkKm1j TB29Yva2jyIv6DS+g5FN1BXuDbuNP6gAjWaotlIgPSYzWvTs5+HXiueWhupvRWzu/E7rTt ebTnlYaRyLEXbFBDQHcjJRj17YoW768= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oaSo5cqg; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679726541; a=rsa-sha256; cv=none; b=HMWeYEtjkBcC+7wKAflcT5E1LToMhETWFpBbWPh2pEcGkKt+jwdJa+klS2HZABh5Wag9zm gljJEdCo+AC7u0ETSXMIdkAJC6D+nTvL2Whe4NpR+3EIUZLoFm1qJEyI39cwe8L7gnAk2r dfxA+MUgTnoAEhituTuU9Q3TME76070= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 484076092A; Sat, 25 Mar 2023 06:42:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A743C433D2; Sat, 25 Mar 2023 06:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679726539; bh=ZSKNjtrK9Vf8IKEQOlIlEf2lZ5+KbHask3b4ybdxt2o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oaSo5cqgUt7L5RFDX4Q/ntp75zHOUp2cAwwCYA+CzEc4JY+oPnZjRY/mdPYrn8l6D kuk33rPdK1yq7QKmO39axfUBszPjpGqmEzSwWPc4QPkl2FP6lxYY2JDaEIvcmSShRG kcW8rhb6vtCSwkNxCzWOHuw2d8kKzA9nm1GQrfLBizAubSa/SDH0eW1xzAoPW4FkLx yn2uGjkcajAjn611jS3J1z+NbOFjYEq9f3NgpDJYYKOpIxikx+dsADu4OU9aw+hRry URdV4koMdn6B2PZiglxyt+g3G8t3zopGpQ2O/n+UIKflUCcvRe/heHjDMaZoSZlVsD PDeOLbKcRp8jQ== Date: Sat, 25 Mar 2023 09:42:06 +0300 From: Mike Rapoport To: Hongbin Ji Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock: Make memblock memblock_dbg info handle overflowing range @base + @size Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 30378C0007 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: wiwqcdyt8a43fri8e8k3uaipem83f98j X-HE-Tag: 1679726540-522749 X-HE-Meta: U2FsdGVkX1+Fgly1VzG4IwIkeg1abwUY3dljQgqizEwuepJ2byEe5Y+Fivz4ejLZV2zSr73SnfjicnEQ1Hdj0a3TuGmZDaMfEqSgv3N+aAfY5rMukuBSIKNoiPYg7ia/N6u+040WeISVvT+ToSVMle9y2KAqQpBkt+y3VRBF5NwYewe/0CUEcOBJ+bFUVrBWXXIrRDRvE+/sEEmpLFJRIzLg0KqnSyiwC+c3WFromfwkN/EDFnzrTlO4mucNUncG4JcFvG3t8vXNWRKbAUYJJjP7ENE3Gf/3w45FvL9Ys4rH+5D9qtS4r2ive8FDBWNAFQFzoq4K+GgRif/0bczdWpwQ9PouybTVFUaQGr7YXV0TWBJBeuK1FtL0Yanc9uTpzN0MXVS4mPyCikwGBenTgbocuXQg0azBckxCcMeaUswfyBkjn7Wmkx2cqqn3hNtG711HT0WT2P2ZzF6zOTenffs4eTs2SJFKAxi5TC8Z7sDwFp7Vml5ayoDiF9TJe454W+llyikD2jbZX4mqC+hSiw0Ljgd4eMwwM2t2diLlcVLNZaBN3gqAju6C2qsh5A8BT6iBs64DTP1ox3awps310IpwlPa5gNWe4B34AgXTgouoAemqj3n9WZBQvZcgQy7anhg3hBHXx24/IxRtKNEx/9aeUsglhHX9ByRWzBJoRZUqH5Px6ZHDYXQ/KrgWtfCZDNVJI6D59MtGtsOk+UaoSbzYrkHcxmqLQWbtEa+3FLVXfHkdEmp+FpevGfyfyl40xsgyy+hkhFOga1c075Sqdgz0Fc93d593e0/5D5zVyX0dRN2ry6S3N/oTwr9fyW9iF6qyW7tWhm2+jiKrFaQb8CRWn6EqaYzfJxExgJJYh5WAlU8NDnPX+qXAlGUclTUxPQguNlCWmKXSQIJCAP9/GSygen/nMxdXdBmMIyOw8LnYHkXIWQK0ytnMDmfDNg1Y5bp+n/manqYWA1agKNm XXNFtAtt PA3lgyR+AQc5GPn9jMVsbHZBsebfOCBAFyrxskzzRkkCIU9UYBw5MaY2vzNSJJ3++cO4pK6pMzQZfQt95wkXeMiDaWXW5hb87BfH3lXthVB06aqOoBt+GrWS1FAoD4et9fQPL3AaVZmG5CX2aW+umDcNser2Y1Dt/dSJYSoyW0fKHEzaqem/oDU5pvlbDhJeqGJw4oUq1zmsD+Tvc3EiIKFSFhD7Q8irfJ7tu94DMBr/STvfMx71SMmQyprIW1aQO+88cY8ETuLQfOGUzgJ5hoysFIXJXSj3770B1S1Fdtr06aDnSX/WHPQ22Nl7a7CRQ3VgfIySDyYgZsnCBycGiywgUzH64xv85LXeS8Tux/h+ucEXdKEAitNrczNfeBwdp1PKi7q3K+BMqc3EUXKU6Y3ZVvJPPtpTep0rodqsMmhHn2Rozdq2KUAe7l5XdAxY/UVBBMbh20gNQ+FzhAQaKMwp4e2BQZ4tqfrnW3wovceP2DzE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 25, 2023 at 02:25:58PM +0800, Hongbin Ji wrote: > It is just to correct the information displayed by the debugging. > The wrong information display is also a problem, but it is not a > problem that affects the function Please don't top post. Wrong debugging info will be the least of the problems if memblock_add() or membloc_remove() are called with wrong parameters. Please work on cleanups based on code inspection outside of mm/ > Mike Rapoport 于2023年3月25日周六 14:04写道： > > > > On Fri, Mar 24, 2023 at 04:15:13PM +0800, 纪宏宾 wrote: > > > Allow memblock users to specify range where @base + @size overflows, > > > This will cause the address range information in the debug output to > > > be displayed incorrectly. > > > > Is there a real problem you are trying to solve? > > > > > For example, calling memblock_remove(1ULL << PHYS_MASK_SHIFT, > > > ULLONG_MAX) in arch/arm64/mm/init.c, > > > would be displayed as: > > > [ 0.000000] memblock_remove: [0x0001000000000000-0x0000fffffffffffe] > > > arm64_memblock_init+0x24/0x270 > > > but we expect the output: > > > [ 0.000000] memblock_remove: [0x0001000000000000-0xffffffffffffffff] > > > arm64_memblock_init+0x24/0x270 > > > > > > Signed-off-by: Hongbin Ji > > > --- > > > mm/memblock.c | 14 +++++++------- > > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > > > diff --git a/mm/memblock.c b/mm/memblock.c > > > index 25fd0626a9e7..567b99e4355d 100644 > > > --- a/mm/memblock.c > > > +++ b/mm/memblock.c > > > @@ -700,7 +700,7 @@ static int __init_memblock > > > memblock_add_range(struct memblock_type *type, > > > int __init_memblock memblock_add_node(phys_addr_t base, phys_addr_t size, > > > int nid, enum memblock_flags flags) > > > { > > > - phys_addr_t end = base + size - 1; > > > + phys_addr_t end = base + min(size, PHYS_ADDR_MAX - base + 1) - 1; > > > > > > memblock_dbg("%s: [%pa-%pa] nid=%d flags=%x %pS\n", __func__, > > > &base, &end, nid, flags, (void *)_RET_IP_); > > > @@ -721,7 +721,7 @@ int __init_memblock memblock_add_node(phys_addr_t > > > base, phys_addr_t size, > > > */ > > > int __init_memblock memblock_add(phys_addr_t base, phys_addr_t size) > > > { > > > - phys_addr_t end = base + size - 1; > > > + phys_addr_t end = base + min(size, PHYS_ADDR_MAX - base + 1) - 1; > > > > > > memblock_dbg("%s: [%pa-%pa] %pS\n", __func__, > > > &base, &end, (void *)_RET_IP_); > > > @@ -822,7 +822,7 @@ static int __init_memblock > > > memblock_remove_range(struct memblock_type *type, > > > > > > int __init_memblock memblock_remove(phys_addr_t base, phys_addr_t size) > > > { > > > - phys_addr_t end = base + size - 1; > > > + phys_addr_t end = base + min(size, PHYS_ADDR_MAX - base + 1) - 1; > > > > > > memblock_dbg("%s: [%pa-%pa] %pS\n", __func__, > > > &base, &end, (void *)_RET_IP_); > > > @@ -854,7 +854,7 @@ void __init_memblock memblock_free(void *ptr, size_t size) > > > */ > > > int __init_memblock memblock_phys_free(phys_addr_t base, phys_addr_t size) > > > { > > > - phys_addr_t end = base + size - 1; > > > + phys_addr_t end = base + min(size, PHYS_ADDR_MAX - base + 1) - 1; > > > > > > memblock_dbg("%s: [%pa-%pa] %pS\n", __func__, > > > &base, &end, (void *)_RET_IP_); > > > @@ -865,7 +865,7 @@ int __init_memblock memblock_phys_free(phys_addr_t > > > base, phys_addr_t size) > > > > > > int __init_memblock memblock_reserve(phys_addr_t base, phys_addr_t size) > > > { > > > - phys_addr_t end = base + size - 1; > > > + phys_addr_t end = base + min(size, PHYS_ADDR_MAX - base + 1) - 1; > > > > > > memblock_dbg("%s: [%pa-%pa] %pS\n", __func__, > > > &base, &end, (void *)_RET_IP_); > > > @@ -876,7 +876,7 @@ int __init_memblock memblock_reserve(phys_addr_t > > > base, phys_addr_t size) > > > #ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP > > > int __init_memblock memblock_physmem_add(phys_addr_t base, phys_addr_t size) > > > { > > > - phys_addr_t end = base + size - 1; > > > + phys_addr_t end = base + min(size, PHYS_ADDR_MAX - base + 1) - 1; > > > > > > memblock_dbg("%s: [%pa-%pa] %pS\n", __func__, > > > &base, &end, (void *)_RET_IP_); > > > @@ -1645,7 +1645,7 @@ void __init memblock_free_late(phys_addr_t base, > > > phys_addr_t size) > > > { > > > phys_addr_t cursor, end; > > > > > > - end = base + size - 1; > > > + end = base + min(size, PHYS_ADDR_MAX - base + 1) - 1; > > > memblock_dbg("%s: [%pa-%pa] %pS\n", > > > __func__, &base, &end, (void *)_RET_IP_); > > > kmemleak_free_part_phys(base, size); > > > -- > > > 2.34.1 > > > > -- > > Sincerely yours, > > Mike. -- Sincerely yours, Mike.