From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE59C6FD20 for ; Fri, 24 Mar 2023 18:11:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0FCC6B0072; Fri, 24 Mar 2023 14:11:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBF326B0074; Fri, 24 Mar 2023 14:11:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CADEF6B0075; Fri, 24 Mar 2023 14:11:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B937E6B0072 for ; Fri, 24 Mar 2023 14:11:47 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6E079AB85E for ; Fri, 24 Mar 2023 18:11:47 +0000 (UTC) X-FDA: 80604585054.18.2E57FC3 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id B19B04000D for ; Fri, 24 Mar 2023 18:11:45 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=I6qos94q; spf=none (imf01.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679681505; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gnerbpCPsPLVCcKOjYr9IDYevUX0qSWzWV6ueg4TeJI=; b=Pd2jYXe3Jusk2ePjg/x3itlvscs4Se2D8NKhljutBmQDr5/leqHiAAukHb9czBDsNyNHMe E0avqgH7dXR2LFcdpo0sQxdV7P2Aqebdt1sn0jwTR5/a7bqhaygmMX0aOMnJPIMDyI6p0b pSS0GBoahxinNR3xKxxd8FicZFUrNqw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=I6qos94q; spf=none (imf01.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679681505; a=rsa-sha256; cv=none; b=R3BjY+17lGtHsb3RNhYtqxSmFLQ8I0xzXfWEassGMPADY2Bbfrf9fm23u/cw8bGEH8934t Zs6HFNE5YzzeyAqSC/JxHeF2LITyuVDgveQAqRZybO6e0V3bM85oyrjfmkQJmMYTKuXQGP v59QQ1rnwJZGCZL7E+9uwesTTR9zucA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gnerbpCPsPLVCcKOjYr9IDYevUX0qSWzWV6ueg4TeJI=; b=I6qos94qsOkjPfh25S2EXs0EEw kAriqRKGUCL+rq7FwvkPTaOKDGAkyKTXMpp464X8uHCrl7zZXsAY9j3bdYdAmGO3OSXDWqnq8Npy4 8b2SN2yLnvFkxzB4LAIfEIWwb+i/GrFapFYGHyoHkjPSfocGhxM8IvUeEIupFbk1WfK3Ne+OpBibY 5A23eQcv8T96dzpYb2V96rWPc8+IHxSnHL2au6i3WuJxsn1pPdC0Air3yC042qxp+pHRjzdai1q1r It0Li1iOkF7qcMRScRPQlnrzPGwABos/hCnvCfjgFKiz9riaUq8u0bmGqXt1VU3bzY5yl2WJEu2/3 NDw/DdpQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pflt0-005GES-1Z; Fri, 24 Mar 2023 18:11:34 +0000 Date: Fri, 24 Mar 2023 11:11:34 -0700 From: Luis Chamberlain To: ye xingchen Cc: akpm@linux-foundation.org, chi.minghao@zte.com.cn, hch@infradead.org, keescook@chromium.org, linmiaohe@huawei.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, willy@infradead.org, ye.xingchen@zte.com.cn, yzaikin@google.com Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file Message-ID: References: <20230324062408.49217-1-ye.xingchen@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230324062408.49217-1-ye.xingchen@zte.com.cn> X-Rspamd-Queue-Id: B19B04000D X-Stat-Signature: zh4yd37w5a7ski47iibtd6oq3rmh9jsa X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679681505-497820 X-HE-Meta: U2FsdGVkX19GFPnqfCDwI0gwA6RtzYVZ8bzp6307vMkiAnOh07bPHrJP4ug0tlvHkGhvs04797kOxtZNVp1hOFZPn4zch/Ib60gGxQZaB/8NAa/rOBe1IPUR13W6hRqrb15sqG7+/jWX9vEsyLTeaQTT70eAcekk5+Z/hvBKq95EwVM54OZ8qABrt8JgNUVONIxbaMF1ImnXR8hb0skxAO7+Ck0hefK0hjlKJfeT3GWiwnvuYD8QZKL5fNIBbVHDGJRkw0WmTEEz+CY2vt6JcdbYZ9xWkX1RV6BzvV4wwgfPAibQ9M+w5pMY49T3M8iYAkaWKXJ5KfP1PZ0UP+v4wsQqkV+ZBZfJ3pS5uTSgxoLquWF7+X6W/BALECZ4Q3VAShYoUHmuYJu6RzAPtspiesLRDDETuHSjUuvfpcVw+LCxuZm6C2yTBQjGEhPcvJfALhGpn6NRElcHoPx7UwHEzK69s2j6zE8m/yfOZ/V4aYqFBv6zN8W7noYwCCpKHac4k8vZD5L+M4zyuxkXT2c/jEEjrWIvWurbhItdz0FWP3B1GmhtFwu8t+CyFBEJnQM45DHoJOR6a//6yizYO4WTrQbRbmC8aCv4RFdG0fFibURpQfRXPYE4NFAoX6rUiV3Nw8gPt75IXmFNl91ID6uUUrbns2L0bDWZ8vKkJbcjTret6bVL+PqtARMEW42VgJfmT5jUBfiOsYdjmlo4uD02qrNhVa1GtqKsWx1PBomMfdRO6WlwgCkQLEwOKPht5HXsDUThViiOf8vGxdx5sSfliJkGKDq9Je84M4QFvtZEKQOatyRezrxqzYug6IQGp+ft33ocbSTo2fLZ2vnYRyQoD8dI2TpmgmJMekgxTmS9o69wY9RDnN2sv/EfMI18j8QHws2vPH6KdTHx0NGjeP2dF9gyi+oQAD2CeCQeO5ze+3ijzMo9CPtrkH1H9itI+xq61UdpmDab7BRpQdbrCJ2 2tLRfAv4 k8/XbU/Tl649ob1P/8QEzRVQy9l+Lx48SLQGqxFm0hTsDGKv49LGO3SmUnArsj7EERDSepyry1ODZ/IQlGUUlRNu1mTX8sVdaphzualMQHZUZnRpl0Pg+M5qL8kTvbuoXGb18XswV1iONt4uV3s40tZcwVtu3R/ujSDiq0UvSv8xT589pGyt3hGGhAL6Llg9AIzB8QxcfBHwFGrCX4QCioGRpnNfM2v2Bk1DOccGHOZ/7sfEbVvIaMPN+acccD6c3+GwgOgdpT9hVYyumhFdf6iKtvd/BsKHr2j35EcLaL2SgplqPRH918kB2QOC3sbpcrI6uCPkAZi6KUgY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 24, 2023 at 06:24:08AM +0000, ye xingchen wrote: > >$ ./scripts/bloat-o-meter vmlinux.old vmlinux > >add/remove: 1/0 grow/shrink: 1/2 up/down: 346/-350 (-4) > >Function old new delta > >vm_compaction - 320 +320 > >kcompactd_init 167 193 +26 > >proc_dointvec_minmax_warn_RT_change 104 10 -94 > >vm_table 2112 1856 -256 > >Total: Before=19287558, After=19287554, chg -0.00% > > > >So I don't think we need to pause this move or others where are have savings. > > > >Minghao, can you fix the commit log, and explain how you are also saving > >4 bytes as per the above bloat-o-meter results? > > $ ./scripts/bloat-o-meter vmlinux vmlinux.new > add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94) > Function old new delta > vm_compaction - 320 +320 > kcompactd_init 180 210 +30 > vm_table 2112 1856 -256 > Total: Before=21104198, After=21104292, chg +0.00% > > In my environment, kcompactd_init increases by 30 instead of 26. > And proc_dointvec_minmax_warn_RT_change No expansion. How about a defconfig + compaction enabled? Provide that information and let Vlastimal ACK/NACK the patch. Luis