From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E427C6FD1C for ; Fri, 24 Mar 2023 16:49:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9924D6B0072; Fri, 24 Mar 2023 12:49:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9418E6B0078; Fri, 24 Mar 2023 12:49:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 858DE6B007B; Fri, 24 Mar 2023 12:49:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 776096B0072 for ; Fri, 24 Mar 2023 12:49:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 46599A09CC for ; Fri, 24 Mar 2023 16:49:13 +0000 (UTC) X-FDA: 80604376986.16.FC2A9A8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 8E2391C000D for ; Fri, 24 Mar 2023 16:49:11 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bikEEwzo; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679676551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bbNydjqztp+lQA9XVdeApJMxV7rGOTm0b7PeZWBP09A=; b=idIJKcBcm6bFIO+oFtlceM+9Zes58qts5/ZwKxNaeQD67TZhR7+p3VJX2reOv3r0Vk3Ldn fcktDwKQYO2NY2WU3CgNf0l+ADaMXCujuGIyBadfTDwGlKhTA6xOebj7lKxgqaJjd4rRjc M8Py2pIYKONnGJOxuF2DPmvf/z2hoo0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bikEEwzo; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679676551; a=rsa-sha256; cv=none; b=2IJElek4pcxyAgTJIslBF+MDIndJLukmK8LiiIdxdwlko0U9I2/IIP1JeNM/FR1kh72CGo J6lIGITA1ndQNaBJZFV1hodqaRKgogl06mDUvKMns7VleNsIIB3uyJyh9f71jDeRCrJp2x zcPVzeIEluasueCOW6JFhQyxCHSFMWk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7F3F62AEF; Fri, 24 Mar 2023 16:49:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82FEDC433D2; Fri, 24 Mar 2023 16:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679676550; bh=Ko+doy6miNVccGF6PLZMT2NOgYDK5UYSp2j4A6+XB/o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bikEEwzoIKbiEp++ZVDS2od9Vj6fM5doaZjPYGBWhRItvFbwZWn4eSSvcUDhXwz2C +/MRKr1qCD+3SgCkFt27Y/szQX9521IROrEvmdyPxM1NH7q+6vTIIjPlZHXUFtL+nD eBQ6glP0tjCcYZoC5P0I/kB5YLLHHGZTP0VGQ1eUWkz053KBLBkGgqn36LUxpzpEPd ZqqPv69iDsAnebfmMUJjszrgWw2Uuxhbang2j2KzncjL8C6WVRbwu7zYScqlBAsHCU CmAlaxtZKKboh0FbxAqNeNw306p+ZHZYlHjKeSYEYeiUZrkTS8iGzHhnQuFUY/lTov 0bNoykhMwACXQ== Date: Fri, 24 Mar 2023 19:48:50 +0300 From: Mike Rapoport To: Zi Yan Cc: Andrew Morton , Arnd Bergmann , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , John Paul Adrian Glaubitz , "Kirill A. Shutemov" , Max Filippov , Michael Ellerman , Rich Felker , Russell King , Will Deacon , Yoshinori Sato , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v2 00/14] arch,mm: cleanup Kconfig entries for ARCH_FORCE_MAX_ORDER Message-ID: References: <20230324052233.2654090-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 8E2391C000D X-Stat-Signature: jpsrj5htxb7jkwhi54tge34bmbmf8py6 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679676551-114745 X-HE-Meta: U2FsdGVkX1+lfIMdqOEhraehpGaV97dVFnKEK5p8vrzQUIqFTFcNB40uKAGsNNH6VPSbrXIGIaj9O4RbyE2blCFhEtBzAhtnk0jZXsI7oJ9PDYNs2NTF8eXlDEEVmWPNEm60kWj8fDgOSQujLFmlipYr+oF0B20i4InV8jZyUwfBS/CTkDFVezsKtFyh8mcNoEwhvy3AzDasRq1ycIuc7xPvYYiQKqWnan2WiH9dGdIkbdHJdAi9DsAqefi+iryqC7+bPwTADO08NomTZojHbI5siHjKPTveMG7ZAXgA9Py1TOXNNCdCO2pcfw3zfCVpXsST9ZM0lj/AxMwCJDHhC2b2exaomYtrYAuqmut5GvN5sIb0Uac+nq+TB07pTZBB9K39b7RtaIAQVZqMgfzw1D1+BO1mxzZLR8yXuu+/aVxcXfUN7Pj6SqatHkO1S25OdvEBNQdV2lCoWiEaOTK6EgPzQoFLypOEt/5S7COCm/mutklfZ4oc9CzS5hmytan4tkAjDg3TZvHGxmJfQ88j8E4WuheE6cPr72Ge5zzB4c8XklA2qujCm9d2FFJJ+5fP15ryh04M7wahW5b7lis8RVXQm1Q4ucFeeQDq6KXilgNUb9OIvV38lei4bnFn9dD2ovprbIucePmJwkm7ZcrNXh2j8+eU1MszoNkFDCtK/YO4LoHe1QV7efPQ0ecFEgX8Otg3vZiGM4WAqo1R+AS93WG7fZljvUbb143ZMA8c+Mpbja+Neo6sSGq6xYRyyW3GlpIp0qXiXt+zoFoK39PVlH15wLSZDXsBy9fBkbN0NuSRkhUDm3goS/r9sXti8poVDXJesGyMU6TuBTh05ezwr2fbsH7AzJkx45Iti6ZjMoG6XYA5zVbSa0yPllKex+/qAXoNXBxDP0kiy5wMjmN5JloVVCi4wBysSUgPKT/uVyPLKJTpTWfeiCRPelisXLd9MvQcGAkoyIA2e0MDeLH 7DvEs8PV 7lmAJuSojb7suVmuleZbxYuuOtKQysaOZac0vkMiLMNiGEsLhBK0z9/5ncgYkZSnydh2GM+yBnrSkX9OuoM1qyZPXdtyDDHm0E+KYZ+RKj8tOfH8Di3EovO5E6lzRAeLJ4TaZDbuMvbZ3mkQcexUbw4Fw9YScxJccguX82KFMupcNNXYfTABsK8hcTX7i6iAJZsw4xlLuqPj4RzoWSzt1jdufO+AmsmGNJH3niRhS2H5ke6y4tu7DjqvMP7WYxw6tAonNsXxUsioYP1/oULGCS0YHiIqUknHd83wnpLO5+X4CRJTnrJX16hRM4DrKiX91fC06pWO3HbxLV0FMbsdlLCVcei/IjAbikzsdjG9NzhHuzkTMcBGql16ZBKuzcCqqv54C49wossuKwzPwgkEjqW/KNie2WsEsappyNL+mZYQKSyWXxsPKDP1T74uka7PSRB0dq4+TUOgt+D+XKuqWPEDFTaLWCApT2NxO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 24, 2023 at 10:30:07AM -0400, Zi Yan wrote: > On 24 Mar 2023, at 1:22, Mike Rapoport wrote: > > > From: "Mike Rapoport (IBM)" > > > > Hi, > > > > Several architectures have ARCH_FORCE_MAX_ORDER in their Kconfig and > > they all have wrong and misleading prompt and help text for this option. > > > > Besides, some define insane limits for possible values of > > ARCH_FORCE_MAX_ORDER, some carefully define ranges only for a subset of > > possible configurations, some make this option configurable by users for no > > good reason. > > > > This set updates the prompt and help text everywhere and does its best to > > update actual definitions of ranges where applicable. > > > > kbuild generated a bunch of false positives because it assigns -1 to > > ARCH_FORCE_MAX_ORDER, hopefully this will be fixed soon. > > > > v2: > > * arm64: show prompt for ARCH_FORCE_MAX_ORDER only if EXPERT (Catalin) > > * Add Acked- and Reviewed-by tags (thanks Geert, Kirill and Max) > > > > v1: https://lore.kernel.org/all/20230323092156.2545741-1-rppt@kernel.org > > > > Mike Rapoport (IBM) (14): > > arm: reword ARCH_FORCE_MAX_ORDER prompt and help text > > arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER > > arm64: reword ARCH_FORCE_MAX_ORDER prompt and help text > > csky: drop ARCH_FORCE_MAX_ORDER > > ia64: don't allow users to override ARCH_FORCE_MAX_ORDER > > m68k: reword ARCH_FORCE_MAX_ORDER prompt and help text > > nios2: reword ARCH_FORCE_MAX_ORDER prompt and help text > > nios2: drop ranges for definition of ARCH_FORCE_MAX_ORDER > > powerpc: reword ARCH_FORCE_MAX_ORDER prompt and help text > > powerpc: drop ranges for definition of ARCH_FORCE_MAX_ORDER > > sh: reword ARCH_FORCE_MAX_ORDER prompt and help text > > sh: drop ranges for definition of ARCH_FORCE_MAX_ORDER > > sparc: reword ARCH_FORCE_MAX_ORDER prompt and help text > > xtensa: reword ARCH_FORCE_MAX_ORDER prompt and help text > > > > arch/arm/Kconfig | 16 +++++++++------- > > arch/arm64/Kconfig | 27 ++++++++++++--------------- > > arch/csky/Kconfig | 4 ---- > > arch/ia64/Kconfig | 3 +-- > > arch/m68k/Kconfig.cpu | 16 +++++++++------- > > arch/nios2/Kconfig | 17 +++++++++-------- > > arch/powerpc/Kconfig | 22 +++++++++------------- > > arch/sh/mm/Kconfig | 19 +++++++++---------- > > arch/sparc/Kconfig | 16 +++++++++------- > > arch/xtensa/Kconfig | 16 +++++++++------- > > 10 files changed, 76 insertions(+), 80 deletions(-) > > > > > > base-commit: 51551d71edbc998fd8c8afa7312db3d270f5998e > > LGTM, thanks. Reviewed-by: Zi Yan Thanks! And thanks for spotting the mistakes in arm64 and sh patches. > -- > Best Regards, > Yan, Zi -- Sincerely yours, Mike.