From: Michal Hocko <mhocko@suse.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Joel Fernandes <joel@joelfernandes.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: WARN_ON in move_normal_pmd
Date: Fri, 24 Mar 2023 12:15:24 +0100 [thread overview]
Message-ID: <ZB2GTBD/LWTrkOiO@dhcp22.suse.cz> (raw)
Hi,
our QA is regularly hitting
[ 544.198822][T20518] WARNING: CPU: 1 PID: 20518 at ../mm/mremap.c:255 move_pgt_entry+0x4c6/0x510
triggered by thp01 LTP test. This has been brought up in the past and
resulted in f81fdd0c4ab7 ("mm: document warning in move_normal_pmd() and
make it warn only once"). While it is good that the underlying problem
is understood, it doesn't seem there is enough interest to fix it
properly. Which is fair but I am wondering whether the WARN_ON gives
us anything here.
Our QA process collects all unexpected side effects of tests and a WARN*
in the log is certainly one of those. This trigger bugs which are mostly
ignored as there is no upstream fix for them. This alone is nothing
really critical but there are workloads which do run with panic on warn
configured and this issue would put the system down which is unnecessary
IMHO. Would it be sufficient to replace the WARN_ON_ONCE by
pr_warn_once?
Thanks!
--
Michal Hocko
SUSE Labs
next reply other threads:[~2023-03-24 11:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 11:15 Michal Hocko [this message]
2023-03-24 13:05 ` Kirill A. Shutemov
2023-03-24 13:43 ` Joel Fernandes
2023-03-24 13:48 ` Joel Fernandes
2023-03-24 13:55 ` Kirill A. Shutemov
2023-03-24 14:38 ` Michal Hocko
2023-03-24 23:38 ` Linus Torvalds
2023-03-25 16:33 ` Joel Fernandes
2023-03-25 16:47 ` Joel Fernandes
2023-03-25 17:06 ` Linus Torvalds
2023-03-25 17:26 ` Linus Torvalds
2023-03-26 2:26 ` Joel Fernandes
2023-03-26 22:48 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB2GTBD/LWTrkOiO@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=joel@joelfernandes.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naresh.kamboju@linaro.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox