From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C23DC6FD1C for ; Fri, 24 Mar 2023 02:03:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A77E6B0075; Thu, 23 Mar 2023 22:03:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 858056B0078; Thu, 23 Mar 2023 22:03:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71FFA6B007B; Thu, 23 Mar 2023 22:03:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5F58E6B0075 for ; Thu, 23 Mar 2023 22:03:42 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 38A9BA0729 for ; Fri, 24 Mar 2023 02:03:42 +0000 (UTC) X-FDA: 80602145484.30.0F015F5 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf23.hostedemail.com (Postfix) with ESMTP id 5548A140011 for ; Fri, 24 Mar 2023 02:03:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HL6A8izR; spf=pass (imf23.hostedemail.com: domain of htejun@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679623420; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PY/nCrDiW8SdcBN3F88jY3M7fLY4heof/m4P0yCEwhw=; b=TtFY5V5CDa5zpduIOXXoRD3zC3k4Cufca5j4VREtgaVz6vwARbWBoppzNWcXJp1OQsPEFb aCpWqxbVQkKaBDQDD4Fka6I5qSGQxxE0LtVs+bqE9jiycQCZgwb10j63JI35Qv7FcxNyBi 2u3q0QkQK6sTd49grkIlBGycnITQfpQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HL6A8izR; spf=pass (imf23.hostedemail.com: domain of htejun@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679623420; a=rsa-sha256; cv=none; b=BBgg4pbBkEwKHvRsZ55UwzpsQFYnOzvfsKKAuu3T018A4rgrAg7hlLfoQtzVEiiuGIRZLn q6V7bORE/RYX09W199CXt0GyW1JmXt9sugwBLDB8RiCoQTWXEByhxv6m4hnOdAWFD1t1F8 zuIRWZ7F8o/Ycloz7mcQOPuxFApnm5I= Received: by mail-pj1-f54.google.com with SMTP id h12-20020a17090aea8c00b0023d1311fab3so251961pjz.1 for ; Thu, 23 Mar 2023 19:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679623419; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=PY/nCrDiW8SdcBN3F88jY3M7fLY4heof/m4P0yCEwhw=; b=HL6A8izR0CkeHjxLTeXacguhkCInW7j8vtFgwkEVI+52gmedURua9uXjCQYd1au7M4 J3wKLc5Aaxr4n8OrTW1aboOPukXGln1bEfbkxmfXkRn6g27aVMLkRw5UTMCDUUiMzrLu gA2qhSRF0DeHSKKS0Lfj2/OFgFLPQj+/W3uFZOJ8HKZ7Ef709sX3NmbybV0tVgYjcqo9 LNtgR9a6IG8ul2Ht2ssRrjooLeqB4noIZg0Q/C4ZOaho+LB9gK7sfrhgZK+tSwqccjaS rxmjuwkEYAujP00mwv527Ch8lZwee8c/QiAm7yaggQs3brArDtQ01NmWgzttubBCX+Rj nd7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679623419; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PY/nCrDiW8SdcBN3F88jY3M7fLY4heof/m4P0yCEwhw=; b=uHMPidm7ng2FwQQ2dniublPt3boWi4bqXe/+LYHgJpW/TeBAM7dY1rrRkqNNIUeVzM g+GR7QGiwKMyOjhZwUPkHlxpQP3ImbdTRbmSMibz2M7WkjKtrxLsWvVLTLatJAgegj6f p+gjR5krdIyE1ojuW7QjB8K3MQmjpUiIJjcPtlJ7BlJAZdIBfM9ddP36lgy5pdyrm9Nz aQTAUeNpvR9lQTQuuqdxUp+pjS7MnuNcVQiDEJhPKkduA5XaFsulC8LOhrFOVxN8zRPt y5iOLxk8uypq1aHAliWoRkq3/hMk0+XVWoePggIN1jfSeIfJdpbHQ0sbECy9hKCVfapI XeDw== X-Gm-Message-State: AAQBX9c8swDwdBaMrp4859oaZJcvwCSeHK2oCGFcoWXH9F2yEY45MVpA zfpqob/WEKjat2tpay68tZU= X-Google-Smtp-Source: AKy350ZD0neSEhm9l4wbQl8oOrRyXw/6xPTWV3RJomuHrjMjhShTzuTfX1vJE/M1K2wU8G/JnpV8sw== X-Received: by 2002:a17:902:ec86:b0:1a0:7425:4b73 with SMTP id x6-20020a170902ec8600b001a074254b73mr1258132plg.4.1679623418972; Thu, 23 Mar 2023 19:03:38 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id p6-20020a1709028a8600b00194c2f78581sm12941481plo.199.2023.03.23.19.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 19:03:38 -0700 (PDT) Date: Thu, 23 Mar 2023 16:03:36 -1000 From: Tejun Heo To: Waiman Long Cc: Haifeng Xu , lizefan.x@bytedance.com, hannes@cmpxchg.org, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpuset: Clean up cpuset_node_allowed Message-ID: References: <9953284e-05da-56b0-047d-ecf18aa53892@redhat.com> <20230228083537.102665-1-haifeng.xu@shopee.com> <299c9c34-0c07-ae52-61d7-6332f35c6245@redhat.com> <2e71c2bf-9ee3-4ada-e9d9-acb6e422e9af@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e71c2bf-9ee3-4ada-e9d9-acb6e422e9af@redhat.com> X-Rspamd-Queue-Id: 5548A140011 X-Stat-Signature: jt7gxudg93oogtwn99n1bc68w4exwh4h X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679623420-994821 X-HE-Meta: U2FsdGVkX1+018YQ5g6wZ7r/yedCTp9rut28QkkpuCIPIqp1biv/ENhx6QIl1/Hzy22f6gDZMAvlE/gBGxr04t8CAOPgxHFBbA21SOlLSoZngt4LQ9aaNu0zToW+SJ3wzZHbkqNsxJ5lKKXX/ZjmJUj5RgP4GKjZ1RRiIGtht+xoBJlBWGkuOSS/zr3h9qbT5/aYAAOuGmgzbGg+UywRFR3gdc85BGOdzZJVsV3clRqkM7BvwGa1ufocjE2D9kp5EZWAl4d48sstSvM4QVJqOCBdojNfal/Iw0e28yoHyl7AZWE4obDoNtCuoIceVtVQ7D6zlNywn6o33U0ZldLqOP9M40S3CpSC789wbFFULrDTj+sjL4qkUo2OpIBD2/kX62tRmmS03/28AgSHW9nJINIAIEqYGUWgx4g4YVvbwIrqPbyQtJci54o5lTP9iQaYqQM8dt6geGeWt96kabbbupwYpVHb5dIFOtMlP4X2s1Ts5fMSsD9onGkyVUeThYsfmBVud/Wxv5oF9m4CBJvYjS4gwhcEvf9PRjzazLeWIG94wsnGX4kybXunuAOwXHswt72UwgwXhJePKN9GGEr+lkprl/Rpk3qebvBOYYTgtrQAw21R/fH78sZNR0Ked2JiJTnhuGbO7Yy3bqA68evixBEAmVMmthZaeJopBgisSHQCVZsAwX0kqSq3qoJvhAv7yITVwhi0MmFI/3P7o9FcQfBxTbYjTVQ1HxrrSLNFuF6vi4vmMRtHUDd8Is96nt0q0TakCBHpY7qspT4rGCs0HVvelNtFi07sZZz749y2Pb0/EPwQxSMznzhIDSlkSKU9sIROYmOR5pdXaxR5wwHocuL5WX5yxmQvpi2mnYMgDmBEck7Jn74UfB9frkAn5wMJRm2Cf/y0px2YZSSfaOKxdlM1T50Mx4qrpc3KR8zXlpauyV4EwE15GSzAHb/lip1uLZ67mthoZYc7aedjG5U hI/VyeSK 7KeTxnYH33UP2upjh47jkGdUWiTGwvkFHb1QlUXRAulxhDeyJFlfan2ATJUkwELdEfQlDfs2CV28ITETK9y1e1PStGm1Sbqgnwq/aQNy2DVjLAkRwO1IkKMfm/vHcQbnUIaJc2ykTyuAlpvvi+oB637lXShBLNVwb4EXm78CT9HmqhY7cKSuHciGog1RmyTbdtCtSgdv3fIO/B1hAZ5aBTR7aVaugY0B5Qn3o3fZUWISsP8V2WHvE/2lUuYOTjaTa1yPq0rudN/PiB41XomJbLijBEwBGcM4FRah7/4FzsjrvjLJkFVS7FSFlvxlkraKXXAGL8ei/2HUkX5ZhUs0etU15VEkMZOLBaY/YKbPDX9vt5hDciEAzbhJBArtfDgpTpQkjpACHu6zrletrci85hVXYqV8APNlNHlkyVwwQBwlt1osBtmIkLdKlbXziuClDq15wRxfxIQ/BjosUZPb4kIMnq9QU7rtBr4eSMU53uq7zjEyRZxVAdmc2oqEsabbbwuJtua6+XbLuiW6ofORLbyrzdkHLeqguSYXh7n5nUXyymRxjKKK2zBpikiXHSqIQ17gxGik/BsD4l1B4BfvKTs0mWNc8U/9egiho1FgXfKVz1k6yuMXPUwBC3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 18, 2023 at 05:30:46PM -0400, Waiman Long wrote: > On 3/17/23 21:35, Waiman Long wrote: > > On 2/28/23 03:35, Haifeng Xu wrote: > > > Commit 002f290627c2 ("cpuset: use static key better and convert to > > > new API") > > > has used __cpuset_node_allowed() instead of cpuset_node_allowed() to > > > check > > > whether we can allocate on a memory node. Now this function isn't > > > used by > > > anyone, so we can do the follow things to clean up it. > > > > > > 1. remove unused codes > > > 2. rename __cpuset_node_allowed() to cpuset_node_allowed() > > > 3. update comments in mm/page_alloc.c > > > > > > Suggested-by: Waiman Long > > > Signed-off-by: Haifeng Xu ... > It turns out that cpuset_node_allowed() isn't used anywhere except in > cpuset.h. So it should be OK to remove the alternate cpuset_node_allowed() > function. > > Acked-by: Waiman Long Applied to cgroup/for-6.4. Thanks. -- tejun