Re: [PATCH] cpuset: Clean up cpuset_node_allowed

[Tejun Heo <tj@kernel.org>]

On Sat, Mar 18, 2023 at 05:30:46PM -0400, Waiman Long wrote:
> On 3/17/23 21:35, Waiman Long wrote:
> > On 2/28/23 03:35, Haifeng Xu wrote:
> > > Commit 002f290627c2 ("cpuset: use static key better and convert to
> > > new API")
> > > has used __cpuset_node_allowed() instead of cpuset_node_allowed() to
> > > check
> > > whether we can allocate on a memory node. Now this function isn't
> > > used by
> > > anyone, so we can do the follow things to clean up it.
> > > 
> > > 1. remove unused codes
> > > 2. rename __cpuset_node_allowed() to cpuset_node_allowed()
> > > 3. update comments in mm/page_alloc.c
> > > 
> > > Suggested-by: Waiman Long <longman@redhat.com>
> > > Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
...
> It turns out that cpuset_node_allowed() isn't used anywhere except in
> cpuset.h. So it should be OK to remove the alternate cpuset_node_allowed()
> function.
> 
> Acked-by: Waiman Long <longman@redhat.com>

Applied to cgroup/for-6.4.

Thanks.

-- 
tejun