From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0012C6FA99 for ; Fri, 10 Mar 2023 21:10:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12FF26B0074; Fri, 10 Mar 2023 16:10:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E06E6B0075; Fri, 10 Mar 2023 16:10:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEA388E0001; Fri, 10 Mar 2023 16:10:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DFE6D6B0074 for ; Fri, 10 Mar 2023 16:10:36 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A4BADAB109 for ; Fri, 10 Mar 2023 21:10:36 +0000 (UTC) X-FDA: 80554232472.06.46FF4C5 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf24.hostedemail.com (Postfix) with ESMTP id A00A7180017 for ; Fri, 10 Mar 2023 21:10:34 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iWDEIbP5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf24.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678482634; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LIWDLeYtEAYfgg25NNegNAWenGQW3HXHu20am2x2WUM=; b=uIZqhlLrYWasD8iFRX8/Bwd0LhPJy3p1xZHISePR31B3Niuv92ufDkRfdwUkDra7m6rMKa mjXaGz8BVoKITpLgd3x+ImxQFVusqEKELUR+LlJ60xxNEXzTlEYjdKqyvYJoE8U9kcIrnh 6megSdqt7Owi7bMHLRgclNEu8p1cV3k= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iWDEIbP5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf24.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678482634; a=rsa-sha256; cv=none; b=tCAFuziudi0FXIB0Ih7JkOmRx4yywKBdIeAURM9bSLxbxk6jbmyPpNr+XZcsHC5q4Xpy/R g3xrZWZRLjOLsaakDtuZ3O9BhkCTkRc1S4doGuz4xd22TsAYX6BH9Zm+aD2HGZVhuwVGGZ nEBHJrxD/B8WAR3BgsN29NthyXxq1gU= Received: by mail-pf1-f179.google.com with SMTP id cp12so4463012pfb.5 for ; Fri, 10 Mar 2023 13:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678482633; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=LIWDLeYtEAYfgg25NNegNAWenGQW3HXHu20am2x2WUM=; b=iWDEIbP5ufsIyajRgL8qmFeiq2H4xyll9lbRwch4uhitclQkYQQ3vrfVTJ8fJxBrrl 29v16Dp+WFXE0eWu7ZRga8J7YRJOYWWVZiUS8Og70PvE7SPn9DPxbUomA/yIAT/Jz4TI zrtAoI9QwrlHOWS/C64CnqgakzXcvN7mQsoYqeB27PtHi0Ieo7q89gsAMqP4BCbPXkn5 h7k5y/bwS/8fSnyAq7/8hIamegU3mPHW/mzeZYudaeOUdW5p0gN3oDVzHh9kdHP+gfEI 62U/sz256QDVqjY2Tb0AreTtyIKXn7z6gB/XSo3z9a81noJvm2TLx2vohr3JputA9gkU +ujg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678482633; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LIWDLeYtEAYfgg25NNegNAWenGQW3HXHu20am2x2WUM=; b=tq5S9nGHSSg6iKGfvB2TV54Pjg9jmBuv/ynXCOfslkJYs0+xUeQKsDPDGIv7M5JsHH bayJiNUd71FQ7BWwMpyKnbBILChARtaNmv4XdtsQ+LXFsSFPKWFUQ5cxhd8471L3V/3D tfcqGQe8L7+nHrq7DK3GtcYSz3OxzcMFijTa+XN758BNr6bCNSoCrnUdbobXTMfcGic4 KgUDf76feuX2ZVoqeVesE3LJdvZT+czVc1D6WoHHfS0LCKbJ45FiF0d0vf1ye4WSvmC7 eZcoQbsJGNk6poBFjvike/k+/92/bONB42lS+nxs4eUum6HffnHrzhBtyysbg0UpT9hZ J6aw== X-Gm-Message-State: AO0yUKVlQJxlMyi6SjckXcXnzrEz5BVHPenZOQnTW4AXBASoMaARuP+M n/b6uohSeVTsqey0L0mApLWPkp8IWD8= X-Google-Smtp-Source: AK7set83+7nDeFJkYLrcYT7ntb5qXkZerr/N2Pp8BHSDheqQAM96rS6PAKSvg3KIKt19OAfG2RV3BA== X-Received: by 2002:a62:7982:0:b0:5a9:d676:ae58 with SMTP id u124-20020a627982000000b005a9d676ae58mr28353952pfc.13.1678482633403; Fri, 10 Mar 2023 13:10:33 -0800 (PST) Received: from google.com ([2620:15c:211:201:cc57:d271:da5c:ca8]) by smtp.gmail.com with ESMTPSA id w18-20020aa78592000000b0058e1b55391esm227823pfn.178.2023.03.10.13.10.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 13:10:32 -0800 (PST) Date: Fri, 10 Mar 2023 13:10:30 -0800 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 0/4] zsmalloc: fine-grained fullness and new compaction algorithm Message-ID: References: <20230304034835.2082479-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230304034835.2082479-1-senozhatsky@chromium.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A00A7180017 X-Stat-Signature: bygmftjyhzytj7abo1zzrfxz4eropbud X-HE-Tag: 1678482634-176475 X-HE-Meta: U2FsdGVkX195Hs4jxRbJQiQdznFBqGGdSl1enztc+l3/HXbveN0xz0RGK7ghYMpAEVknhCXmsln/5nH74tAufks/QyrRinmF9J/i9xGYuqd58rerhbI/8VJYhATL1tpXWOR8qdB8uu8n70TCYg85SEp2sK0tqgV+1YCBFAw40qyYvGyGCqPrkjS97fHZRFu3S3ksf4AvTr/u5RG3mN7R7q8K1BY9/Vz4J0TuU4YUb2kbwsNJfCscJIyTh2It7tHiZzs7t1sKvcZn7NxMpPFZi/n59zFF7uPfEGpvGH/6ycTYCIkytcC6IEno6s55ixNATkjr0lvQ5tio2QDnUspjiGkN9XEEA5t4v3SZ3wTzrlGtHa9GTfsdgm39BJQ8kcsg0XxOh78jLVLP8Zuxrh0TpRfTYMgKf9mr1/8R2avX2A2v7HhdCk1+sQ7sACidvjz5bypLWIMeSBeL/Zv5RCPfooUHs4QtSiih0+qvK8HtlXRR+N2ll5IZmwbr/sUApxRkoGbwBScnN5K28sdMnCwpto10Ej3WEuAJlpIZVoGJLWNdJe4jX56R4fOlSuwzNPcZNS0/NtMEjN7Fjw5VsEnBpFZE76ON7TBCPipdIok2vP6GXNGWUiKk2gr9elFoo9RZL5ajCh/3UM1XUU+K8G+ETHLfOJz1XtIPD4X1j2vinjjaAGx7HD6ljJRdJPdJE3RggUZrr6D8SiNvxyi5ksRtimf6dkTUrbMGfhj2kU6ecPrXs2uIVaq9cz7d/QBRJ2110xWVGuj6BofPFr6uWDnjJXwDRqEK+uIPOF5UoOBamy72eS6HljO1K2qDD6BQmJyXihhmXciOvdHCjGwyryAb1/zuCdRNwJq9IZTMV1ukvkqej1ZLlU+Y56QEK/HydiJ5h9MaYNgyj+JhKS/XxC43Fq0a2FGw+ZhF09Kz5QASqBdM11tbOCZM3Lr4kFwFdv8tWtAznajMkKBj//ehnOd 1aWNjV4b hLogXqWxeZdx/N0SqswLRbUGHzX1kQN0lMePawGeijAeHoq+YdWGf3+C7gQ2vsiL/n8mEqmRZBj52p5EzCOADwadSr57A0P0JDwow9WbTjINMcnmKtg9NJS0KJGfD8afm+IJYsfk2GxRuDZ9wYDSK6aKFj6tQ0rNy/fzZ+g86JoZ3nPMYCs8HWhILc8jdlcaSrDJUOGe6nofx2b7ysrfkv60OOLP+OpNTLFj5g2mZJX5nug/zdrNFDIhM/EUzhO3txBWTdkhaH71WA48Q8AGQaXTf2HXeFfLIbFkPhtF7bj3+wwW3jvoG3PZDDUwFD7kk+7QF2LLIaSI7/v4csBKj9TOocdCAuLt0+a/zkAAKU/UjUuzmp7MBxQdrt6QK8SG2FqCoqZUp9XSCipHP4RsZfS3+HYW734fhAlIDnYGNaIdt9qrfhpYTNdJIJGq1DPFRNuQ4f7jh0bFbs+lcy3PCcNEviYL3A5PLURGyCGR3NxdYBYlEWrwj1wgYYS9dwo9R7j+ab2plGc7fjPUFeHQLM3GgBSlc9jll2M7g65jGp/7p24bUleQoXPxPCdmOn4kcJwWED3w7Ix0VuAIzWikAn9sci3Z7ponWv8+S6y7HQavT81hIown3P0nEiaJe61UbqhaZ7a77h0991ytlsVJwovIwYjlTFAuvOUKqzOdpKXIelKKvf0AT2iJAHBG5KJy8fbGffH/BokWPGcE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 04, 2023 at 12:48:31PM +0900, Sergey Senozhatsky wrote: > Hi, > > Existing zsmalloc page fullness grouping leads to suboptimal page > selection for both zs_malloc() and zs_compact(). This patchset > reworks zsmalloc fullness grouping/classification. > > Additinally it also implements new compaction algorithm that is > expected to use less CPU-cycles (as it potentially does fewer > memcpy-s in zs_object_copy()). > > Test (synthetic) results can be seen in patch 0003. > > v4: > -- fixed classes stats loop bug (Yosry) > -- fixed spelling errors (Andrew) > -- dropped some unnecessary hunks from the patches > > v3: > -- reworked compaction algorithm implementation (Minchan) > -- keep existing stats and fullness enums (Minchan, Yosry) > -- dropped the patch with new zsmalloc compaction stats (Minchan) > -- report per inuse ratio group classes stats > > Sergey Senozhatsky (4): > zsmalloc: remove insert_zspage() ->inuse optimization > zsmalloc: fine-grained inuse ratio based fullness grouping > zsmalloc: rework compaction algorithm > zsmalloc: show per fullness group class stats > > mm/zsmalloc.c | 358 ++++++++++++++++++++++++-------------------------- > 1 file changed, 173 insertions(+), 185 deletions(-) > > -- Acked-by: Minchan Kim Thanks, Sergey!