From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC46C6FA99 for ; Fri, 10 Mar 2023 19:53:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1AD76B0071; Fri, 10 Mar 2023 14:53:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BCA896B0072; Fri, 10 Mar 2023 14:53:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB91B8E0001; Fri, 10 Mar 2023 14:53:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9C3216B0071 for ; Fri, 10 Mar 2023 14:53:57 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 616081A06C7 for ; Fri, 10 Mar 2023 19:53:57 +0000 (UTC) X-FDA: 80554039314.17.3FEFD4F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id 20EF8A0015 for ; Fri, 10 Mar 2023 19:53:53 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0ntTevDI; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf25.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678478034; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ss+hdlsE3tPgccu1HnUCYdR+3LmCLybQ7871SrfrPpU=; b=Vyeq+NkMLlZUcrRLQtvkMN35bTxiiiJ5tJIXzH2Uxbze7CdBlpItnxUwIxXjquSuRUri4f Q4M3bQNQyGJoeuRvsaSvwBbQy9Y70S37Eac3RBwWkq+q0mvIB9KrBjmTL30i18E3tLTyGI TSOnXdjBRIgafVu+aZPrDme/SFpRlGU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0ntTevDI; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf25.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678478034; a=rsa-sha256; cv=none; b=I3PmWo1g9iqhujiN02OyJy9s9Qn7oBzDNC6OKfZiOKlx6MsQhcmrDgE09cMnkJdOvtc7KI 6N0/eiSZpCHA2kYD6nrsQH2SiEQScPOjQzsLiZs5oLUVWCufJBXVmWT2kPVd0L7Yj02vqL qt1zoXYCIT0k4FIe500ZVdSdDHT8few= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=Ss+hdlsE3tPgccu1HnUCYdR+3LmCLybQ7871SrfrPpU=; b=0ntTevDI5MKI7rCGq03+F0Xh2f rwpX68L12144Jx2FT77vR0dUqtR3ZG4e7aYqEjJLB45iYWxjQO++W/ChDmofmzTe9ghqkVH6Fxx8T RcLeMaphm4W71tV+eq7czrT1SiWJ32fqc5QTXVBXgc1yFf2X0hgsjTe0vyI4mID+owLue9ZGvrGAu 0MFLLuWtqMDeqZwORN6wnu2mtQQW+XwKB2j9bgQ/raiRq8p64RvLocZ2mw/p3np71VhecrQvslNGp g0fuIUoNsXlUN/ParteV9vUJWhFHSDrZfv0i+gPZzMo9HuVPSe8bQuQA/owJMwNLuEGjt89ujEwgx 1LBFYAVQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1paioC-00FwaX-QL; Fri, 10 Mar 2023 19:53:44 +0000 Date: Fri, 10 Mar 2023 11:53:44 -0800 From: Luis Chamberlain To: Kefeng Wang Cc: Mike Kravetz , Muchun Song , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Kees Cook , Iurii Zaikin Subject: Re: [PATCH] mm: hugetlb: move hugeltb sysctls to its own file Message-ID: References: <20230309122011.61969-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 20EF8A0015 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: hrxp43u9wnf9tcn5xi7aek5eg7mpg5if X-HE-Tag: 1678478033-459810 X-HE-Meta: U2FsdGVkX1+ZNEpK/kHWrOemWGrB2n6O7j8lHlSLlCBwyE19Ywp1CVTyCT7NPqx5OmiEy3R1sMrfz8TjV7i2PKp8U8misF4rsCTMiSMgS2j/wCjKKu8HJXzjBCoLXaYHsLIkvGoGq+line7hHZesD04naO+bhP0qKemyq7dXPb5DfKV0ba7g+Xp84Z4wq7y+Ar3Z9yueCGg8yXQ005mjURyP1P5xBzsvKpjmrBKnVlJhHZQvPGWpBCWThCj2pu8KZ7CxbKWnbPciSU2krRalGl+X1pVFgBHGaxUOwdyvFiPjyQPwO/zp53fV2TlGbuQ4cgRYqcmgWkqAMQ0qxYLVonbWjwlDeJngaIejKeiT19/0WKuOEUum+O8d91JrlAHkULVP122NDXU9w0uLgg+wmykf5wP/XxekUVT9kKWpqE+P9gPrHbMFq8nfVZEQABEVXmmPab7KsEmtfzLBecjk+9X+x96sEM/tvoJPpOnx1xCjlpyGz/cgjnVj3fT6nzmRae+NsQqqWsk2G2WL8849Zo/LIaRcL0OIEC31Josj08nHzImHJV73WzpuqB/7dOY/LXrKaRX9fZuf/TZjuoI5gqoTbLMG0BswQ+0REE6p1iTFAZxBxmMAchOJOo9YdxuG8mWbKzhd2PIkPh9wTzXAu28Tj7+kqq9SXlKobgxhrmTUUy5vMMKw8fKP0EA44u6TWlidtFuPAgZcfZ4AEuQefzL/YCpkBb4cFi/MwRQHOtWMCJAC9Qt1+ZOdL63RNhp9VVbNzRAWrTs2P+u2qjVWxz4aqWMn6SR880CCPTIclDNh0aMjwgp8gCRzCxyltFy7qrv4LSPYMiQhfxG5Z8wi2IJcKH82LpW+huUWbPPBny8lW6WGOsCp3AThkJIPH2/ylmVQtpp3BbyKn7sGG3x6pg1mEAG2ov0j4kpZyrPYYGkhUWy/Hm/UrCRRKsB/bXiFY30R5lhKOs3BvRSb1WC 0Tffy82L 4Tvzi8F0qUtC0qqfO8FJzMSgR9kQl0R1X02Wigag2Nh5DGKmCr1DLQy+rhZAKaCmXpUyuRFltXhQDgi8dzRfKLMzIem1QdcqfDeuEheDoJR4FwFgU3a72KIO2j+ckJPgUnVITQbXBGdfO1ZWju0f1kniOIc1Z3T+4y88cEn67EXEmJwrGGoSQY5lgMwq1nF+TayH/zK18EXkEUMR12RqDOgogSBCaFc3jxRIUtScpLO0qV43LvT0NYVH+cFoQGiLl3XsO/3CHsIclW01hTDzDEREqYLsN/hpXAKTm7YES24T+8thdYjSB7Le9yStMZr0ruacxHZ035Vesp1UbRN/neVXADPgtH4h5aqln X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 10, 2023 at 10:23:34PM +0800, Kefeng Wang wrote: > > > On 2023/3/9 20:20, Kefeng Wang wrote: > > This moves all hugetlb sysctls to its own file, also kill an > > useless hugetlb_treat_movable_handler() defination. > > > > Signed-off-by: Kefeng Wang > > --- > > include/linux/hugetlb.h | 8 ------- > > kernel/sysctl.c | 32 -------------------------- > > mm/hugetlb.c | 51 ++++++++++++++++++++++++++++++++++++++--- > > 3 files changed, 48 insertions(+), 43 deletions(-) > > > > > +#ifdef CONFIG_SYSCTL > > +static void hugetlb_sysctl_init(void); > > Hi Luis，this should add __init as it is called by hugetlb_init, > could you help to change it, or I could send a new patch. > > > > +#else > > +static inline void hugetlb_sysctl_init(void) { } > > +#endif > > + > > static int __init hugetlb_init(void) > > { > > int i; > > @@ -4257,6 +4263,7 @@ static int __init hugetlb_init(void) > > hugetlb_sysfs_init(); > > hugetlb_cgroup_file_init(); > > + hugetlb_sysctl_init(); > ... > > + > > +static void hugetlb_sysctl_init(void) > > ditto, sorry for the mistake. Just send a fix. Luis