From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED39EC64EC4 for ; Fri, 10 Mar 2023 01:45:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70D226B0072; Thu, 9 Mar 2023 20:45:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 696486B0074; Thu, 9 Mar 2023 20:45:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50F9F280001; Thu, 9 Mar 2023 20:45:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3E83D6B0072 for ; Thu, 9 Mar 2023 20:45:42 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 88C7BABA47 for ; Fri, 10 Mar 2023 01:45:41 +0000 (UTC) X-FDA: 80551296882.16.2E22D4F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id D447E2000E for ; Fri, 10 Mar 2023 01:45:38 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DBBmhBwu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678412739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RtJkfRI7AXY3SogCgOFRi4FhIfSeTbcT8pIq6VJrULQ=; b=TmOf75/o10OIorMRWTrLED83vhJMNUTChHWwfKRO2E+S1FAY6OCT7/mGlVJ4ITxoMjFs54 nGkZJadI4dLFr5qd6U6BI1Tyeea7/Cg3k9zDfU1gTNWIHlVQWO4Z3tVp/j19yfPlsduTKA IFSdr+3EM+KAI3LjfY8aS0i3VkynhP0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DBBmhBwu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678412739; a=rsa-sha256; cv=none; b=a/yX1gGuZhAmmSh79KWR/UzA66VQcJJ7qToSIFbJGRdQ7/PKvfeNWOZIxX6zP/I300/Mfd JpuSaJgVmjhOskvRegtAKebwP7O8XmxKQcjXtuJGrMnRnWeeMvE5jScL/a2hX1bZQ7mBvg Lyag2MTfBSPuaKsZARo22Oxl5SLGlr8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678412738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RtJkfRI7AXY3SogCgOFRi4FhIfSeTbcT8pIq6VJrULQ=; b=DBBmhBwuS7fJK/2pupMG54iFLZptFkIzOG/988JkY1hAsJCrfA81R1lPDI3T2pxgkpfy07 wJZFT08T9pgmmqHoYaE1B6zMV/MuAx+i3Nzl0qA2otK5CmNLb4H9fnlvUBRVVH9jjQMofx JXElAl/grywyrBnwymfXX/OWZxYuUto= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-woUwnrrKNFetIWSKVrCPTA-1; Thu, 09 Mar 2023 20:45:34 -0500 X-MC-Unique: woUwnrrKNFetIWSKVrCPTA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B7D531C0518D; Fri, 10 Mar 2023 01:45:33 +0000 (UTC) Received: from localhost (ovpn-12-184.pek2.redhat.com [10.72.12.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BDB654010E36; Fri, 10 Mar 2023 01:45:32 +0000 (UTC) Date: Fri, 10 Mar 2023 09:45:28 +0800 From: Baoquan He To: Thomas Bogendoerfer Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, mpe@ellerman.id.au, geert@linux-m68k.org, mcgrof@kernel.org, hch@infradead.org, linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v4 3/4] arch/*/io.h: remove ioremap_uc in some architectures Message-ID: References: <20230308130710.368085-1-bhe@redhat.com> <20230308130710.368085-4-bhe@redhat.com> <20230309143621.GA12350@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230309143621.GA12350@alpha.franken.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D447E2000E X-Stat-Signature: 11wdqbnypw1nf89wxz576raa8335qsuu X-HE-Tag: 1678412738-770437 X-HE-Meta: U2FsdGVkX18AvhMN5xlAj3cTtQEXkMITTk8t0j3hta/CYl+4okLVmYE6QvnYiGoi0ZM7ifKVBA1Td2J0yAWNOGoDLzJEJNxC36incBJflB4cuwFQd9CUxJnFTXm2VLAYnQyyxSUf2Ekca9LeXgASkLnzrEWoc+daIAh/cr2fbvm9hGndcVGed9PufAdSB4YZXwLIP6MS0+5NEnDw3GlzEezmo9TofZu8kjclDELioIYzMAg+UkZd5Kl4e0hsNS/98owMjlOFVfAAhDEtOdB9V6SFEk8sW6EUQeM5OFY28gM5NFI8UE4/CPNUG75rSTG5Osy+JYC5d7Lz4o/hUUOcENdSvM4oEcdaGk16kD9Xz1r/xVczzaQ2yizIXB9F0YJ/aOFZEMlEwg9MR/iZ1EVRxqZL+GDjq9vOxusnTyrXqb5LosaKJSpKjIzaazwQWQWLU8ee69WwIZYhUtjpCdV7w0iFeAr31IVgV6IlUwWzzlNAiFuQsOoONYXjgc2WCtH59H46DyD0o3AStvI6CUQLFVQhKVEIRQDDepYOfEEEk2pclh0UFCHNaEog4N4jGSjEzsumcMsfw6NQHeaEfNB8fHBjKlj6rB91E1EF67lg6tzBrnbJRZDmQNGUPvhjBkONmZJS724p7IVbXZ0K5GnXi5haSpae7e5Oo2BYabTCDzrAscK+fPipO7eSVfqyohn/sTCqKxQ+yPmx6Utch/umdgX8zAWXkkTofAsH5ZoVceAejZkGIkzebt0uc0Anv54wqZArbExZIi0tgoc3D3QtH0LNyOlh11KsurIPoOlTS8EvrLb4pnyUbektuQGm+QO58x0R8CFzAxp3wUKaKeZ/CW8HkIp8Uz2dv8EOrKDJX35o9jdlMBEPmkIrfe74xRkEulTEZEzHS/tpoUpZvV5S/4yrCsWGjPzPKpjZ3AOPqkld2etGV0kpsREkp1quZpcR7IqK5aNo1FqeQaGN6ys Vd9KPmZ7 d/NYiw7z37rOPSqvfPMH8BXgz4xVHMcfCJWuzxZFA2TbvLYKCSnbuPS9gK6vDHdvtczsDNRWJ3S6bAaqlQX0gQmBZx7NqK2ISsRFnNJonC6Po+2h/6di8EAY4iYrLmFY4o1xuf/KHRAZ/UaQrrN6h3P/Ek8ejQxawF47AFraPMvIq0HJQYiSEEji5Jtl4PHt9TbyLTP1GhXO3QVGc+Tv7fpZvGS5x8h0bVpd1K7+EfokaVojvp+EqBdzmCejNGB6ZseRmuUF0hKSw8CgmGiD7g7RloOKJYDZkqiRay4PriXbidT4FkX0a77vbol+f2cyx0cYJwf4h9+g59cuPp39R8pIKiPJUWHIVnvd99ws4WETAMSIZjAVcPULfRfUFrXlHFEk7Mo0dYG+KsJovFO7YEWpV9NLGj+aizzVONMHH3TnHT1d9V4DIAk9w4X/7KX2UtmfSddmICI5b5tGKWFlOws2NcBSVu3CgiysrAnPCxk8eGce98jf0SgMTMP6leSsSLIZIKQ5dUJgOJPg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/09/23 at 03:36pm, Thomas Bogendoerfer wrote: > On Wed, Mar 08, 2023 at 09:07:09PM +0800, Baoquan He wrote: > > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > > extension, and on ia64 with its slightly unconventional ioremap() > > behavior. So remove the ioremap_uc() definition in architecutures > > other than x86 and ia64. These architectures all have asm-generic/io.h > > included and will have the default ioremap_uc() definition which > > returns NULL. > > > > This changes the existing behaviour, while no need to worry about > > any breakage because in the only callsite of ioremap_uc(), code > > has been adjusted to eliminate the impact. Please see > > atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c. > > > > If any new invocation of ioremap_uc() need be added, please consider > > using ioremap() intead or adding a ARCH specific version if necessary. > > > > Acked-by: Geert Uytterhoeven > > Signed-off-by: Baoquan He > > Cc: linux-alpha@vger.kernel.org > > Cc: linux-hexagon@vger.kernel.org > > Cc: linux-m68k@lists.linux-m68k.org > > Cc: linux-mips@vger.kernel.org > > Cc: linux-parisc@vger.kernel.org > > Cc: linuxppc-dev@lists.ozlabs.org > > Cc: linux-sh@vger.kernel.org > > Cc: sparclinux@vger.kernel.org > > --- > > Documentation/driver-api/device-io.rst | 9 +++++---- > > arch/alpha/include/asm/io.h | 1 - > > arch/hexagon/include/asm/io.h | 3 --- > > arch/m68k/include/asm/kmap.h | 1 - > > arch/mips/include/asm/io.h | 1 - > > arch/parisc/include/asm/io.h | 2 -- > > arch/powerpc/include/asm/io.h | 1 - > > arch/sh/include/asm/io.h | 2 -- > > arch/sparc/include/asm/io_64.h | 1 - > > 9 files changed, 5 insertions(+), 16 deletions(-) > > this doesn't apply to v6.3-rc1... what tree is this based on ? Sorry, I forgot mentioning this in cover letter. This series is followup of below patchset, so it's on top of below patchset and based on v6.3-rc1. https://lore.kernel.org/all/20230301034247.136007-1-bhe@redhat.com/T/#u [PATCH v5 00/17] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way Thanks Baoquan