From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C46E2C61DA4 for ; Thu, 9 Mar 2023 03:56:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C2A16B0075; Wed, 8 Mar 2023 22:56:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44D186B0078; Wed, 8 Mar 2023 22:56:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F5EC280001; Wed, 8 Mar 2023 22:56:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1CE046B0075 for ; Wed, 8 Mar 2023 22:56:40 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DBE481608CF for ; Thu, 9 Mar 2023 03:56:39 +0000 (UTC) X-FDA: 80547998118.27.1156D27 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 84FF5120002 for ; Thu, 9 Mar 2023 03:56:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ygVMihU7; spf=none (imf29.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678334198; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gUhuwBkGNqQAsWUATCimoTKOwrk6cDQaNmIoLHcpFcc=; b=vT5clgd5A4KEyM4uDVsgjHp3Bv7qDHvs/fm1fr9QskQQKRMP4AhXdxBUqgqFGy+UHmE0PD cyOfm+7q3m8qmiy1DhcxeXNoS/vPeswa7GBGkr+VnqE++osBgTRc5dbPo7CgJt5K1pAOxN VqKaEUKSdHqcBV5JtU5A/m3wqdAuE4I= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ygVMihU7; spf=none (imf29.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678334198; a=rsa-sha256; cv=none; b=XV4j/EcQjklnB52SjxQDxmle6Rq0ozCAQJkTF1S1BPf7wgf1zH1D/1tjTNO6muY/+ZaEpM GFl1XNxm8PaA/HIyR5/Pwro/LqkoLX1stgqPaZVQK7kSYBOylo1/T6EnMNPskUEpd/Rqb+ xwUTH42YSmFxukT3Can6gHmJkGQOdlU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gUhuwBkGNqQAsWUATCimoTKOwrk6cDQaNmIoLHcpFcc=; b=ygVMihU7V2DlUdXWp3kPVN3Bx/ 7ecOCmkT76cy8FeDhPRLvFdWrDf9Rssf3NpB6RdB9VQevcPHHMXAEQJNshzAAVDlm5YhTvvcWSneU c+aupjD+1U1C1oj2nr/HHVg93OAn6rpdi2ghAsDylld0WRru08Z643EAJkqNmPMnaCeAO9TMbnieo M02mbUUoyWTiGz1XQ/Db+2hfPcEeWogCLiiMnHH+ZMQJavzzs/M8Jp5rZrPZxTTJLUqe4wh86otB+ ZLpp3r3A8eO2a/PEacBnxjqR1zwm4snO657Pd6O/qQdqOK/8cDdSDdCFqAHUbzDrVy7uon9S49FB+ 5cDtpjCA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pa7OI-007irx-KE; Thu, 09 Mar 2023 03:56:30 +0000 Date: Wed, 8 Mar 2023 19:56:30 -0800 From: Luis Chamberlain To: ye.xingchen@zte.com.cn Cc: keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH V3 2/2] mm: =?iso-8859-1?Q?comp?= =?iso-8859-1?Q?action=3A_limit_illegal_input_parameters_of=A0compact=5Fme?= =?iso-8859-1?Q?mory?= interface Message-ID: References: <202303091142580726760@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202303091142580726760@zte.com.cn> X-Stat-Signature: 7fio98jwd8jkpatr6ociqsofwzf7iist X-Rspam-User: X-Rspamd-Queue-Id: 84FF5120002 X-Rspamd-Server: rspam06 X-HE-Tag: 1678334197-37242 X-HE-Meta: U2FsdGVkX1/sVfBlMwqTnZP4ouFutfTPrF/cp74sq+ToHXH4hzytVDECGSNKSkLiXSDAuXB7dnUoTDMkyxu/u3PoYh8dP68+muWDWhkEnrq/ayfOlclLRo2dKrTLQKuvzmlO82eyS2ug0d+AWGpgSk8vKDx3Ot6PPEdPtUB+0DPrfUnRAwFbElevDdHmjIGszwwGRaVieo7tYM1byV5jsuO3XEEM4U2r/6tqi4nnU7I8rHPQXmT/O/9gBBAPpJC7jUO8g1nlshILDvykMsOpSVNYAb0EuSGGmeA6xBwpO+r8y/9teTtLhkDpK9pUmg8CtZeG+yaE4xqjTWXPm2JgLJsugEG9JtcgGzhHm0F0J5SDVEJvHmnNL4p1jf2KRD+2cwUUiWXr6jU9fcx85lrHfRWe0hCy2jLhZl7FW0+d5nen8bkkhmh04hOlJO64HJtpceBYSDzR7F3D3TmLwPFPCPNWlsBKU7OhYtpgtUhHxQQ0PCZY+o/b5KcRPsX7UfPjT2kfKBOk1ARrIhWgDu4uoJGT+3dTebi+3BvYX3+/xly5ysS6a/RmZtr4sPAeR6VIZ9sSPbhuQudLG1i9Ddog2VjLhVSJsyHndoI+Smr9YjK3ogSgYeNqau1ljyc8MSeWZMhkQ+zaGJThiZVn+93BJALs6P5alhffJRMnrJwcZeMJrEZSVX8QxqmrncvSgjaTrcs517zD92P0DZ8hc151GNR+/u46yk9KyQyvE7/5mTjaBKCsn9ydEEDDZVHC8e+MQHhzlMnO6dcvKIkqy0JOEoAx9olq2W+LJl2SSQeXDYzMU5Ne5MgZNV1xYaXrgA3ktq9CNXiKwYKn3U55VmlME+T/fSJ30Eketo3m4BgAo1Osu/LV/5ttez1dGsjyZeoMB12w/FRpMW+upGXQmUyPR64/BbxjfJokiwqnQHunDrmhBfurbpyoGJ+a0vUXLgfPVWRVaUcsE79KpUyBNvq sViWUbok pEkpg8T7JKARWslJ8e7SbgG7Hz0SfWwdBWyAcW6dqH1mXA2YW32aEL2990Z9vjzOE/xGD79V6umGISd5Gam2tjmxijeYpjRGnUkEXqoarnwragoW02aWkf9HZTyVhuKCCnIHitbULkc0twoCwHpsoGeVQw6BYhWpQcx3CKHOdFuW1C1CBK1XjVYcE0JsnJydUrRuVYaYNhqYbQAMD7AqNY9csqyppLT8cKOpdN3XAdaWy71eRZOcaVcNhsctkFeKlIDvDuPwvSNwSIjROB/+WtXXufUS0Y/xedBOziWEU/vGWVXUsBsZtA/OagCnlxqhf+X7Nlbs3z1x1pATNLXoP2pLLH0UcSfwill5EOtJIRfyjRsz26acnLXxv9xrLOc5aFkB5b3/UAEq8GiCiSOq9jsouxpl2enrxh6VvKUp/Cb+gTNsnbQmT4H0XJ2cHmRYi8hs3ZzgmapTKoWU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.018401, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 09, 2023 at 11:42:58AM +0800, ye.xingchen@zte.com.cn wrote: > From: Minghao Chi > > Available only when CONFIG_COMPACTION is set. When 1 is written to > the file, all zones are compacted such that free memory is available > in contiguous blocks where possible. > But echo others-parameter > compact_memory, this function will be > triggered by writing parameters to the interface. > > Applied this patch, > sh/$ echo 1.1 > /proc/sys/vm/compact_memory > sh/$ sh: write error: Invalid argument Didn't echo 2 > /proc/sys/vm/compact_memory used to work too? Why kill that? Did the docs say only 1 was possible? If not perhaps the docs need to be updated? Luis