From: Luis Chamberlain <mcgrof@kernel.org>
To: ye.xingchen@zte.com.cn
Cc: keescook@chromium.org, yzaikin@google.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V3 2/2] mm: compaction: limit illegal input parameters of compact_memory interface
Date: Wed, 8 Mar 2023 19:56:30 -0800 [thread overview]
Message-ID: <ZAlY7jsj4daalgcY@bombadil.infradead.org> (raw)
In-Reply-To: <202303091142580726760@zte.com.cn>
On Thu, Mar 09, 2023 at 11:42:58AM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Available only when CONFIG_COMPACTION is set. When 1 is written to
> the file, all zones are compacted such that free memory is available
> in contiguous blocks where possible.
> But echo others-parameter > compact_memory, this function will be
> triggered by writing parameters to the interface.
>
> Applied this patch,
> sh/$ echo 1.1 > /proc/sys/vm/compact_memory
> sh/$ sh: write error: Invalid argument
Didn't echo 2 > /proc/sys/vm/compact_memory used to work too?
Why kill that? Did the docs say only 1 was possible? If not
perhaps the docs need to be updated?
Luis
next prev parent reply other threads:[~2023-03-09 3:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 3:42 ye.xingchen
2023-03-09 3:56 ` Luis Chamberlain [this message]
2023-03-09 6:58 ` Luis Chamberlain
2023-03-10 1:54 ` ye xingchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAlY7jsj4daalgcY@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ye.xingchen@zte.com.cn \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox