From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E40AC64EC4 for ; Wed, 8 Mar 2023 22:43:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EC116B0072; Wed, 8 Mar 2023 17:43:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89B626B0075; Wed, 8 Mar 2023 17:43:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73C3E280002; Wed, 8 Mar 2023 17:43:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 608906B0072 for ; Wed, 8 Mar 2023 17:43:47 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2E52C16084D for ; Wed, 8 Mar 2023 22:43:47 +0000 (UTC) X-FDA: 80547209694.07.FB0C1DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id E8246A0014 for ; Wed, 8 Mar 2023 22:43:44 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=N2fpkSLs; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678315425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jUpec8k3TuIoHkhdWuDgw2GYbAPkkhYheZa+lxQbkK0=; b=ggbXnfVWvNvlPI51PSE1aQmql7VL+eR1KaFGQzzEYQcv02QsCKRxkG9qb2RMDXOhOt0JuJ ObXUrSDOA345FEz/1Nnpui84AQEDqNo2EhSsCT8ZXwO4FGCmXka5Nrc528Xd6sL2pqbrN2 vksd3/ToluNQrwIqVBxCMzuYmfdE93Y= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=N2fpkSLs; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678315425; a=rsa-sha256; cv=none; b=bOQGAk+ZeBCSy/mqW6fhvKm+c+QMWSRzzKfJNpAsi8mGMgpik30r6Jg1TgjUdjx8skxZW0 qC3dF/NwjEfIGoDPb5QHWKcdJBUm7tepwHbzJZqvRbJBV8mBg79ZTo3BQOn1PqRgVCjS7H XG85HDOWDTqh9+ZSylko3RNIIgOuTx8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678315424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jUpec8k3TuIoHkhdWuDgw2GYbAPkkhYheZa+lxQbkK0=; b=N2fpkSLs1Meq2elxA4nXupZ4L22zPgTo6D1ID2kAGOQQWfjo7ADdadzmRgQ2YNG1H3vA3I HbJl+I9fubivJWWNspo68EP6/Xarm1Bvvl5WizCiV00WA92/G/d5EJLhxZpawtVwbRCWBW UvrMXF9H6EIX4HEQ941QAQlj6CtqPnQ= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-465-vVHd9lhjNLmjxsO1TIj2gw-1; Wed, 08 Mar 2023 17:43:43 -0500 X-MC-Unique: vVHd9lhjNLmjxsO1TIj2gw-1 Received: by mail-qt1-f199.google.com with SMTP id c5-20020ac85185000000b003bfae3b8051so78761qtn.0 for ; Wed, 08 Mar 2023 14:43:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678315422; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jUpec8k3TuIoHkhdWuDgw2GYbAPkkhYheZa+lxQbkK0=; b=lzUdjveroiUlSH3YbbPIJUjzHx7AsiLcNaZGJV2l8/w4Uh+ZfgsDNj0cvywavpcnhr FExiKWPz7TfpbLjjectfqIX+Ixo+loCELSeV+3xl4iy1lPPIA72OIAh2kU1F3Ua7wwv0 J2BX9oqzoqbS8xIlOkUmU67a669QnGHVLSCzEy8ulR7mbdl8s9MmTf70SQaYX3oF6Ay2 wXaiQlmK62s+Bty55dRT/CtuosI7Av1aacOZv1zCrKqKOYJFW1F/XMt4pVj7aauiq3qg ouuXztSoAtSydVxWUcGKUIDBPV8cAUYic+VAvOrFPc1hOViWn92pFDDSZ5klD1Byms4X Mn7A== X-Gm-Message-State: AO0yUKXLF1dhMsR+6nE+LZPr3Y55fGmNZvkmInS9nv8eRUCLUXTHnRVP MeWmeqGLIl70I0e7GBw1ppUGOSjmEXhjnna24+Hty/RzuOpEvZDcO4gEbAruEtHCnq5/mj3qaC6 ofZI7fSVsG1aMqh3YIww= X-Received: by 2002:a05:622a:4c7:b0:3bf:be4b:8094 with SMTP id q7-20020a05622a04c700b003bfbe4b8094mr39961488qtx.0.1678315422283; Wed, 08 Mar 2023 14:43:42 -0800 (PST) X-Google-Smtp-Source: AK7set/svpcFN7oyLd26+MN7LVXbPhQYslhKV53Vi4XzGLt4t3d/JLaXvYRZ51X7BFbuHcnLETSjqQ== X-Received: by 2002:a05:622a:4c7:b0:3bf:be4b:8094 with SMTP id q7-20020a05622a04c700b003bfbe4b8094mr39961450qtx.0.1678315422037; Wed, 08 Mar 2023 14:43:42 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id r25-20020ac87959000000b003bfc1f49ad1sm12255401qtt.87.2023.03.08.14.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 14:43:41 -0800 (PST) Date: Wed, 8 Mar 2023 17:43:39 -0500 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Hugh Dickins , Jan Kara , "Liam R. Howlett" , Matthew Wilcox , Mike Kravetz , Mike Rapoport , Muchun Song , Nadav Amit , Shuah Khan , James Houghton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 3/4] mm: userfaultfd: combine 'mode' and 'wp_copy' arguments Message-ID: References: <20230308221932.1548827-1-axelrasmussen@google.com> <20230308221932.1548827-4-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20230308221932.1548827-4-axelrasmussen@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: ops3a9qqf91yku6t7r48bceo9y7sg3rc X-Rspam-User: X-Rspamd-Queue-Id: E8246A0014 X-Rspamd-Server: rspam06 X-HE-Tag: 1678315424-225998 X-HE-Meta: U2FsdGVkX185yo0/u1qm76C9fWfODrfI4qzlMyj5GuyHc17ersDffe/y9r+LX7Mp+X34AZHy0dFqOb3kM4PvOUsCWSb+4v2o4OoenoNjj4yczzD85rA8T+5AZrStDyiVyoyVuVxEg8vUIp+11BxErDwNyChHrnE0HNVo9E9fo02EAwXIoYcUa1uYa16No8mZnb2kZ04cjkt1Szo0kJmFCCfOdwEXPULWLDWqFsTf4Fi296hllYQz/FRvG5F/GjnRd+s2N09WfAIxSfqIQOvCaJ1YMuSHuxlVkj5ih8Kdtmb83vyhPMwqFAhoQ9b7bzIXG4yMYQaGPJhnSjcU1I7rYcNsKqPjaqvroAFJQelhSGuKJ6ZVkgF8MKR8kz4pdBRFo4mtksTQSC+kI2OJjk9x4pp/aiG6eBCGb7s/4XEmKJdmIZJJhG+4zecuHYmI00Xnxkq85DDAQHgxDaMMrmlGSHcIp6peyfRIEveyrlg4frHfIGzKXnYpEuO/Qgne55PvWu7x9UAGJzczT8sU4MPV7fAgbHVQ5JW5rBdLoy0ChDaCnavgk5RB6M5qsMYXmBPRdYEpvjULXgRPyOjsQ+m16CeOeQziy4Nxgs7n6XfSK5+UOnrcDka1/wIi2g8kyjd3zK5xw2NjYMrZyK+gk0WvC+PtKE6XbwzgYQXVNDZq5cpXMGyBtTSnAKVZQV4CXrX5o7GboUpbYJLJskAsKTUiIE26lnjW6qdJxMFB9cFJ5mfa8Cgndd+1REVdFRBSUa0MvotHYrrbAwKuKbhXxDt9EdqqQQXiY0E4d2/snYrv+AJnyFGmuYrjqFbF1nQidluw/uKyAS9rRxcA78L+s4WZCHqe10T+H3xbnpUyew3stZupihcVWnUNXwVia/k/YP4DAYCjsyY+QA/vMjQRBM60cxPOE7BsLyObvRYZefNhP7KzwBtQIrmXKEsibe2NP9Tkkj/CcvMjuQ5zQk9G9Sl 0Z7NU8St Peq0KYV99lKsM8LjbhIFPPwf6/p1D4TQwOmb0Pk5bwvo+lfZ58wGEdrGJHMfugSlfWKdsqq2S9zQ6nv5vcI1b0vLKXZi/7LTNyOcXA3UoIDb/0/q8j9meDfqjU1tvzbWGOxWq3sCc7em8CLaXiFzkkx78/lwBv2+n2jz4bQ+dGyEBwyGKA4pqXs7xTIDaiNrI8aN+0tR4e5rMV5NxE4dMEBCD64+gJGsYdeLh1Ch6vmC94JtohX4wQL5RARfQP4YsoI+sR8zVSndpA64/k77d6Y1VC/0A+5247X6S48UIx/dHFOA5QXr9Orke0fJuYR3CXblqexRic5hyFBTJcdHy5tMO81vWb9VsBAj1UvLcAP4xpkRQMedm+PbwiH9mdftQL4Q+T90ZRIhq3bR+JufZ0kE2lMdMit1FAmByiNfqOv9eyWlFr7q4n72IzG/+goMs5stOUrr5FWk2uLU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All nitpicks below. On Wed, Mar 08, 2023 at 02:19:31PM -0800, Axel Rasmussen wrote: > +static inline bool uffd_flags_has_mode(uffd_flags_t flags, enum mfill_atomic_mode expected) > +{ > + return (flags & MFILL_ATOMIC_MODE_MASK) == ((__force uffd_flags_t) expected); > +} I would still call it uffd_flags_get_mode() or uffd_flags_mode(), "has" sounds a bit like there can be >1 modes set but it's not. > + > +static inline uffd_flags_t uffd_flags_set_mode(uffd_flags_t flags, enum mfill_atomic_mode mode) > +{ > + return flags | ((__force uffd_flags_t) mode); > +} IIUC this __force mostly won't work in any way because it protects e.g. illegal math ops upon it (to only allow bitops, iiuc) but here it's an OR so it's always legal.. So I'd just drop it and also clear the mode mask to be very clear it sets the mode right, rather than any chance of messing up when set twice: flags &= ~MFILL_ATOMIC_MODE_MASK; return flags | mode; But feel free to ignore this if there's no other reason to repost, I don't think it matters a huge deal. Acked-by: Peter Xu Thanks, -- Peter Xu