From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D0F4C64EC4 for ; Wed, 8 Mar 2023 22:23:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B9ED6B0071; Wed, 8 Mar 2023 17:23:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26A3E6B0072; Wed, 8 Mar 2023 17:23:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 159BD280001; Wed, 8 Mar 2023 17:23:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 06A5A6B0071 for ; Wed, 8 Mar 2023 17:23:20 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BD3E5A10B4 for ; Wed, 8 Mar 2023 22:23:19 +0000 (UTC) X-FDA: 80547158118.27.4ABEB4F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 2C0EB18001B for ; Wed, 8 Mar 2023 22:23:17 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WpHJJcvB; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf06.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678314198; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R4qQSPrsrxUiF/LJLwzutyWNWtqvwbqt9ycagzE4dZQ=; b=YhdaNlTfPPC98qVTf0YLjstjCWIKR0YVh6jKs6O+wM55E2CTDPhjuWWbaBPd7RKTc12J32 GlV/QsoHzIwZ+af6zJxNW2j9W+MmJFs4UO7lODJSGZidrvo0m2TWorOPrjH5J3mUAYL/3B O3B15SnMt24pP1L+3lfz8yt0M8PqbrQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WpHJJcvB; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf06.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678314198; a=rsa-sha256; cv=none; b=v+Xdm8eWLycztKr38l7jf6X8gl89WpxGkYvrz2p/Rw6N0/c47Grlx4d5h6AVXtAHdHwIWc jfXP7ozE7ZGn8BTX7CIbvlBIdvHaabqTGMDa/6XfPa4AnzNH5rBynTxONUGteyQ4aB7BbJ tF8aDz4wa9lgJjLQBULvPogyaXiEDwE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R4qQSPrsrxUiF/LJLwzutyWNWtqvwbqt9ycagzE4dZQ=; b=WpHJJcvB82hSQFBxW2dUBjILSg xWKBDo52IxNzYVR8UxlzdFs1AX5W3i7+KKQgVUYNhZdb8E/cbEEPRjdtYj7pAVUCH22rs58crVnnw 58pIGfnUH7p/ZVXxJUxXKnWIXVN/A/eof+fzQfAi8Coo1I1yICPSB8WHrwTFZ5C5aAL8Ie3184eQ+ axjXHq6rLEVpG2YgxUW1eyoL+o6PY9I9114cnaAukCTtHkbMdj0V0SBas/RqNQ3Bx/Tidd4hGD7WX 0EyyeIRrrrrz4ACT9N2QvjVG4uLmRk2doE9emiWOkxqUI0EEcQNtr7VCw6fLq0EgY/MwU3D3nFM4X W2DwxJGg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pa2Bf-006xGf-CU; Wed, 08 Mar 2023 22:23:07 +0000 Date: Wed, 8 Mar 2023 14:23:07 -0800 From: Luis Chamberlain To: Vlastimil Babka Cc: ye.xingchen@zte.com.cn, keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, linmiaohe@huawei.com, chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH V2 2/2] mm: compaction: Limit the value of interface compact_memory Message-ID: References: <202303061405242788477@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2C0EB18001B X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 5j4paei5g49w7g163nzsm5qmihq1xtyp X-HE-Tag: 1678314197-140184 X-HE-Meta: U2FsdGVkX18SgVQaFUUyra2PhLb+8T2ydn9wTvatJRK6C+Ywjp6qUsETNii4vj2+MG0VL6w/D+jKmVtlHIgbKsQPqb6yW+/MjSu32G1Fmxrg357VrWMvKlv95tpt4MPz0U66rcGEH3/LEY0HqYcUr+SigPyiA+riOolzn8PBDyM+ysyRfYRhko4zTtrkOR2NvCCnYbOjy58Lkp5ezjcHNWQAopyxseCpPp6MPJjbQiJUsylEzebR/Q02n5hWfHLge261hMIbA+Uh2UBKIde8BwVi43O4HrmIZpxs90+8Nh0uZ1ovI6d8b2xX3h2NTaWbMoQdLHVaFrswYn9mpXOT9hZ+VNPR7jT26yPCGNym/FJkB0O50fiCxAbsXhCPRNDh0kyj3YytPw7iFmH80vOXIX9EvcRugAFvifiMQ0fu8K/vFm5UNbOpsqCDe1NVIDIVb4f3qX0aTsXyR6jkT54aXnQckeRXLl7VL94MbcckEVerby4ja0nyU6fOrzad3iO4dch7nsd1v2mAoy4MP/Ws1O5tPZIx9Wud4msrAZcfEPZZBAxGQEFTUVjwa/DEybzh9GNbemmudEBTC1pCbU5LhIrCVpCw51L2NWfKIIuHok5R2guIHYahrUAnP1+PT9CLNz7SXSJJMsgq8LCtztwqmLsYx8/MiSdP9bDNPX6yqvdZuyn/lxhis56d/VazM51uxO5ff/R+IIypwkiUZJ75JZiC48XCQXrkWSvB0EUUysmnesXOOwFpmh10d0NrVMQ33sMloe26C6AOvb+Z7qrDXsKIFwLwDJBbh7PBI+C0NnM5EV+Mm1TDENn2YeJ0EXZnqtcVtVvOFPP/s3B18q0bYDBIFeZfNgLhJfnH9b1x6H4VZ5SnZhK26jXeffXN6Uz82jbjI3V9i3KpMHsyZBADlNNS9ml+nlF7QZcZtTFISpa1div14Wjrhib95F7K/Kmi0I0fOkLCwMT0EPb9H5W dcvgIjmo U5ZDgwElyL+69RfQUP3HzKgz47acFCYBD2QpTEEEf+sQ/wOrJMBqpKe59jG1wHGhAKuruxLfDetXQm6DnolgluxwVAw0yQfjGUjpBnocertvK8hSKIXzJICpddSE1T+JoMtAy5sSwGmRzXNnR/pbt/BGU37emqGV8bWOlysz1YHT9oSwn526W5os7vstp4/ER/82+OWDiX5hlZEnARv4W3pSr7O8hAPct22iMNhQ2NCsEtgngI/QKWQ4oMva8uxNoGMMCZJyzELOuMieOMV9XbgWLpgQjQqlAWByCPIhCEzRNbdJtFiBn4vaJhX+WF4cwt9Y6N/wKLivhRvICwzABeXnxG2kjL6NOG7hH55M/ARhG7xrE7vrU0DYmMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 10:54:31PM +0100, Vlastimil Babka wrote: > On 3/8/23 20:57, Luis Chamberlain wrote: > > On Wed, Mar 08, 2023 at 11:23:45AM +0100, Vlastimil Babka wrote: > >> > { > >> > - if (write) > >> > + int ret; > >> > + > >> > + ret = proc_dointvec_minmax(table, write, buffer, length, ppos); > >> > + if (ret) > >> > + return ret; > >> > + if (write) { > >> > + pr_info("compact_nodes start\n"); > >> > compact_nodes(); > >> > + pr_info("compact_nodes end\n"); > >> > >> I'm not sure we want to start spamming the dmesg. This would make sense > >> if we wanted to deprecate the sysctl and start hunting for remaining > >> callers to be fixed. Otherwise ftrace can be used to capture e.g. the time. > > > > Without that print, I don't think a custom proc handler is needed too, > > right? So what would simplify the code. > > But we'd still call compact_nodes(), so that's not possible without a custom > handler, no? Ah right. It does beg the question if that form is common, so to define one. But that's just extra work not needed now. Luis