From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BF53C678D5 for ; Wed, 8 Mar 2023 20:01:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 982566B007B; Wed, 8 Mar 2023 15:01:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 932476B007D; Wed, 8 Mar 2023 15:01:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FAE86B007E; Wed, 8 Mar 2023 15:01:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 718196B007B for ; Wed, 8 Mar 2023 15:01:17 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3C10341018 for ; Wed, 8 Mar 2023 20:01:17 +0000 (UTC) X-FDA: 80546800194.05.F69187B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 868A98000C for ; Wed, 8 Mar 2023 20:01:14 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QsbvVsbo; spf=none (imf02.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678305674; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VHBqNuY0x1wxfPhHVQhisSv8VveYnM+bpNzuUcj7maw=; b=FiLNwfRSK8L5Z7QEwTCrwZF6RQmzLuphRYg/ypoT9/E2PV75cxNr+w3YtspuNGe4gubtQG 1AbWNXdy/xkZGOlBJrKCzVrMNeHQ78KTqadjYiQWmqQczBv+RDEe+pNdXWG8MdRPTr73v+ 1EFHawmYCShtJ1I9tAfQoRLULL3CT1U= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QsbvVsbo; spf=none (imf02.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678305674; a=rsa-sha256; cv=none; b=1lDTMiSfLBBpNDyvGCuaC7ZjVFvGewtMtoqHhEmnt/WNjrfBm7kddjIOYwQ7KOACuvnUNh 2UsXVvQGrnp9OwjfxT8HJIFUnR+CY+ABs5IXnF8JoK5uMPSdcZp4f7Y9sto5oMxb3vkm5t GVcf7f6WcXu259Wctmk088jl+UvLuks= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VHBqNuY0x1wxfPhHVQhisSv8VveYnM+bpNzuUcj7maw=; b=QsbvVsbo95uqiUQ+u8JFvQ518z V5F2rcstU9wf3BOZjyhsTy80HKciKLqA7C14qMCSfqBzZ1KHmQfO5BarLsBQjON8VhmhTfD4E8v8N Ay1lYX9BjQwNAR/mvrNrDq+5gM49bap//5a/DKAB8Giq6IF3UlDstW9ya8c8i4jerLCVZ9uUtswrx dEI6EPvcZckPC6tcmbgoHTJrrf3mrcCuf1ngncIgFqJJuRKlRqW4WKieMX0zO0Nd6mVDErZ2TwWib wrqBsyJGkc+C/nbyErpVX/GVqfwMldJMf4Qilms8fJSjmgqZ+2ECdfmTnMHTr3ZmgT99hupAIshNB 8JBgY0QA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZzyH-006cUe-Bn; Wed, 08 Mar 2023 20:01:09 +0000 Date: Wed, 8 Mar 2023 12:01:09 -0800 From: Luis Chamberlain To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, mpe@ellerman.id.au, geert@linux-m68k.org, hch@infradead.org, Helge Deller , Thomas Zimmermann , Christophe Leroy , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64 Message-ID: References: <20230308130710.368085-1-bhe@redhat.com> <20230308130710.368085-2-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308130710.368085-2-bhe@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: gcw9qmx3pr3fe4e4h9wdwuo8dj38p7wu X-Rspamd-Queue-Id: 868A98000C X-HE-Tag: 1678305674-476140 X-HE-Meta: U2FsdGVkX1+RLdy/Hs7fm6APbzccMmdEuY8fW51wY/itMOpLvwnbkqkNlZCXxKIv3E2DCJreWgonvHVycU1jAFnyNdJSyVV7nqyFz2ZD/YCaq7vZMjTWwlPmK9KhiZBs20yY9Td7ChHk5XG8tqvxsPpojyyqoEMyAGyUTLQTxyUjwm7TGFD0GUthjqt/rYF8bFV70ULzf/lXDzM7dQIMvXJpT7aIN3JnFrosFQgEDhoBj5t+KKuylLbpzwIBowVfjJeHODTW+/mVBktlzbJnNtzVnDeuEk0nVI1b0QKqmW/7kVU5wYIIPzmZTL8OpxHh2TjHOYQoHzi+OqctPWorGjtOq/DM6H7XOqrsCGLQ8sEsG45DpwTvy1aehV0zD3zLqDU+vBPUDk/9fhWVOOEWCykLw6RhLkytWThdgH/1ExUXi8xAnrU8IakPw+VRbP1bxPZekap0jdlS1lnc+Lk1a+7loww0yMwRpM4cKythCFx+o/DPeMMEYiORnIE0uwErBrB7UmGPFs+7qLWKTKGGQ/96VnycOOXTBVrl3AHE0K8KxnaQNrmzdj3h85v6lrLcV+1xezGB0sJnpArF2Dwos2Xakt5D1ziPu9otZfXl6HLkMPPLYLsKxD2TG9fVNQtFsT8hTp/F65DeBNcPoqqR+wKf6j42DR5Ek7zGZYWLEfnJnL+/4YPqF/GHY4yK0tMXlsmsTR7CGs0jlE2Wt29eh/lrd1RKpCPrhcKwmj/3WJWcwbYzAcJwBmNAIeqIEdQPhezjPK1sB8E7wSWny8MqeAWnZXJCEpLwRRKzYXsY4NdQcXFGqMUGErBYz0+Q/J96Er1glYzqBBylLLzK+gUQZadDcRCl645dynSDrayzD1Y38mJBU2cw9fCnwgZhybxg6j9f6kpslMxA9g4N4iJrXgBd6i3b5MDxGMHfOIVliixYiXzU9gzpKMo29HFSyvgM1d7bNj49ggdnLqWZ1hf vZ/rZt1g RXNR6XNRZQEq1J0QM3d16J/gkjvih0kSonHI/yW/98MjQ3zTTzpBu4lK4GtBbAdS2rCaZJcu8lSuPERPcsPu93Bg3l4oLw95QIhDY5BiNHwfChkhQ6vozFqezgZ6TM1U3EMGip9nifggyhePo8wv8c4k7GpQBwqoHZ3kmTI20v8GVMSTKsGqnrAOsBVstcGtEB8yKDVIau5k6QE6gHD56Fc/eHuvCZTCGxLJtB8k+igMc1uFup/LcQXc2nmlOC/7BwP5BD4QpCwuaxs/zK04coDeQ4haQ2zdjfotsvVAF0owdhsF7SvdPI18NcxPdisSWuRmh1O/fZZ3D4JOv5Zi97l+qyDs1YRnlKAv9BRtAP9zMm8BZde6CHwqXl1Fq6BHhuvMjtroQkmqVFUGi9BKpXvsIp0eD8BejD7Fb8xK1BVio6kSRVYbxgIa8HqdBB4RvjX4ZA2W3v6CvvYbsGEULqZbzBug4A5tSNUpPaSoUEm8x5pOHxlHU84DDiDDcNhHpV8exiczxF+jWcrKElEbU9nT6FcfUs49Xtbl2jJNDcbRiXAdgNZdTnfX4iuwkMkvCLjqP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 09:07:07PM +0800, Baoquan He wrote: > From: Arnd Bergmann > > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > extension, and on ia64 with its slightly unconventional ioremap() > behavior, everywhere else this is the same as ioremap() anyway. > > Change the only driver that still references ioremap_uc() to only do so > on x86-32/ia64 in order to allow removing that interface at some > point in the future for the other architectures. > > On some architectures, ioremap_uc() just returns NULL, changing > the driver to call ioremap() means that they now have a chance > of working correctly. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Baoquan He > Cc: Helge Deller > Cc: Thomas Zimmermann > Cc: Christophe Leroy > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org Reviewed-by: Luis Chamberlain Is anyone using this driver these days? How often do fbdev drivers get audited to see what can be nuked? Luis