From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ABFCC6FD1F for ; Wed, 8 Mar 2023 19:57:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B32B96B0075; Wed, 8 Mar 2023 14:57:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE2D86B0078; Wed, 8 Mar 2023 14:57:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AA3B280001; Wed, 8 Mar 2023 14:57:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 86E6E6B0075 for ; Wed, 8 Mar 2023 14:57:44 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 581DBC05F8 for ; Wed, 8 Mar 2023 19:57:44 +0000 (UTC) X-FDA: 80546791248.17.F82F4D3 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 923DF40012 for ; Wed, 8 Mar 2023 19:57:42 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=iVR0qR+C; spf=none (imf17.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678305462; a=rsa-sha256; cv=none; b=hnmyk/EqR0BLOBcdilTKyHSaHUog17Z3N9uDxB9Hk8ILMaA5Y69SkV2D2ow/ryFKrvuYwk zY4OMHa1lfg4k2XmmDhapvuaNOIHGLgpb8JSK4GQzrvSHiwtF32i1+toR0lYLljxdPxESX Qw1I3ASQto1R+YRksg+T7WozhV9n8Yk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=iVR0qR+C; spf=none (imf17.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678305462; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uo9/aqo20KI120FvQgvIVbHTtMTRaptP+tVLmnc4amA=; b=hN0rT8icWe+wXu23DXFGx7TAMQUZztInT6x2P+eWg3A/tbIl0xZDhBe4PJHVwQ3xOroanP IHdHPGdvU0BJvUXHzglveglRKKQeoiAbBnhFmbS5qvVvzFf+QIzpBik9i3CY6T8WZP0auu UXRQmsZ7p18EsZTbdR0wt8UHeJtYQZw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Uo9/aqo20KI120FvQgvIVbHTtMTRaptP+tVLmnc4amA=; b=iVR0qR+C2IUumAPzmongx7qG77 DaIZ1RgKiw5jipb3r0oqBvmQEno9Ltfooh+oQuA3ejQu8xVB6hwTnEbeYcr9FvCXrZRV/46obu6R9 7JUMI1InQaTnIadzcQnlFgNjyLPODLlMrXSGt8t+I30FBP92yMXNln1dHyVcJeQePk8zACK9IM6hS zcWD8/oZECEEsk+bQp0X4SXaQFyOTaIYPFeAp0pHksa1CANwGMSf9z1IyUd2uYH1S5hWwRdBOtRLW B6672VITdC/sgxnWs2WASPZYP4jyNnSCFJriXGXPilJgPdtaXNfIeiTit5+WbHH3CHIWW1fTAAlJf dB+3JQSw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZzum-006bng-W2; Wed, 08 Mar 2023 19:57:32 +0000 Date: Wed, 8 Mar 2023 11:57:32 -0800 From: Luis Chamberlain To: Vlastimil Babka Cc: ye.xingchen@zte.com.cn, keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, linmiaohe@huawei.com, chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH V2 2/2] mm: compaction: Limit the value of interface compact_memory Message-ID: References: <202303061405242788477@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 923DF40012 X-Rspamd-Server: rspam01 X-Stat-Signature: wkxj3afkuxsc6p58qi719kno58qx69m6 X-HE-Tag: 1678305462-592233 X-HE-Meta: U2FsdGVkX1/gv593hLghCDheqssdLBYICt9+soMFTCUpub6CUettcgHQ9oQuKcSlkJHmMxdwTupvKmyQVG/1terebsd0djbP7DvYEa6PCI34YSsRWBWeCbauFf/++H+6MQ4qqbP7LY50boY/ew/06xlBeW4TYKCU9gpfOy0xul098vbD9J1KtQIf+RTnT4ZXiYhoDvOpKm2PM2cf2T6LA3z6lkfOFACYDDpcURvTH2IViTk1up46OcnmsF/YD1xEASKFxWsgKM6hvL2F3j2zuPvj6WXRpzNjcqU5o7sR/eicu1ttyGmL0Yp+jPQ+jrb5okiIfv23UnWfBD39s5ZJ0RZoBvID6qCqkmW4JDR7SNzDZqVeIre6ktnPISnJDKlub/JWkmQC2eVrGgXIq9QS3INOwAQ1V5abPrqeRFTdDjqV37MGBewo1UfjE+6B9m0vTpohNlePnWdVlaEQvW8O+xawhL8C93lpDZ3JV1WBZIpepY0SMNp0ZQXYo0UEKdovfiNQAm6Hdo8k6yjtlO12CANk2IxvQerIFPDmyR2RnnTwiJWWq9POIAGsYRKTr0n6+1G+5ZhUEmsrBMlhxTCcuesg8fn304a9bxmWB9imOh5cqpAOp/drvbYop9x9gy1NXyYFkRmOLGxAW6HWIECeUT4hELdvri9RSUZ5mnS3tpuqvRwp0D18nPVL9hgG9JyrdcnXhS+mv2aGFo1O1yK2JVon8KvREnJgB4NzSkzs+AuPBvPpqTJFoXnG+0eeyHpEbdFG1KSGq49upET+DXD+ZE0mwl7FD8ZsgTolZjNYkRkhXKqPvJABJ9LXhz7kjSz3yEnijOk0b/LVQfL9zgTxewF6sMWRO32OV1uWaheIOWyKfVQ90vEU8cjvBzNME1DlUu4YnaNNyEeqMImqzYAAFJ2bqhTcMhnCxOBXXT0DkGVSFuCJtg7lQVyihBEp+1aF93gXapJUbMNJcyLeosZ bNllT6IA qH6JjA0ezmGzE0LDtqdDTlHkOVMNfJSxJQBHlgu/psp1/aqpjQ6yBmapq74OROcENIRNy8IlT3eGXcisvAh4xq2KqX6noK7FGW0Sv1Fx0S9eZL0Ub1UdWtIWaMEnKPcSqPQzyqou8Yvbt7WFKOKwKwnhjqQh0JloxAuYB0Cq/XzoihHD+RwNlTcWfdel3u1C1h96fMGyW2JABFO8DX/mln/Lmd8zbwy17CDm+5H2oGzP83/MzD0ktlrL/O2lznUE/Q6iIpd/oBd8gL0oONn4XUCxGUSiCqrRa97XsTo/FDZpcZ8/em3AL9vw0oPXBI/5PEHlZAofSJ3eX8O929jAx11Y/aIoEYC4S5M7psrOnLhIMtI12JFHhd5uAkuPLyGqzG0adh7ALbXGmCBBd0I2LlAnQmDAvHfjPYA4/hbZC4R+PQLFly5+g/K2F4ejy33vGRe6I0sQ9MsQaJ6oKT2N4mJOvSCGPLRsu1H+ACwI35cQ9ghqyDNIUizkREhcQNKpf1SwBlN7uR8u2Pci/CBmURbqNTTJgLG142azgxACgsiaOnzk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 11:23:45AM +0100, Vlastimil Babka wrote: > > > On 3/6/23 07:05, ye.xingchen@zte.com.cn wrote: > > From: Minghao Chi > > > > Available only when CONFIG_COMPACTION is set. When 1 is written to > > the file, all zones are compacted such that free memory is available > > in contiguous blocks where possible. > > But echo others-parameter > compact_memory, this function will be > > triggered by writing parameters to the interface. > > > > Applied this patch, > > sh/$ echo 1.1 > /proc/sys/vm/compact_memory > > sh/$ sh: write error: Invalid argument > > The start and end time of printing triggering compact_memory. > > > > Link: https://lore.kernel.org/all/ZAJwoXJCzfk1WIBx@bombadil.infradead.org/ > > Signed-off-by: Minghao Chi > > Signed-off-by: Ye Xingchen > > --- > > mm/compaction.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/mm/compaction.c b/mm/compaction.c > > index 5a9501e0ae01..2c9ecc4b9d23 100644 > > --- a/mm/compaction.c > > +++ b/mm/compaction.c > > @@ -2763,6 +2763,8 @@ int compaction_proactiveness_sysctl_handler(struct ctl_table *table, int write, > > return 0; > > } > > > > +/* The written value is actually unused, all memory is compacted */ > > +int sysctl_compact_memory; > > /* > > * This is the entry point for compacting all nodes via > > * /proc/sys/vm/compact_memory > > @@ -2770,8 +2772,16 @@ int compaction_proactiveness_sysctl_handler(struct ctl_table *table, int write, > > int sysctl_compaction_handler(struct ctl_table *table, int write, > > void *buffer, size_t *length, loff_t *ppos) > > { > > - if (write) > > + int ret; > > + > > + ret = proc_dointvec_minmax(table, write, buffer, length, ppos); > > + if (ret) > > + return ret; > > + if (write) { > > + pr_info("compact_nodes start\n"); > > compact_nodes(); > > + pr_info("compact_nodes end\n"); > > I'm not sure we want to start spamming the dmesg. This would make sense > if we wanted to deprecate the sysctl and start hunting for remaining > callers to be fixed. Otherwise ftrace can be used to capture e.g. the time. Without that print, I don't think a custom proc handler is needed too, right? So what would simplify the code. Luis