linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: ye.xingchen@zte.com.cn, keescook@chromium.org,
	yzaikin@google.com, akpm@linux-foundation.org,
	linmiaohe@huawei.com, chi.minghao@zte.com.cn,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH V2 1/2] sysctl: Limit the value of interface compact_memory
Date: Wed, 8 Mar 2023 11:58:08 -0800	[thread overview]
Message-ID: <ZAjo0HaUTCzQtN1Q@bombadil.infradead.org> (raw)
In-Reply-To: <83344b3d-1de1-f3c2-913c-a8c54ce7a99f@suse.cz>

On Wed, Mar 08, 2023 at 11:21:36AM +0100, Vlastimil Babka wrote:
> 
> 
> On 3/6/23 07:07, ye.xingchen@zte.com.cn wrote:
> > From: Minghao Chi <chi.minghao@zte.com.cn>
> > 
> > In Documentation/admin-guide/sysctl/vm.rst:109 say: when 1 is written
> > to the file, all zones are compacted such that free memory is available
> > in contiguous blocks where possible.
> > So limit the value of interface compact_memory to 1.
> > 
> > Link: https://lore.kernel.org/all/ZAJwoXJCzfk1WIBx@bombadil.infradead.org/
> 
> I don't think the split to two patches you did, achieves Luis' request.
> 
> IIUC his request was to move the compaction entries out of sysctl.c?

Yes, thanks Vlastimil, just git log kernel/sysctl.c and you'll see tons
of examples.

  Luis


      reply	other threads:[~2023-03-08 19:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06  6:07 ye.xingchen
2023-03-08 10:21 ` Vlastimil Babka
2023-03-08 19:58   ` Luis Chamberlain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAjo0HaUTCzQtN1Q@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=chi.minghao@zte.com.cn \
    --cc=keescook@chromium.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vbabka@suse.cz \
    --cc=ye.xingchen@zte.com.cn \
    --cc=yzaikin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox