From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01301C678D5 for ; Wed, 8 Mar 2023 17:44:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49373280003; Wed, 8 Mar 2023 12:44:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44397280002; Wed, 8 Mar 2023 12:44:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33248280003; Wed, 8 Mar 2023 12:44:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 24020280002 for ; Wed, 8 Mar 2023 12:44:02 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E6AC64067F for ; Wed, 8 Mar 2023 17:44:01 +0000 (UTC) X-FDA: 80546454282.09.8308874 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 969C440004 for ; Wed, 8 Mar 2023 17:43:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wUFyHJJF; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678297440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hVlYW22a9H4WbVtUhENiaLSg/BVsrcRwxpU47Z6jYfI=; b=elRBVKqxPBV03IhzuK4MK3ROgLOljwpd8nuE7kPBQN2Zo3jpw7bQbG34cOXqZMK/br3cS7 +WIe434q8eCVH53BWNOy6TF1XUQJKKALZw7lfA7/fwGxpIxhZnOHWpEvy1VNE34Mq3DIkI F1EBc7v6mITCyD/tMO/6A59TxHK574o= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wUFyHJJF; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678297440; a=rsa-sha256; cv=none; b=Pc+6xrG/EuZuLfeGgtwumTY2Z2a4PlGFvtCKqfhVb3az0MHFCK6CNu+5PM9Vb1poJ87wfM H6L+xdcwnZcIAS5q2nem1/2Ou2ZyKsvXnyuXrJlpAhxN73K95SMpFzwRAOYXVJ4GjxQXbm BdMwWZCOOzaYFIxoBz/LhdjqkG5SZq0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hVlYW22a9H4WbVtUhENiaLSg/BVsrcRwxpU47Z6jYfI=; b=wUFyHJJFRm/W9C+KbbbQLDShKL 8zmtCiBbugfrYh+ZZtIfj8CfdBNJ0Fr0kwQyxjgXB8yQ1vfz8NR8fEDByALiap6VqffsAbuNm03m4 pyfT4vxxi4KNvAX+A8ENvidEGL0glxQ77WutIYBywdtZmv8yfkP/O58E+5LVzkZO4VW35NlDv4XwB lnauB9HHihOfLlH3uLmR9LPkm3kKvQKOlmOlceCeisaPoNAoej7XnRO1Rorj9Xs7/ukMInHFoRUeG bH4H4tD9g8DVhjEgorkJ4FkJ2dJiG+49o8D+V1F/cZ7FT7UZV/ErvpuGriSRxsyvn5s4tU4b2fWn3 LTjCxlxA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZxpM-007ahZ-JC; Wed, 08 Mar 2023 17:43:48 +0000 Date: Wed, 8 Mar 2023 17:43:48 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Danilo Krummrich , Vlastimil Babka , "Liam R. Howlett" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate() Message-ID: References: <20230302011035.4928-1-dakr@redhat.com> <20230302015242.xi3y53okc4skmonn@revolver> <9abef101-3a9b-0bdd-7139-ced7d5e28ebe@suse.cz> <20230308144343.GA16259@lst.de> <59b703ac-9660-a0e5-09f7-c5b69d4f39cb@redhat.com> <20230308152913.GA19628@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308152913.GA19628@lst.de> X-Rspamd-Queue-Id: 969C440004 X-Stat-Signature: fxqqgctcexgr6xxb6awoat5def7o8y7y X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678297439-845991 X-HE-Meta: U2FsdGVkX19ODOls7n4KcdIWQBYjVYFGElRhqH0xkURdHiygheyvIsl4oI8DnGoB3vFaF0a9fXAS4lr5mclujgi2pZq1Lgn5/OD1c3OzSzx8hUA5kbq7TJAcFzLUJvb0ZvIn7vBrnVZCppqjpJeCS05MqBeUtO/e4leuHj3QAdDyHBOXIAT7j4xOUVnMuWJBYF4T2fNdRKVNcsIP17apHuF8wxPXftTvEVfXGTBf2KCsuSKV/8/ShjyV613Y+S0xXk+a3O3Uw3sGZbbsVUF2kLTzL73L2fQYxKoTuLu/pu5/J6omnP213u6tPaWj5n9pPQ/m2gdy1leaURIsh0dwcridCp2oayIebXmTNrkLlJTzxzJCKcj6rf/mbrZlLTxQ8rMCN24ieaW+feDhrslfDZxE2EUGPB6TqJpIDcqYmocbG1tsCa4Me1Jve3CAz7/8BbwcCzwjixHfFbGcAxSsg1vHiNrFwS59cK6lbXx7/CB2n8nHwqqE3leeuAVWqevdKWrUJpx7nAuPevFyVYV0fSVoLvzEBYBTjX9wx5GKPtriNCuTB43Q7GjXuttPGSW1MVZirQbhZk/9biToM2DAqfh2JiDBi1JehaDTQD1fLa+r03mMb4OXA7gc+BlLKA73mQyuLzItG416gA0Umf1xFpY9D+FduspV2N0rnXVK3uGxaYPSjKD8iYps5qk+S+2RJVkXCs854/qLSpVN70XwkQqSs0yOJLAU2efVkExHP+rBAqFLLzt5YlKC756iCdUWizO7uLvuCoKQBkFNhC3bb4Hrhziw6J4Kksg9E4vvHxwfkTABTw8Krc/4IDsgpoOQqDvx5mPdn7T4rrAbaiCOaHSH+JCO74plKd2Vks3o2IDmvEBGd8wirzWThfoh3LzFd65Qr9E7o+iRsovrq3VTflR0XAsOUMm0VvgHjdq9mDZghp9DgAi38/JoDpzPY2qUtnfrFnfyndqHNK56Hrd UR7N7giX X2fBuANmgmMArcOj7c27MxIVyzLs9JdrJHzILlpqmaPS80wVld4c1T717cgMJV5YyJOyHxhZBhnKNGT0JfmaB4taMY0sdPZgpPs69eHqS1YO9DKlaA76nM8z79lw4eJvEdtTgZvz65gWS7vbcKZWHZ+fddiH439Ou80P3Di9tqfn7zc437K8fUftu+m8cXn+gfQUSDLFlPOwYFQU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 04:29:13PM +0100, Christoph Hellwig wrote: > On Wed, Mar 08, 2023 at 04:18:55PM +0100, Danilo Krummrich wrote: > > Consistency wise I think we should either also export mas_preallocate() or > > don't export the other ones either. > > Please send a patch to drop all unused exports. While that's usually a good rule, it just creates unnecessary friction in this kind of case -- a set of library functions which have only been introduced in the last few months. If they're still unused in a year, sure, let's get rid of the exports.