From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Danilo Krummrich <dakr@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
maple-tree@lists.infradead.org
Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate()
Date: Wed, 8 Mar 2023 17:43:48 +0000 [thread overview]
Message-ID: <ZAjJVNOkv/xL6GBC@casper.infradead.org> (raw)
In-Reply-To: <20230308152913.GA19628@lst.de>
On Wed, Mar 08, 2023 at 04:29:13PM +0100, Christoph Hellwig wrote:
> On Wed, Mar 08, 2023 at 04:18:55PM +0100, Danilo Krummrich wrote:
> > Consistency wise I think we should either also export mas_preallocate() or
> > don't export the other ones either.
>
> Please send a patch to drop all unused exports.
While that's usually a good rule, it just creates unnecessary friction
in this kind of case -- a set of library functions which have only been
introduced in the last few months. If they're still unused in a year,
sure, let's get rid of the exports.
prev parent reply other threads:[~2023-03-08 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 1:10 Danilo Krummrich
2023-03-02 1:52 ` Liam R. Howlett
2023-03-08 10:59 ` Vlastimil Babka
2023-03-08 14:34 ` Danilo Krummrich
2023-03-08 14:43 ` Christoph Hellwig
2023-03-08 15:18 ` Danilo Krummrich
2023-03-08 15:29 ` Christoph Hellwig
2023-03-08 17:43 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAjJVNOkv/xL6GBC@casper.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=dakr@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox