From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E14AC678D5 for ; Wed, 8 Mar 2023 17:40:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 950F5280003; Wed, 8 Mar 2023 12:40:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9011D280002; Wed, 8 Mar 2023 12:40:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C9D8280003; Wed, 8 Mar 2023 12:40:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6D6BA280002 for ; Wed, 8 Mar 2023 12:40:15 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 284EB160E38 for ; Wed, 8 Mar 2023 17:40:15 +0000 (UTC) X-FDA: 80546444790.15.9E460B2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf11.hostedemail.com (Postfix) with ESMTP id 191B54000E for ; Wed, 8 Mar 2023 17:40:11 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=TajgrPEo; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678297212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D9P/n6kZ5Q42EKXa8PVA9CYX9cXV/BCKYA1HMGowUvU=; b=nSTvVXRypoASRD1UhQveZgrv3rVuCyKyUgtpM8eANzkE+ZaqBfmcn68ZTBbkpxKeBa7xmz t0Djl2TN0t/u4hpnQsBnWHDhIVj5Ug89ObjzMKMfJTsvYhJbhKnz8fw367jw4sQ78yNUQs Vcv0yjlWxT07/2nXMRr4Mp+za6RL2Os= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=TajgrPEo; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678297212; a=rsa-sha256; cv=none; b=v2dCf+4UXyGAk0mAWT4vhJ3EvNyDMf3Na8udbLOGOr6XSTHoQslhTUH3MIs7nMXzygF2LP 1PvxOrGCMVm8heT2rCiA+5bFp2zVy18kG9blnWlpqTgO1uD/nz6WuNxg/s0cnJlLaBArAG wd23YHH3WT63zxDyqR4rrAr1l4UisK8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6C76D1F38A; Wed, 8 Mar 2023 17:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1678297210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D9P/n6kZ5Q42EKXa8PVA9CYX9cXV/BCKYA1HMGowUvU=; b=TajgrPEobbOD2m/LLJL6XBEDwW6tdq+0QP5iqSO+RuA2fAwvLYQ7gx7qQdHzR8kp+Li8gW 9TRsofHeCFFXiAmfGUiiyg/rm2bGogkP8mMs3B16HmVTvTDdZsbBy1NHcS+9xV4bZTXuNT 3moocNhZ6CmjPjO+4b2T7MJmH2Cla04= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4A8EE1348D; Wed, 8 Mar 2023 17:40:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Cg6uD3rICGSLWgAAMHmgww (envelope-from ); Wed, 08 Mar 2023 17:40:10 +0000 Date: Wed, 8 Mar 2023 18:40:09 +0100 From: Michal Hocko To: Yue Zhao Cc: akpm@linux-foundation.org, roman.gushchin@linux.dev, hannes@cmpxchg.org, shakeelb@google.com, muchun.song@linux.dev, willy@infradead.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, tangyeechou@gmail.com Subject: Re: [PATCH v3, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes Message-ID: References: <20230308162555.14195-1-findns94@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308162555.14195-1-findns94@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 191B54000E X-Rspam-User: X-Stat-Signature: 35nj37iqa3qfo68x5ndsee7o8mrnwosw X-HE-Tag: 1678297211-538478 X-HE-Meta: U2FsdGVkX1+52euTyEJi7N52svCFdxX6FRnsPSxNhiIkMrFS9QabRISEBjySBo4ZnzPwgzWImyMoeRwLeMwl/nnbBJ0EpiMmgP7jHR1kYa4yM+Ju6rUIYucvxRB8OsgsyqhAEFl1sUcyvHoYBuh6UYqJqyE7K7bYXNzqx8f9xfxG4uba1mKnUIgp5VfOidL8YOj9WQFtCkNy7Zg1Ep57saiAHg9Qnhci2MkyrcQETeD4SIj/lru9E4f16a6QNItFKqar6d5MPvSZMEnbkc40lOLvuXHTvCxRfF10VHze3PSwsKx61WExdBrTRCVOBLkC6FEv534+EdSJU05REkiUOkQ3xzLsk3J69TE9pXsrGhuP1QgvtV7ihhsdMzV1qhdZycC83Z00M1FPr1MmfY2p19TLX8DDNXToeEXFHrg/duLIUbe58+Veysv1StM3Bv4KKBwNy7vte5ifLa+M3JOAWOiXlJIyDchBNaYd3quHZ8bkVCiniKV9bzQOpPvwF06EbgeVph7UhKT0lcF255erNrNmZCkQxOcuQuVgLSaiuiFWq6O3TvFjMRTvnlIVn3hMs0aCorLBryi9OPyCutkliKr1VIwTeyAnt/Oqy60nYA7kjmSrP2zeRgN+WOXCNUtneav8eeAhoRfb/uDqJc3Yymr+D9jbtaMkvwgAMi7U2oOqn6ID0/yUA5DmzWiM2+jmFZFjaRGyCa+1FJQi8J30JPBzkIMz64oKzEvHqmSYCAeZil/Qq969wS8D1zVBIHuEZgXicz8I1HglVUX7WE/M/cL0ju9neYmHuz49yJ1XD5jsWcQ+g6x3seyjRAU/Lp8tjJIcHxIvTGHlaJueKNHo0YkPJUudCw0Ceg0loEKD/MRMRPqrf9sNP3Bn/ih0l5zoiT6Gh0Ryg8fieCv7wZyq5IOECVpL3fq87G/x2jbkOWsmG2p9cAtQvyrGPF3jQVZjaAlSMNB2t+GcCagFM27 xFfz7mZS Bx9cCY2e+7puvcl5w9XbfKaoRsNy34wSk+D0FOksspfqLgSVKNNbTeF2Wil7EB8RmkM44KYfLR/VnByKbotMC60QhHqYTO5I9vFyvxFbFspKH047j3EDjGKETErUJq8KDbIOtAXCua/O+8JQjYujAXqJXxporWX6Nyb/hUcoXdOS2sxL391C7VPWGK8L/gypQtFAnWwsyIz6ZIRE+eQ4FO5ptp5AqAv56UEycIZJiQw7WJIxxUHTR7lIE6bOfUNJfT4J2wIRG4EONNJs5U71su8W8pOliuC3Z8yH0sK/HAZycDMMV6Y4o/E8zyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 09-03-23 00:25:51, Yue Zhao wrote: > This patch series helps to prevent load/store tearing in > several cgroup knobs. > > As kindly pointed out by Michal Hocko, we should add > [WRITE|READ]_ONCE for all occurrences of memcg->oom_kill_disable, > memcg->swappiness and memcg->soft_limit. > > v3: > - Add [WRITE|READ]_ONCE for all occurrences of > memcg->oom_kill_disable, memcg->swappiness and memcg->soft_limit > v2: > - Rephrase changelog > - Add [WRITE|READ]_ONCE for memcg->oom_kill_disable, > memcg->swappiness, vm_swappiness and memcg->soft_limit > v1: > - Add [WRITE|READ]_ONCE for memcg->oom_group > > Past patches: > V2: https://lore.kernel.org/linux-mm/20230306154138.3775-1-findns94@gmail.com/ > V1: https://lore.kernel.org/linux-mm/20230220151638.1371-1-findns94@gmail.com/ > > Yue Zhao (4): > mm, memcg: Prevent memory.oom.group load/store tearing > mm, memcg: Prevent memory.swappiness load/store tearing > mm, memcg: Prevent memory.oom_control load/store tearing > mm, memcg: Prevent memory.soft_limit_in_bytes load/store tearing > > include/linux/swap.h | 8 ++++---- > mm/memcontrol.c | 30 +++++++++++++++--------------- > 2 files changed, 19 insertions(+), 19 deletions(-) Acked-by: Michal Hocko Btw. you could have preserved acks for patches you haven't changed from the previous version. -- Michal Hocko SUSE Labs