From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A27FC678D5 for ; Wed, 8 Mar 2023 14:45:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A985A280002; Wed, 8 Mar 2023 09:45:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4822280001; Wed, 8 Mar 2023 09:45:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90FD0280002; Wed, 8 Mar 2023 09:45:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8052D280001 for ; Wed, 8 Mar 2023 09:45:33 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4468B120AE1 for ; Wed, 8 Mar 2023 14:45:33 +0000 (UTC) X-FDA: 80546004546.07.ED37E1D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 94CD714002A for ; Wed, 8 Mar 2023 14:45:31 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=A0TwCcjI; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf09.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678286731; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xdbOGELCetVeStMbCiC4Ku4M/eZ4cIYaXf7RBFJHQd8=; b=yyNAt37bcn/V26G7HZM0mEkfC5pIT06azeVxgiSSUHohQH4tkGGT8cZu9Gxi9doKy4zkAw 0woIKw/R33/H5BVxzfPlc07ntiveW+qUlFUjcEIiCxOn6ybotc6DnEvhC6idz7VFmndiqm 3E+/pS34bSijb7lZb/cH6CrqSVNnEdA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=A0TwCcjI; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf09.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678286731; a=rsa-sha256; cv=none; b=Rl+8dlVEY0YYj885+XUFRwHdhGFkEX3MLG/+P9/1VrH33LjOQhqa6tqG2DCfOuidKHKGDh 3usP+L6nkWQo/hM/IhJ1pQRMl1k0i3pLHTBA39mtAPED+WlT95IySL1xad17V6F7cAVQgj WCwcpuXbtmjCTISSjWBbvIyUtw3B370= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 96F316182F; Wed, 8 Mar 2023 14:45:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C264C433EF; Wed, 8 Mar 2023 14:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678286730; bh=T9rmEZSCstrpxbVIO9IfutlDiKqctKr2IUk/L/EZRy8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A0TwCcjIHISY7YEHL1oBFUkmv9xxkJsBzo4sI2g4wSeD1Giu6wg4MT9fVl74LEeO1 uQ6AzS5S0cyhWkyA0PnqKi4EqU7tqDekPlpy8Sc6gJ9SZCfVe3dWu0GC1lb65WzZfg jRxtfa+QXkGmJEGl7vasp9bJrkyESAprLPYpm680= Date: Wed, 8 Mar 2023 15:45:27 +0100 From: Greg Kroah-Hartman To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard , Miklos Szeredi , Arnd Bergmann Subject: Re: [PATCH v16 05/13] tty, proc, kernfs, random: Use direct_splice_read() Message-ID: References: <20230308143754.1976726-1-dhowells@redhat.com> <20230308143754.1976726-6-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230308143754.1976726-6-dhowells@redhat.com> X-Rspamd-Queue-Id: 94CD714002A X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 4d9gw7c3jjzfzrnqacuutusakjcjpczu X-HE-Tag: 1678286731-913314 X-HE-Meta: U2FsdGVkX1/J9/0WHvC9KVAAnRNf4C0pSCoUNvd3qLlrp205qsjyQBxKKjd/3m3Km1mPWMJBfo2AhOZMkURPk8j5m7ERPgIYFhyuAI4XjNVo455vPtnkKVpqZjBAIRV+HcRNkqWfYfbiN6OpUXzHr48W+L7g7sJdQAN0gQSEgtapxpBmIF+I1aesOdyGnrPmKfSEz4Gf9n3+MPCB0dCY0K/0dohN1HGseqbKeWwqnWR3rVBD9m4CC/9wm+/S+fzBT9tN+MU2WT+7hoy/IkW28DR8hL23Bd95iFGIS1msMGz3Q8ugDQgKPSUvOgefdFobfZK23AEASYpNCQ4/4Wq8+RZQtLrxeUiw/c18FsxSdYKzn554hPtfdndq8LVfQaHwwRMa1p2jPqi5boRNxEvrJH5OucWSkS4ax7qorjBA+PJcDuGrlw/vwK5JCecimDAOV0lDQj6YDbap8tmjUkKej0tKUC414jAx6OLhFNPxuMFj9aPMweUg6UZ43M0KYSujqxcE+J8XoGXL9bktpWwid55uxiq+05e848rT4MeBec2bGhHuBP6MkBIv6qCO2dHeAPeIUKRuUA1nHH44/WpJk/okvKldag/gy6O4XJLNUjvtXFURnoMWvxbJRig/c2li8dX5AdltiYTzqxg/GY0HpaIry9hxKRQ0FybfgqWU0zfg/JgOBkCYL8J7iNA0fye4+/5WK/bG/NszXZbDP0l7+eLuODjsTGMM9SoRU9EjGwJAoBue+2y0GZrUJvIu08IUkJBCq3aBU3LauDXXHtkPw9O1RuSjKmwB55GIFWFk7zja08/2KA1AfmHJ8xpwuufdvdna1XuvbgUqyIWt3lnFHF16xF0xg9zflddU2yBDipPl2o70QVlVPUY8BNUqAPMl+tcJznJwsBx53H2wmm8IiN/esZX+tIWy484TI615AoA929mGSOtk+HHzj5K+JZE0cPUTPwuLmJpjOVhbtRh +rSpdCnF toOSR6Gmt/WAktgrVeiy2mGfdBNn/ufFOesfwd8bfS4gLwSHFgULYJXzTZgVZ55RMKkaeL/RXOrVHhfULP1Gfygljp0RZEZUimHCNo5Ueo1U5cYzgvyVLo/MZXxzIOJ7lX0dr1wZkPfYqnMnuGvPlYjIZOoTf52iUueyvONr6qBAY/VmeQWXfvvyHM4VxqDF7NwJlDXRmczlseYza7WXyVe0SyHRAj6IG4Rmf6DwJr/n1B7yPEd9Kzg6xjXUe9dwbBAF45Dujv3ebdqIWLGzBCeWUJ9NxBoZWlLrZGlV3PN1Y5B5Db3L6D2biQD9sQBBWZIPNEQSqY2xOmI/lEYccxCi4j6JZwie/+1IeljRULHhZ+aKn8Dt9Jh9kCNHE4AC+UdQuCP2iZQCv1crdXizsv3VM5iLIn0vxO2i2kQfCbvdMG7zEMbN25Qb8VbYPKsAKgKLh7z0uApweIic7azzWTLRU52Cp3nCHkVOteoT/Z0PnJ/ZznhS0qyMNfsusOiXoajbpeVBhke3MWiA19c0whzJQiUcxLFjJqWwRhQybWRFanTZYjGGub9N5XDHGSEqBm35QWhZo7Qll7Dac6f84tlkNxKQbqZhzvQMAHQPgcdeVLWK7rvcX7NHLK27QyTbJXlSICxhYRDkumIhTpAfAymPmOxKoni771M9VKunCMqDKSGc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 02:37:46PM +0000, David Howells wrote: > Use direct_splice_read() for tty, procfs, kernfs and random files rather > than going through generic_file_splice_read() as they just copy the file > into the output buffer and don't splice pages. This avoids the need for > them to have a ->read_folio() to satisfy filemap_splice_read(). > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Jens Axboe > cc: Al Viro > cc: John Hubbard > cc: David Hildenbrand > cc: Matthew Wilcox > cc: Miklos Szeredi > cc: Arnd Bergmann > cc: Greg Kroah-Hartman > cc: linux-block@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org Acked-by: Greg Kroah-Hartman