From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 384D2C64EC4 for ; Wed, 8 Mar 2023 14:00:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A978280003; Wed, 8 Mar 2023 09:00:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 959AB280001; Wed, 8 Mar 2023 09:00:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D55F280003; Wed, 8 Mar 2023 09:00:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6AD55280001 for ; Wed, 8 Mar 2023 09:00:09 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B04A01C67CF for ; Wed, 8 Mar 2023 14:00:08 +0000 (UTC) X-FDA: 80545890096.02.FDE9B3C Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf07.hostedemail.com (Postfix) with ESMTP id A4BA940018 for ; Wed, 8 Mar 2023 14:00:06 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=THbWYOEz; spf=pass (imf07.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678284006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ijCIwYAPHXH0JJ+XDQYDNj+O+tMouNaBIO9o2nVcDs8=; b=ONPEAB1YoKcoCMW2YODujMJyqAKcwPS27o/RyVpMz4UAzWs/G67OhY/o9gH47r+1Qdg6fL Dlj95CDIAtzN1+DivBOk+VB3L2eBNp6274oAqAyruxHk2tVJYBUUpzvsbWrX/BJm8g8YUa 6438DbgxK+HK9K9DNTL6gMunPK5zfa8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=THbWYOEz; spf=pass (imf07.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678284006; a=rsa-sha256; cv=none; b=yCqeCcdYCY6SHYc6bzukLkx1YhFqV7hY/Bo9amEplJ6W6T6QngoCooURLH69aAdeLFnLJV Zs5XUD9dDw3XWhBnG4WKzdfFI/QmxLASK9YW4bAUcnT8REbFAersYMMa2LD7GswijOAvZN w/QhVCHaNyXTrEGbdas5bsSHMm4pBqU= Received: by mail-wm1-f48.google.com with SMTP id p16so9854742wmq.5 for ; Wed, 08 Mar 2023 06:00:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678284005; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ijCIwYAPHXH0JJ+XDQYDNj+O+tMouNaBIO9o2nVcDs8=; b=THbWYOEzoZY1Wq+Hj1c1Z23EGHOERcBr1xS1UYnd58sZJTcj65wRsmdBIpATJ5ZEvi 2UAVbYzzXm/CbuXOWd3xUzPdspNUTbXiSmWUcIwdZf2tJHwERpph/iO374/hLyv3thOL SvK0uufuL6YupsR1/whQEb7+NQ4S1vJHyWn8V2qwBJ20rF0EKy9Y95Grl+3dP2JnFPaW 7T1p14NXqyYLqGuXhvElEuCQL3j5gA9Lj0e29CuyX1XJSUA634hNOPRicebRONgNJPKX XyBpPzpprlp6ybWCSiTz/Mvf2CyQwxL4FwnnBzp/yTsbvD5CHU4WFnECZPlcfwOfiowB hJYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678284005; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ijCIwYAPHXH0JJ+XDQYDNj+O+tMouNaBIO9o2nVcDs8=; b=1u6sJhLMhoG625Xg6B629XJtyrHK+6/RsTUQub6ggrfF9aRuRM+63xhd/6mHlavZhG nxI6Zi9VBMDMiD69Ufn85s7jUFUSvdPcI6ZfP/MiQXH5vzGF32WnvzJrzabTu4T0CqgD ro7OK3huyc+VZAMofBmlk3neMEN3WNsT3/9QDODuNa7xRoOQuFmqCGLUodM489Z4z3Dl v7a1kmfHsjIs9aSXiIo2R05vyN5H7rNZ8gShrZiNcclr0WKHUHwbH6wdkghM4LGdiDRf /FqvGkr+SScKByK1/LHHuSnjYF3ReVaAFV9b+E5mnkm5s1JVdhaCNLDBT1YlTOyqOs1n cn9Q== X-Gm-Message-State: AO0yUKXNeaSIm7TVkwo0RHeNHWsD133MIqdtOz3e6VndSrtd38FI7+d+ T/WS9ndWTVPH12fNoZySk/g= X-Google-Smtp-Source: AK7set/vn8OmbYpYQOF2rZW6B03lZoH7qD0Ni12/ue2KmXWMbAqnSzbBF1zwnu0kRzByWKofxqOH9A== X-Received: by 2002:a05:600c:4fc5:b0:3e2:1f63:4beb with SMTP id o5-20020a05600c4fc500b003e21f634bebmr16964014wmq.19.1678284005129; Wed, 08 Mar 2023 06:00:05 -0800 (PST) Received: from krava (2001-1ae9-1c2-4c00-726e-c10f-8833-ff22.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:726e:c10f:8833:ff22]) by smtp.gmail.com with ESMTPSA id q8-20020a05600c46c800b003e7f1086660sm21557344wmo.15.2023.03.08.06.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 06:00:04 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Wed, 8 Mar 2023 15:00:02 +0100 To: Andrii Nakryiko Cc: Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Matthew Wilcox , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann , Namhyung Kim Subject: Re: [PATCH RFC v2 bpf-next 9/9] selftests/bpf: Add iter_task_vma_buildid test Message-ID: References: <20230228093206.821563-1-jolsa@kernel.org> <20230228093206.821563-10-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A4BA940018 X-Rspam-User: X-Stat-Signature: weoxepnzzqse3cwk6e83cfwub1nhgc5g X-HE-Tag: 1678284006-165825 X-HE-Meta: U2FsdGVkX19NxCfedQ4fihztISjqpReZQk03q+kMkyQ4N1eFl2YxoGKmbn+uZTQUNj9BDssX6gF9aouHYEaCnfgkzT8KEqlFnwt9ti0ccRYv0mt8qwLs5UFzqdwb5ipaOWD3gUXlDPuTeGPsU9WVtnLpVD9LLad5tkSyNysZZd30ohEfDxvHJ6d9m+6AV6Kaw6aodnVkdxUVUzOkCdODj1EbXWYs/psi0guvR4D6Coy0ENv5jIMlTK3NfDPDqgS3LZFtJ7BBavtEiUxp5uacl4Ui8+YBI3riJIiJVoICsnbDU+VHuMJIKI33wxzZMllqI9oBbrwCH35E6vlA5ejNdWgBLMIghu20Qh9HCuyrfbquI7dLDrdXzsxs3B2IsCPKj6FXNONw+8L3NKFsozpK3Rua7xwaSD5TNJnu5BTdh0i585GAV3uHsPq/uSxH7Ix7A0BoBWE5uF9tLRsH8zBYv9vs3A74U7XXuJ1HowDySnGfTNBLlDFhly0m75iSUB4LAgRdcIrUyeeo8RWOjhlmpSwyMmXA0wdZLJ++NPUvezgBOfsOIpU+raVgSYVmTiSEbarNpVldw0xgTc5+7SNuUZ3oQNBahVGhDyBk8Cnboy+WzXqYcE8r/N5QfriKtSHkhg5CHlxoUXilk+hI2W37tSLYbWPeMv5+p+QXlfZj4LwHXODG/0xpSgmGhsaLTuQQy0OepEGfAapKtZqhc4k965a8Djlls2J9wLOFPFh8vzX2ra7rgvVJ8aVQcDBbV6j+kilRDcwhmC7mk7H3e7H5Xd4SNaMZJRzzmD82IDzJRb0VKhnCyVCchGhSOJTunxTvpEhFQ+t2hX60GU+Ls/+U+bLFc/UyZyv/c2JztteGDQ42mu/8e79tucHF26hjzvoP0Zc/eyJueihg9pP8+Xg9W+4tUP78KWKUUlAHa7LjxLG/hYASQcSO+zGVOAV9cp5iEmSP4vRRn6S0YRZKn0J ZgSVWWG1 KLj/yB1D4eomZE/7g4shNL+lpnN15gI+jd2Px8W9YOLZi2BX8sozZOiCft7+FtcWBCKuAgoCatN0cOAa4I09I6LblSAm66NIehruOgTscN80GwRyYsyRFAtWY7gSh/gOeNUjs9jx3HnkP1IVZkW/eb7IOUpFYZoBoN/UeR2ewgaRcoj0r+xtRyokRiHwuXF06Df9Q3vpCUHx4w8IgNONu/F90eH/PSdaJXIVgUHhtFGhU/6OdLykTz3IB1wTUrOcZAEx7lusAFqpMhd02qzvTslA+Qvts9TdwnQWCWfvgNs9wAvT8QRyrmwkogUSnLUMxlLD5Q7TBgzeNX7NeD2NyxHbyZJPlpw4T1DSqhlc+9ayC7fDXKQozK1X3531UH52BzXoc4FainIeNviJ59tcCBIcYp9HtnKLDutx8ohfkGqvXmDXjzHrX1yZr96hkUG3jRExKGM6wRfKhpmFXQUrOE1MZQKw+3UGGGmt+CKysmP1UMP5b3oZ0H3PEkbEycW1vSiHL2arJPrQNGV7jVIwifwWH7zu/mfB0MWEEWLqrgWtn8cI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 07, 2023 at 05:32:17PM -0800, Andrii Nakryiko wrote: SNIP > > diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c b/tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c > > new file mode 100644 > > index 000000000000..dc528a4783ec > > --- /dev/null > > +++ b/tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c > > @@ -0,0 +1,60 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#include "bpf_iter.h" > > +#include "err.h" > > +#include > > +#include > > + > > +char _license[] SEC("license") = "GPL"; > > + > > +#define VM_EXEC 0x00000004 > > +#define D_PATH_BUF_SIZE 1024 > > + > > +struct { > > + __uint(type, BPF_MAP_TYPE_HASH); > > + __uint(max_entries, 10000); > > + __type(key, char[D_PATH_BUF_SIZE]); > > + __type(value, struct build_id); > > +} files SEC(".maps"); > > + > > +static char path[D_PATH_BUF_SIZE]; > > +static struct build_id build_id; > > + > > +SEC("iter/task_vma") > > +int proc_maps(struct bpf_iter__task_vma *ctx) > > +{ > > + struct vm_area_struct *vma = ctx->vma; > > + struct seq_file *seq = ctx->meta->seq; > > + struct task_struct *task = ctx->task; > > + unsigned long file_key; > > + struct inode *inode; > > + struct file *file; > > + > > + if (task == (void *)0 || vma == (void *)0) > > + return 0; > > + > > + if (!(vma->vm_flags & VM_EXEC)) > > + return 0; > > + > > + file = vma->vm_file; > > + if (!file) > > + return 0; > > + > > + __builtin_memset(path, 0x0, D_PATH_BUF_SIZE); > > + bpf_d_path(&file->f_path, (char *) &path, D_PATH_BUF_SIZE); > > + > > + if (bpf_map_lookup_elem(&files, &path)) > > + return 0; > > + > > + inode = file->f_inode; > > + if (IS_ERR_OR_NULL(inode->i_build_id)) { > > + /* On error return empty build id. */ > > + __builtin_memset(&build_id.data, 0x0, sizeof(build_id.data)); > > + build_id.sz = 20; > > let's replace `#define BUILD_ID_SIZE_MAX 20` in > include/linux/buildid.h with `enum { BUILD_ID_SIZE_MAX = 20 };`. This > will "expose" this constant into BTF and thus vmlinux.h, so we won't > have to hard-code anything. BPF users would be grateful as well. > > No downsides of doing this. ok works nicely.. thanks jirka