From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70561C64EC4 for ; Wed, 8 Mar 2023 13:48:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC00A6B0072; Wed, 8 Mar 2023 08:48:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C705B280001; Wed, 8 Mar 2023 08:48:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B381D6B0075; Wed, 8 Mar 2023 08:48:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A52016B0072 for ; Wed, 8 Mar 2023 08:48:21 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7AF0C120FA1 for ; Wed, 8 Mar 2023 13:48:21 +0000 (UTC) X-FDA: 80545860402.28.ADEAC03 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf22.hostedemail.com (Postfix) with ESMTP id 615ADC0006 for ; Wed, 8 Mar 2023 13:48:19 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=N6PvQAEn; spf=pass (imf22.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678283299; a=rsa-sha256; cv=none; b=17x6/dPtbDe0QIAQwzeMfLRrhRLDF8mr/h2/2CQYnKcikk3YUJ55D+5SmtzBLEhZG6DImV hE2YGKPAGL8npFi7NsKsXN6ymL9OvggdM8QnGMOHZvb/CM+hfArxsY3YHuVnDTuYtkYL8W DMlYGANy4fdu2iIXMCQ20sDo9G/6BbQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=N6PvQAEn; spf=pass (imf22.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678283299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Eeukihki09mFh5Tgwwz3g9D7DAvSgW843JlsCSZBqvk=; b=bbKeo+JlfESD2NbONjWO+trNMsG+rvsXfquao+uJysBuDXyzDQUwkdEDXf8mNgvIrQyY4e EfXIE9q3zjOI4mpW1j/zu9H/Jq/2w7rr5TI/7Hf6aU4EaPS0bjfr9o3lstRH+5Twt77cIe J9BrTGIkn30LtuCXSLaRbY26FuTqmRk= Received: by mail-wm1-f47.google.com with SMTP id ay29-20020a05600c1e1d00b003e9f4c2b623so1332630wmb.3 for ; Wed, 08 Mar 2023 05:48:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678283298; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=Eeukihki09mFh5Tgwwz3g9D7DAvSgW843JlsCSZBqvk=; b=N6PvQAEn37lp58tqEPw/ABQMH1wD1koV7wrbUPpnxRk+Sw04kEs6b9mcewq487BZvS PPaEBWGf1G5xLhSxWV4/X7+HtFJcv13hPo/rYRpCjziAPtmnE3GZmFT8/xVmenaiK5mW 21ZxVtBXxlUENvU6CpfiuF7Hsp7mRtAlOLobIk5HQd0m+SC6ixIlYOLs7qMBR3cJccvd AGyKhw3sRypwGqwqnUWHWa0ZOOeG5S/1dctzOpxoPqECmisHQq8Aj0Ro5WFmQZSC27iV Rqxd0E7GQYwcanuyp3aHwk8SMieQT+rp3DFfcAIMebesejcH4X07a05WQLUX0rfTPzMk nhHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678283298; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Eeukihki09mFh5Tgwwz3g9D7DAvSgW843JlsCSZBqvk=; b=s/c7MmFMiP07BWUdabaHuWLAFxIdFACT7uk9WOqQW/N1j2jAIApyGOiFgD1ffzXjaj KK2jklafofU0dUrzXKAXK3YlBIaU/2jGhREhaUfAQffNT1Z0/CiHs0jGIu5PfKGd6NM0 vOk3WoXPyfBRI42jz8GHxA7Ku60r8TAHtwgIGagWFV1sqdKqCM75Q81US7humxRptML8 X18B9Land+s9rSOqNA9FldFrQP8yIR2wjGNqxtu0l6OGIWU2vvtN6lQeWjG+Q5mKfYer tKQHAoeZXpXCnSa+HUGVnDIozxy2pAZwgS1sxAprUQQTA3PQNc2Rch+YyRjUUm271dsc nN7A== X-Gm-Message-State: AO0yUKWDs4qOIRQecXVFwCTkDj6pZ+9v5lqntgm/gJfrR908LuwMW7R+ ZEgninI0WVvsv7r/ofjmoFw= X-Google-Smtp-Source: AK7set/We+21S7n72POqTKt6ngyQSPmSgUn7r5KwmhLXABqmHks8nzQ0ne3JyfD77aWaHXBj99vHNA== X-Received: by 2002:a05:600c:1c96:b0:3ea:f6c4:5f3d with SMTP id k22-20020a05600c1c9600b003eaf6c45f3dmr15837479wms.2.1678283297706; Wed, 08 Mar 2023 05:48:17 -0800 (PST) Received: from krava (2001-1ae9-1c2-4c00-726e-c10f-8833-ff22.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:726e:c10f:8833:ff22]) by smtp.gmail.com with ESMTPSA id 16-20020a05600c229000b003eb2e33f327sm2220186wmf.2.2023.03.08.05.48.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 05:48:17 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Wed, 8 Mar 2023 14:48:14 +0100 To: Andrii Nakryiko Cc: Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Matthew Wilcox , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann , Namhyung Kim Subject: Re: [PATCH RFC v2 bpf-next 4/9] libbpf: Allow to resolve binary path in current directory Message-ID: References: <20230228093206.821563-1-jolsa@kernel.org> <20230228093206.821563-5-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 615ADC0006 X-Rspamd-Server: rspam01 X-Stat-Signature: cmn9zuic3dbuo7ebeeahs3iux9uz15z6 X-HE-Tag: 1678283299-633015 X-HE-Meta: U2FsdGVkX18wN2hzhrZuGbf4PSbAy88gpJGjnfVjastJ8kVxe/hvvqWLssFr94KeBZO4TzGALMMKrS1BLjfqLYC2M7gYyeIharDPZaOUsKyGTXuxOYVAY1k8lrS9z62v6Y2N+vsi+pvw625wIhs1BX1kbucM5xRkmKiEF/Ub/+Xd43BIR79YwmAUSslIZ7Fmm5PIQ2Zg5LsBBkSFkFGf7G476JTtMNzOwlF/6Yhos+vF5AlH/Xvgl95sltPzLtuKB42wVkp/CoXmkBagVuhiI4u8hz1Od7EDz1YVrhk2DMug0H2aE4W/MdCYZpISP6tTTeUYValZt2gf0mnBm35swZah08bxOgRf3RnH/JnnThSlICRvxpWlzVWyGS2pfESLynK2hudRjufGrcLoJH/A1mYc/exQYs4UNTft0hV3mOrvoj8gbQH0ti5v69bq3a5GGcm1daYa57Jk9yfXC5YKmJ9H6cIo7lMvTEuBqhfS4+jo/jUk+u4NQdyyeIfi5TMB5ywtJLtCeS+TwIESErtEkO7msDXjUn0P8dQHWesEkWl6USzFnGZv/1v7/Y8ib2dKj0uGXCaUdzECTBXynQAy0kcMpKod90e/RWdxlWOWOfpJVDdwnrwVhlI7HIQ/OO4LfcVni4uRjYM7Cj+O+Qjz9zpsYJw0UVoRKc0H9RgC+FP37InuoGX2/4eBCttjlydecvmACT6EX8Q4IfFon6RSavEXHwYBCJTsGRM1gsaLWqzliTHdsd4ODydrzwMLY9pPhal06FXNUCUd5roKqC5bOHxkQml/ovBFCZmygzYuutsjwLFlqzxhvdxpQLE8tWzLWu/49IcWFVRveYfk5qOULuiDoYPB7pexhtGC+JIMWoX/qGN2R0U5Jc7KjMaMS0GRSRFqwA+dAb+tA6ZupIeQ/VJ5DUVwG1thQeY4EiJ2uYGpe7PKJhIUJW4QOkTRbk+hIqt9e2FWa+QFBOtus1W MLtpT1H+ DaEPmEvJ9d/NhFbR468QenfDhoxvmXuYTnCqMTZaqt5dHl9qjQON1xb5Ub6KUCFd58lRR4MpT3Yqn1w/eMtbv7gPXAWC9mmzNZwEL43Pfnkhyl2lQlrQ19rgp4686DDzY2Z4yOpgz159iGXiDXs7bavwS/3ERYPIhKgpN5qzuLWm7SyjjzA/ILE7CCCvM1y3cY5I/8lfjThXQrCQozLNW3MSn5nRJeFLZ6nhAiIQGaHUAC94DvHjsY+HlXbeQ2op6OdIwUhg9rx57XLWfBA1tQIkEasgrk38WrIcynjTX7OWfJeK5nCmAPXdVQ0MmAjypuC0nIXIdc3THFu9u3Y1XwgXfjHymBG6Xhlw2GjTRLA7na/uQ92xOfgayZoxOqEcMWJmEAdRmBFU8npWiO7X/MTbcav7GuSLf48mqLKSQlRR68nM+Ygvq4ggCTmgzO+320PGDEHn5Lj/c6pGwb6TLJ9Uv3zIHmsg+eJtDUcp/AjLc8ZKDp4gnI17JfYlSHVHdH0NN1EFZciJXjc3l72fHnSI4cT6hVoHMgOdoftNsYDedKZ1VjsDPKj4q5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 07, 2023 at 05:19:00PM -0800, Andrii Nakryiko wrote: > On Tue, Feb 28, 2023 at 1:33 AM Jiri Olsa wrote: > > > > Try to resolve uprobe/usdt binary path also in current directory, > > it's used in the test code in following changes. > > nope, that's not what shell is doing, so let's not invent new rules > here. If some tests need something like that, utilize LD_LIBRARY_PATH > or even better just specify './library.so' ok, that fixed that: SEC("uprobe/./liburandom_read.so:urandlib_read_without_sema") thanks, jirka > > > > > Signed-off-by: Jiri Olsa > > --- > > tools/lib/bpf/libbpf.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > > index 05c4db355f28..f72115e8b7f9 100644 > > --- a/tools/lib/bpf/libbpf.c > > +++ b/tools/lib/bpf/libbpf.c > > @@ -10727,17 +10727,19 @@ static const char *arch_specific_lib_paths(void) > > /* Get full path to program/shared library. */ > > static int resolve_full_path(const char *file, char *result, size_t result_sz) > > { > > - const char *search_paths[3] = {}; > > + const char *search_paths[4] = {}; > > int i, perm; > > > > if (str_has_sfx(file, ".so") || strstr(file, ".so.")) { > > search_paths[0] = getenv("LD_LIBRARY_PATH"); > > search_paths[1] = "/usr/lib64:/usr/lib"; > > search_paths[2] = arch_specific_lib_paths(); > > + search_paths[3] = "."; > > perm = R_OK; > > } else { > > search_paths[0] = getenv("PATH"); > > search_paths[1] = "/usr/bin:/usr/sbin"; > > + search_paths[2] = "."; > > perm = R_OK | X_OK; > > } > > > > -- > > 2.39.2 > >