From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDFEBC678D5 for ; Wed, 8 Mar 2023 16:51:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63FA76B0075; Wed, 8 Mar 2023 11:51:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EFCA280001; Wed, 8 Mar 2023 11:51:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B7486B007B; Wed, 8 Mar 2023 11:51:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 39EB76B0075 for ; Wed, 8 Mar 2023 11:51:12 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 06D86405DC for ; Wed, 8 Mar 2023 16:51:12 +0000 (UTC) X-FDA: 80546321184.04.0974301 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id CCBD514001E for ; Wed, 8 Mar 2023 16:51:09 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=go6VlOZH; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678294269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yT+uvg/1uzwHRYdkyNG5W1yFDAXCvqMwEPbXMy2/b9M=; b=k1U7S7iNH89ORlS5tC2uTvmRwfJpwuqwe6/kf630vkmVveJUmXekzZU/Rm6RzAbWoDVmbK /zgdQjaAe/eV6+bn+EGXWb0YKvgLJEB/jTwXGye/ELbIEp0q315MzOGm0Y/myokYZKunHn UNuECuHFRcrvfA+t0Ni+cNWEib9n6WI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=go6VlOZH; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678294269; a=rsa-sha256; cv=none; b=PkFCF7wSk8Rp4WP2yQhAtklOY6I6zlyNtM7yJHkZpQ6FOVz9Q8WAj8jjPDtHboHqJEThLk A0jFCk2e2rvvhC90iG95x0NGDBiTGC6h69eyPjr8H+dRn+yAZPdnfUdoACY3Kk5FNUPK23 hK6u7npSuaaUf2dsdaZv5EMc7vyRgZM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678294269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yT+uvg/1uzwHRYdkyNG5W1yFDAXCvqMwEPbXMy2/b9M=; b=go6VlOZH2iK6VZyKuTr5nr8owmetR5Rwpp4Cwke4Nsz4tunw03WIMFoYXzRPsRK6rhBC6A zUDid3n/PblgtiKZDwlQOLFDhH3hg9re4TH6DN0iHpJ2brbtrP5Q6nIf2BLNIfnL61jaV1 2CSKhqp6ZbB9Z6upM7u5/zNMJ90bY6E= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-hw-RLTizOOKGObb89e4Zxg-1; Wed, 08 Mar 2023 11:51:07 -0500 X-MC-Unique: hw-RLTizOOKGObb89e4Zxg-1 Received: by mail-qt1-f197.google.com with SMTP id o10-20020a05622a138a00b003bfdabf3b89so9474559qtk.13 for ; Wed, 08 Mar 2023 08:51:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678294267; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yT+uvg/1uzwHRYdkyNG5W1yFDAXCvqMwEPbXMy2/b9M=; b=qTRMf9eXJN88Cq9UQFAd47cxeUwe0K5zhViwKYoy8NCD9aEwY6CvlrUGIM0CGtqx33 StzVDaf2zZrKcwVmGsY0qoaExCIY+SKFXfZ45QaNozKr+R/+we5j9Vs5w+0EdNa6tYTG VRHcrFah2nSp6oR/mifOxpUltN4WzPdfVqN50rcvZ5qdFVzYCJS2I0qVFvohhfuiXOmd lyxYmsKtXDmZH/5QKasBTOhAdpxeDwju4xsT9SGipXTHYQ+N9nYGX+iNBRn4YrkIqytJ RJQBJOdQjFfKeabDsfIpnIT/4p9cJQHUXayROBMmct/s8Jze0VmJhQQulpz+qg/nALM9 69Pg== X-Gm-Message-State: AO0yUKXhuqsTrI44n4oN0sDRCneRfVoYg5xHzVYSqrGZo9XC2ZgIWPc9 lWnifJJSp7VpEDV640yJHJytyx4NZ0qRZTe5ZMzS0d9kTNfUEXVctpidGKHZiA42EsK/wXkJUmc 9cYFmmxmVwGU= X-Received: by 2002:a05:622a:1307:b0:3c0:3d68:5411 with SMTP id v7-20020a05622a130700b003c03d685411mr10265958qtk.4.1678294266858; Wed, 08 Mar 2023 08:51:06 -0800 (PST) X-Google-Smtp-Source: AK7set8jreSNkM94Fnw3qoxwWDWIjuaicOKY9mQaYLL/60bWJWLnhflCSjRVYro+sDVPVvrVDDqVdw== X-Received: by 2002:a05:622a:1307:b0:3c0:3d68:5411 with SMTP id v7-20020a05622a130700b003c03d685411mr10265925qtk.4.1678294266578; Wed, 08 Mar 2023 08:51:06 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id x184-20020a3763c1000000b00738e8e81dc9sm10932512qkb.75.2023.03.08.08.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 08:51:05 -0800 (PST) Date: Wed, 8 Mar 2023 11:51:04 -0500 From: Peter Xu To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muhammad Usama Anjum , Andrea Arcangeli , Axel Rasmussen , Mike Rapoport , Nadav Amit , Paul Gofman , Andrew Morton Subject: Re: [PATCH v3 1/2] mm/uffd: UFFD_FEATURE_WP_UNPOPULATED Message-ID: References: <20230306213925.617814-1-peterx@redhat.com> <20230306213925.617814-2-peterx@redhat.com> <94be7b9f-c33e-c6dc-4132-6cb78f7c0624@redhat.com> <83b3f3ad-19a2-3737-77dd-3c3f9db82194@redhat.com> MIME-Version: 1.0 In-Reply-To: <83b3f3ad-19a2-3737-77dd-3c3f9db82194@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CCBD514001E X-Rspam-User: X-Stat-Signature: 6q6xc4t843nnwcr4h51s9wm4hh1g4tj6 X-HE-Tag: 1678294269-692830 X-HE-Meta: U2FsdGVkX1/BqjHfOTFe5OSxD4zqtbEZkkNgmaaDWQ+7KItD2mDVIGIWXgXpMxPvaPs2lj2klWms9k94g5/JN0Ve+kkiKk3dePrX5NKbOHbbLNNPYOUGarooau8xrV4RyX0M+KF9y+nkh+Vy3gUJjK2r2rFTUlceqfNFT502WH56cfaxyO33VAJLTVeiavLyQM7nbiCa4KLC4elbrlFWhg4ONcNm8rrTPTAq20OwoFwk2ol06YEbiNuhGPh92LbStqkmdAVOLseRVmRNI7aCXqIg3PWqNls4YzA7zPIpZnIaRYNvUyPF+BI9EUg4X+29y+PBzTuR+1lQAiUY2KFbC5kGZ7nq+tM1doZP7OTY0UTnkQVRu0sqpd2o8mmZb846aMnU3FI5R7tF5PSIkqyimTwt0wLuwfIa4Clg3YHAReL/OXwikMdrWzrTu8p5AAtV3L+EU2E5rrlv5Lm9Cm//NOeG9kf8XRI2qjZyawnRELxHg9+zA3a5ddMraAcd4Z61R5ZqpHxxCp0LbOeCWmj3SXPu/t+htxcufMO2oV1nI5lWeE9/O8T20UNHJHO0s9znoOMZc8nun0jeeHuYey8pqdw+Ac6CB5Nr2wzzs9/eWAXaWpKhdAdhFjTRApId/4DPTCgg13Xz1UOJnV29IyQFEs0F9YgPHiwMKVCFFQMmhq3jl2Ohvu9gOZksggr9QhTCHQ6stTSJ1/BIqsza7TWJsaaQb/dBv2hOpbQbJxaPoraXeu0pmsJKRCvgcWtP2nTcSEBCF0rhN+Z1H29XlG48BP5NvGsqsO23a3MhpnuD35Kp/+tP0Sllhpx2y/zo54nko0MlKOUAc/KLqKGQEKu3+OvkcufNHuYfc6WlTGlu3zzopUP3LUl114sgp9okLHpfRHpcoj4RcbIvWh/843E6vMjurpeL8OBYfByH2gOmw4mFUlTeweOyDzATJS0r+UAoweDxRoeHu58gHWqhgL8 uFPxWsTq jXzyyzMmz0E/Ad0mhU+DZWliYMBig7E1V3z9pdCHel7beF/mO604erjA/2Mey+X7BNVpkFWl2JfulZNp+1RLXKZwqh/0fkqfTZqVLlDHP9y5Sl5WM3hOx6YXwD87ocGWHhb+k1aMLLqNshVyaSQI0gxhfqKiT4CGPVZwz0BrIFLvQ4mXIe0uoJzcODRRd4+4hO1iJ/KrzZn9ICEOMtEXZhC6Jv6+/HekaLkCrecAes1TbIgyLoJ079lrnLZVHALc/K3BjzfHJhgI/JcVxNTXdpx5P2hjabi/d2eegML22aTmuRiwWDsy3h+ZcWh6eKmX2XSw7SqhDrrdf/PIjNwBGU6LJoStOTe4H/PT79iIZImZFtytXSXAF2deU9wdFyfliM3Z8UXEjwDo40umKB64kTqn392izOvxmRhl9x/shqlr0LR4EpAmtlhvlTabeyOU8oV2co6L+uYmHoUUmMRAn1nj9yKUzgbu8xhkSVjjJIaiMLT0woPXZ87oqMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 04:57:55PM +0100, David Hildenbrand wrote: > Oh, my thinking was that with markers you postpone placing the shared > zeropage. So the next read access will require a pagefault to map the shared > zeropage. Your v1 would have performed best in that case I guess. Ah, so I misunderstood because the sentence being quote was in another context I think.. Pagemap may bring overhead constantly though, not sure when vs page faults. May relevant to num of missing pages. It's just that we may still want pte markers to avoid losing MISSING+WP (with WP_UNPOPULATED) use case, which you rightfully pointed out before. -- Peter Xu