From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C9E6C6FD1A for ; Tue, 7 Mar 2023 16:23:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 051956B0074; Tue, 7 Mar 2023 11:23:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 001B66B0075; Tue, 7 Mar 2023 11:23:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0C466B0078; Tue, 7 Mar 2023 11:23:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D391C6B0074 for ; Tue, 7 Mar 2023 11:23:04 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B2EE01C5AFA for ; Tue, 7 Mar 2023 16:23:04 +0000 (UTC) X-FDA: 80542621488.15.26D8819 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id F35F2C0019 for ; Tue, 7 Mar 2023 16:23:02 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=SZIIjZMv; spf=pass (imf22.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678206183; a=rsa-sha256; cv=none; b=cCtgT56IE1rswAe5YYZr92GWGcuJS3pNrx/JjAiJDQ3o6pNnzi6aBvLDoiqvi5lrFGXFR4 MZAHgplHu8xSX1fpDl6YzTGyrEufIwMrZvdj3Yktuz4+dTgFAlWkgD6bHX5uHCkVzdV+7P Zt9invr3pgDft14kV746uuF6L1ueSrc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=SZIIjZMv; spf=pass (imf22.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678206183; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CxfFEGPZQXweUTu6hlxxtdJkzf02+8YFlpmu6xV7Z+E=; b=NZBQp7VGP7KXCAeGzrwVHhHcwmMWcL4pqVpC+hylSLLinlavKrt/N31VzVo9pjWcNFiBV3 EsIsC57hfeKlc/CQh+J4J0hccQdpdXuS9csieGsMxyJ1Sc8U2rn7BXjIfc4rXGRXtVHtaT vQbYhzxjjfqxZ0IU8IaFSohzK79WhYA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 02E90614C2; Tue, 7 Mar 2023 16:23:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2739C4339E; Tue, 7 Mar 2023 16:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678206181; bh=7jiRWQnOqlikHWyFcy2266cI8cKqGFksydn4vH8WOKo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SZIIjZMv/lwIojx0KSIDfHtx96xXXbsbilPAsxXCVHEjeLRDbgBWHS64JfOSfuLx7 Vsenx+JlUw/YuO6tI+C133WV5E9x6aqBGG9k+o3GsutUa/pc7hweduh94O1IpGOwO1 2snHaVJ4VjrhcAbqmt6pDxyFKSgOV+xiGIOJSuqg= Date: Tue, 7 Mar 2023 17:21:31 +0100 From: Greg KH To: Peng Zhang Cc: Liam.Howlett@oracle.com, snild@sony.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, Stable@vger.kernel.org Subject: Re: [PATCH] maple_tree: Fix the error of mas->min/max in mas_skip_node() Message-ID: References: <20230307160340.57074-1-zhangpeng.00@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230307160340.57074-1-zhangpeng.00@bytedance.com> X-Rspam-User: X-Rspamd-Queue-Id: F35F2C0019 X-Rspamd-Server: rspam01 X-Stat-Signature: fyn89wbyfqd89kqsgj4eqgffmuxeo4as X-HE-Tag: 1678206182-87523 X-HE-Meta: U2FsdGVkX1+RhXXO2rRb/H3Sh1lA53SSRa3tWXn0v06uxkR042BNrjT+bEb5+kqqojyqXYyiiWG0/3E/xXHQ98nHzJBIWRWtUKiUErKexmRgrWJlKznMsABKi/mVxSLl6vwImpRke4mcUtPIbYPbY1NC6AR5o5e2rnOYzmXohdQp88YG+iwzsYKEoXVD3wAdG3U6Dc4nT+1ySN+8eJ2arT0KUKaCP4NFATGtJxeGR4gggdTAbQ51WpV+Pd1C++jx/9RHuvwdcb9nhLGrc7hDmyaTe91tP3bzIadvn30g/MTvsSdjl3Z9owOOg9RSAc3mOt/rFXljC+wVr6EP7aT0YrfbyhhyEX7+AINFlVT7NpuM7snsfHjG4eTJwJgmASus4Vukq8dIDh1K8m9rzTUlQZIL96d6ihB3z+3jkFYWs/eTfQfSckl10YPvyzNABkU8Ct9QcwtMZ+GDP2D9ewDoLPeodXziJIrIlMT7CYVg1/DspZrWL4LF3sWMOC/mn5UZq/oISJyJb2Y4gEwZD8ZUuzQ4TRYVP/MDSIb4DtuypBNsb+b1xk60EYB6pwzKXqeid1t4RTgJ2zhO/hZpjDGTwOYgU31mRQAHR7959FVDWULWlX/fNAmr/X9/gu7d2jKlP+GgikQc3nRtX8hShB5EEgP1NUkyr3Is83uuFA38RFZvG4ZydkgE8C2dp3fWps0DIJ4kz1vHTOdhVUaELkkDjsyPxec1r2ZTcIGleQPpEWCXlgWjNtsxu9tsDwAR8sa2TNEt5lzJybQR8vUYGji4XtEmqK7+GYtEvyBOVU4V7JVtTn10u6DgFfdEV66QnPJCzOzgLr5h7jCz/kOuFm991VegJ9uH5nBVLp4gczG4xkA2oOm2ea+BS45km0w/jWV355UHpYJUtdnp770xixApsgV9r++QWXKRPXC9Fcy6ny4fCzjYufL/CmcTLYJVnGw3GB45zIxRCzDc3c0I7CM MpZZlb8d FJK5wgnAdGzxKhJT09Dhb7i0Q0b4yTo9fCtn7f7lRPmI+md4fjpUWcLbL2FBQ9KcIMBjFv3AT+iXQbqaq1JNs2akInZ82QhfBy3tRH4Q/FSqZKr6fDdGNa85UE7enDdPENzGEfAba70j+rapNFykzO/ftC1HCJ9rCdrGUb/Klcg3xOK0tipsjoDMEdHlcnoMvMuRjM5/8FahZtAbPBXcHFm+w88WfbMs5xbCJHC51UqpYgjle6ttuGZU78n72COUKfSCzzy4DLwqiBjGaOBvRwZBGzzvpR4H0kQlDzTCJtFB28JZ5NPlvVKUfSa/C34CYeOIHP8YwSbt6ePF80VNrMIvIY+z5F02ibr4oas9/rIitmfk3nRrz5RXeFlXBp5QWvjWy/nyl0v9ozBS+XvuHJFcUuJZjKPZyt/wecvsHIa+eFKTDLfiVfMMBujwMvIcP7bs7f+dGIC7hSUuM8mkZe+KUJaKneRzidiWtzXzeeGl+85ohj9DCvDHlIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 12:03:40AM +0800, Peng Zhang wrote: > The assignment of mas->min and mas->max is wrong. mas->min and mas->max > should represent the range of the current node. After mas_ascend() > returns, mas-min and mas->max already represent the range of the current > node, so we should delete these assignments of mas->min and mas->max. > > Signed-off-by: Peng Zhang > --- > lib/maple_tree.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index f5bee48de569..d4ddf7f8adc7 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -5157,9 +5157,6 @@ static inline bool mas_rewind_node(struct ma_state *mas) > */ > static inline bool mas_skip_node(struct ma_state *mas) > { > - unsigned long *pivots; > - enum maple_type mt; > - > if (mas_is_err(mas)) > return false; > > @@ -5173,14 +5170,7 @@ static inline bool mas_skip_node(struct ma_state *mas) > mas_ascend(mas); > } > } while (mas->offset >= mas_data_end(mas)); > - > - mt = mte_node_type(mas->node); > - pivots = ma_pivots(mas_mn(mas), mt); > - mas->min = pivots[mas->offset] + 1; > mas->offset++; > - if (mas->offset < mt_slots[mt]) > - mas->max = pivots[mas->offset]; > - > return true; > } > > -- > 2.20.1 > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.