From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B071C678D4 for ; Tue, 7 Mar 2023 13:12:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 291A36B0073; Tue, 7 Mar 2023 08:12:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 241D26B0074; Tue, 7 Mar 2023 08:12:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 109E1280001; Tue, 7 Mar 2023 08:12:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0455A6B0073 for ; Tue, 7 Mar 2023 08:12:02 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AE7DE1C1368 for ; Tue, 7 Mar 2023 13:12:01 +0000 (UTC) X-FDA: 80542140042.16.4078F2A Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id D846EC000D for ; Tue, 7 Mar 2023 13:11:59 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WnTHk92Z; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678194720; a=rsa-sha256; cv=none; b=BUWwUkDd6IV/uhX1HX/7je1jzCnb2Ms2KiNclaiNrUAxFtapzIUDUPv6XoRWMfUklmXPh+ i5pr9oLLWgfdUBIQ1YmiLnWZjWttOyXT/H4Am+BsHCAu/3+4dQqklcVptaOMuuzkI/GfwA 1D52Ao+3QHZ8gBkYhHqYe8erVVxOQGM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WnTHk92Z; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678194720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GVTs6crYBBCTGUK5IunoCMrsCBNtBI5v4VU7V2m/YYw=; b=1bLjhglh7Bl4W2EW9B8FINC0pHlCVBEy2Mlvv8CMNzjWDfDxmusCRLJBnvWHnv0sd1vCq7 UteTJ6YlnVZmmVVgBQdDegYGRM2TDE/k6Jku2W6tR/eOwf3p0Jcc+Xm/JjahDX+bg03n4o 2CvcIB4wLVTvo7vxILsi9O5MjbpbQq8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 156D7B818BD; Tue, 7 Mar 2023 13:11:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62650C433EF; Tue, 7 Mar 2023 13:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678194716; bh=yPEK0b3AslIzUscbkPKlhlg12JscyL7jmaUh7CLYLdk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WnTHk92ZX7U648HeH7O5AWjcqAn8oZz05jvYbHiXRhUHTElBN8Uz7YbOpmeUyPt+5 eMO8ebmsABW0rhY56HkBoNHZ64m4GvfCjRMYKXoIgbrklexdGAsu5AJ2oXEEaJ5wiA j5hTQrzndekYoG/gEZ25QS4rF5dw60KENe7XMwOnr5K4x+ZcJWx6ZLa3AYnmETHMGe +0Aj4mM25P7FllrqGtMwUtvJKi+IQZEGYVuJ9CrQ6o8yB+CfauiEHDC5Aj9/VqSOr9 fWFtlI90H69Fhsv0nBYv2u7yNGdqsOQIa1njLxPXW3Nogq74jxYUMdVeu2UBItLpKg v0jgExwZtqP/A== Date: Tue, 7 Mar 2023 15:11:43 +0200 From: Mike Rapoport To: Claudio Migliorelli Cc: remckee0@gmail.com, david@redhat.com, shaoqin.huang@intel.com, karolinadrobnik@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] Add tests for memblock_alloc_node() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: D846EC000D X-Rspamd-Server: rspam01 X-Stat-Signature: to9bt8f451ahf1zawk4zwyb7c5ozbe3b X-HE-Tag: 1678194719-267179 X-HE-Meta: U2FsdGVkX19rwV80IrJC4IW95pFVfYaRsRcfbxDei7nIeTk3J0HqMQCzxYUFO434oPCOogi8o8r0e1mG8R15rZrbaiBxloa7CeQwEwduGS0wo+Y2UNR8PX7ib4D4/Rt25OP1RDQNxtKx4VmD/XsBw0UK0nnlsbffr7RHn34l69jIkEH83+r6hryFL2qvuBgv9zzMoz1g8/KTJZaY4oT6wrWQDgXtpnQs955ebO+UaLs1tJog2uOQWXVQdV4UdYph7zZeaimmRzS4XCVuVBhuJQ2LLD110EOjHmbEhRjs1UUhUGZy5prmk1AvZsRdlvneiuaa/i0JRwpmQKxR/v7D0VYUaxXe24GhrLi71Wk+4E7ntqRZgVNonIiljmB9dbMwMCaGOaDX5/moZTdhvbWZLT1bQAFG+tQsR5SgpfwWb9FlViWj9tAsdsIxGP0xww0VLpY0GZBYjwGZDDHenA0ZDl0NOp13VSLW3GSiwnKAPjLmuPmD7kFk8WYfWJ3hBy1PMLwsbeXc6PeyPDM2q3F497McDg4WwUZCtVbop6cs29V/gYOgJt1bc1969GtMxVqq45FfyH9avrPjGHJ207+umeCNqHk2lrunVEDMIst2sPCL0ZRNw1hA/Dv316K7UJCQ8bjZpHfr2ih4e0pr8yYwQNRdeP/xyNGa6xzZ9W5ykAaN9Wdut8pGSBJtbVJstx/L+ORSnTMMVrdm+9MpCBZjNJPQUs3ZW9yGXgAjH7Sr/OyzrflFryoBGi00kyMVt3/XObxb/rPwFnq6QR33R0gPBvDEr/oGYPqTx4m5OUL7hEkxFORxSumdSnMznYGzmwu+8JeGXJPQ8kCauPLcKHmDwIHKzhNVxrCnRV5pl1+WdwtHo4xlny4WHCQHtxK3TWLEIN90gfwOCFtyaaAnYyGp0qEoENtQSx08JlrFT6VYwcCsGSHyt13RSuNI+L4QaOjE6zqNqZyiuYRFEobXswz nsY9J6zY qvkLVkJ5baT5hWLl/U1RA8b+VGs9K0kktiauhyOcioijrNxeRSy68Impt26QEorgZ2x8DA5Ap8wn2oMXF0usYL/0Tbf0DLmWN7Ol8SGM6+VxVnBEIwFrmR01HPmw73xjT0DYjYDlQQ/PeeQDJVojk/GNuq73pOK2mJDIPb4zGv9PB/iMleBvgG01eDhMzUAfZTmKbOP8Pji0BUsd1DJWOkEcpmicu/SdzZPrGshaR/7gvpnmcvYcRvgmN+tvSPhNvkm6gbjORGsKnQyvjOb9EgD7S2tsmaO6wIWCegA+IRzi8yyJU7BWJ/uRe87aE0Ao1FJq31on95w1ETZlMjmFECfzHfs6Oy2v1X6nL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 25, 2023 at 07:07:11PM +0100, Claudio Migliorelli wrote: > This test is aimed at verifying the memblock_alloc_node() to work as > expected, so setting the correct NUMA node for the new allocated > region. The memblock_alloc_node() is called directly without using any > stub. The core check is between the requested NUMA node and the `nid` > field inside the memblock_region structure. These two are supposed to > be equal for the test to succeed. > > Signed-off-by: Claudio Migliorelli Applied, thanks! > --- > Changelog: > ---------- > v3: > - Fixed errors related to ":188: trailing whitespace" > that caused a failure when applying the patch > v2: > - Use the memblock_alloc_node() directly without mimicking it > --- > tools/testing/memblock/tests/alloc_nid_api.c | 40 ++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/tools/testing/memblock/tests/alloc_nid_api.c b/tools/testing/memblock/tests/alloc_nid_api.c > index 49ef68cccd6f..49bb416d34ff 100644 > --- a/tools/testing/memblock/tests/alloc_nid_api.c > +++ b/tools/testing/memblock/tests/alloc_nid_api.c > @@ -2494,6 +2494,35 @@ static int alloc_nid_numa_split_all_reserved_generic_check(void) > return 0; > } > > +/* > + * A simple test that tries to allocate a memory region through the > + * memblock_alloc_node() on a NUMA node with id `nid`. Expected to have the > + * correct NUMA node set for the new region. > + */ > +static int alloc_node_on_correct_nid(void) > +{ > + int nid_req = 2; > + void *allocated_ptr = NULL; > +#ifdef CONFIG_NUMA > + struct memblock_region *req_node = &memblock.memory.regions[nid_req]; > +#endif > + phys_addr_t size = SZ_512; > + > + PREFIX_PUSH(); > + setup_numa_memblock(node_fractions); > + > + allocated_ptr = memblock_alloc_node(size, SMP_CACHE_BYTES, nid_req); > + > + ASSERT_NE(allocated_ptr, NULL); > +#ifdef CONFIG_NUMA > + ASSERT_EQ(nid_req, req_node->nid); > +#endif > + > + test_pass_pop(); > + > + return 0; > +} > + > /* Test case wrappers for NUMA tests */ > static int alloc_nid_numa_simple_check(void) > { > @@ -2632,6 +2661,15 @@ static int alloc_nid_numa_split_all_reserved_check(void) > return 0; > } > > +static int alloc_node_numa_on_correct_nid(void) > +{ > + test_print("\tRunning %s...\n", __func__); > + run_top_down(alloc_node_on_correct_nid); > + run_bottom_up(alloc_node_on_correct_nid); > + > + return 0; > +} > + > int __memblock_alloc_nid_numa_checks(void) > { > test_print("Running %s NUMA tests...\n", > @@ -2652,6 +2690,8 @@ int __memblock_alloc_nid_numa_checks(void) > alloc_nid_numa_reserved_full_merge_check(); > alloc_nid_numa_split_all_reserved_check(); > > + alloc_node_numa_on_correct_nid(); > + > return 0; > } > > -- > 2.38.3 > -- Sincerely yours, Mike.