From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37171C61DA4 for ; Tue, 7 Mar 2023 01:30:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B57496B0073; Mon, 6 Mar 2023 20:30:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B05C56B0075; Mon, 6 Mar 2023 20:30:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CE33280001; Mon, 6 Mar 2023 20:30:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8FD7C6B0073 for ; Mon, 6 Mar 2023 20:30:56 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6B5DC1A0826 for ; Tue, 7 Mar 2023 01:30:56 +0000 (UTC) X-FDA: 80540373312.03.0EDC8B5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 8B6A4120005 for ; Tue, 7 Mar 2023 01:30:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O+5u2Exg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678152653; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A8ahPZDaVvcIaob1vmzodN2QF3Hw6BRjjqbc38rwl/Q=; b=TB5BXi0JbxRrkpXJmuVDeIP7LdH4dVauVfYNEJot9ZmZBFWPq9pgox8l0rRjRxFIVGD0gM vvgzY+F9hHtMLhl8MmD0AnOvk/PD8O1NvRMT44Gi60HJqpypPH1sqJQYivkiccnCdZ4nFk TWAbZpLMTjIOYaV/KOOF62XIdOvKF9A= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O+5u2Exg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678152653; a=rsa-sha256; cv=none; b=DEum8ZXLDPGRDha4GTGcw8jPDdGOSh06B68fH7djLR73uqXmp74A1jteWpg6iNdFOCyeYF aDHWtOkK4XafFtdQkZhOFqxmSV58oVK///DyW7i7IGBoIz4r1ru3FOoCwC+cvc5IQSOp7g aK1vrO+0QvqhO4b5KkxTeeU94yzhAD8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678152652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A8ahPZDaVvcIaob1vmzodN2QF3Hw6BRjjqbc38rwl/Q=; b=O+5u2ExgaOEshTO2YlxXEqsOYa9P8aLq+BzqYmkLgDP4hjQfWutktreaxOZGpZwr43cMke 9yPlGUQ9I3qKMYepfg9uo34rtnrrRWjhZyV4eYuEaC7QA8N9UrWqm5sPzup6mCSHHMo1Mx ZL83l03NTiRK36rVWF+00Z6FDBfOcaE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-q-PJP5gANaiVF8sVjYLtpg-1; Mon, 06 Mar 2023 20:30:49 -0500 X-MC-Unique: q-PJP5gANaiVF8sVjYLtpg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9974385CBE0; Tue, 7 Mar 2023 01:30:48 +0000 (UTC) Received: from localhost (ovpn-12-63.pek2.redhat.com [10.72.12.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D0E44492C3E; Tue, 7 Mar 2023 01:30:47 +0000 (UTC) Date: Tue, 7 Mar 2023 09:30:43 +0800 From: Baoquan He To: Michael Ellerman Cc: Arnd Bergmann , Geert Uytterhoeven , Linux-Arch , linux-sh@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, Luis Chamberlain , linux-parisc@vger.kernel.org, linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v3 2/2] arch/*/io.h: remove ioremap_uc in some architectures Message-ID: References: <20230303102817.212148-1-bhe@redhat.com> <20230303102817.212148-3-bhe@redhat.com> <87sfej1rie.fsf@mpe.ellerman.id.au> <5dec69d0-0bc9-4f6c-8d0d-ee5422783100@app.fastmail.com> <87jzzt1ioc.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87jzzt1ioc.fsf@mpe.ellerman.id.au> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8B6A4120005 X-Stat-Signature: u548rhqonwz9w4u3ytmwysgi3jqno565 X-HE-Tag: 1678152653-687177 X-HE-Meta: U2FsdGVkX1/wmsAW0aqW4//0E6WiZg4Mrt3jyp4R0M2BZ/6HbHjaathrK+C9gbFhELyDCwISRDPwTjvW2JYddsZB8aG9WYbaDMa4xVxCEsaHgTIapMo5yDtYmVZE+pgZo2nSY2YS1tOZ7UTcv6UI9ntVi/jIKqA3k5rVNjJ5hs2+RVCh4jKJzxksljl/kZCpU8W273mVP+R7PwWV0JlnhZ0YobY2y1EX5LAInF+xC7plOcCyB0sxGutNEdwuKhaqmcEcpyWfpCEGmKery2P9+rxMsnJ0VfgYKJ3muWt3obACkhMays+WfD/Q32n81g83nPCxsy8quVrheYx3ZfjhN/f2BiJpkvsa4AGUI49Y5yHT4DpUx/wI2vNgPL78erHkTVGw/1dPAUO/owCIZaProD9HYb8OsswVKCZDspIu7VADtdfrZyt2uPPc2d5djw+pY1sABV/Lgj/sqNRX1K8wCgJnhXtKVnsclnD6VGiqFJQaAV3cbFLqPo20OPHlvEAn7SZGrOeGt3/iYjvR2twK+LrTuGbWXhbwRnuV7TCuPEBVKFcnHizM94rpXFdr/3I9bmwdLXvCZ10hsqGJS3Gpu6EglP2nYw+s/T8qkPHr0dZ4c+kQuWxswCCQ2VNyzPhmsnZiYOiyuz0u/gcAMYsmL+V48V89jg9nmK2in5suZ5bdjH9UE0swjv8vTWgYWquAmIO2T7Ajr76CpJJVIoCVj6jJsYej1xqu2lZHQK5HRQpJCEdQMOwNR2WZs73IzKBnccZYIl/w94HWh6EwN95Zm/wln2pL8rZdM5TNcyz3SFx96jhndFa6T/rtk9tLL6N9sbOLVeZ/sGtVmLEkAa577BFpNPkJhnJKm97iqUFCjhQgYghhZU4if1Ns6Hjp0BA16RgB6Na+ovzlQTdjsz2VtHADrSPT/QOFXBvjFyod65eWDRMrPSbmON5GYirIZYsjtIvp2vFae8ENSD1PAEp 6DjZxu6l I7bLJT2csQ1S5R06rmag8BfNk3bZppP9Bb5SwI4mWVSkHIG09urkC9x6bf59XQIM+gpfLg7U1/qthaP1DLm7jXVxVZCclC4wyfrDwdn67TCwt+JC94BI7XaAk/mfGIWQTheCWPXXYuAseHggQu5JY9A8hvpWoA7WD/eN/2Xk9TxJyAszZRf26aYIx3ObOBazhK+HUQ44DQp3p3aqpJTLbFZFxQEtw7fwxPSequKBWY+lklPIXBwKfsD2KQ0YiPHQ3yAJOtr07yXZkegzL+cA9nuEqte0eHUu4KTON1xxLx6U1MCLQ1W9DJ21kUq0YCnIOQD3M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/07/23 at 11:58am, Michael Ellerman wrote: > "Arnd Bergmann" writes: > > On Sun, Mar 5, 2023, at 10:29, Geert Uytterhoeven wrote: > >> On Sun, Mar 5, 2023 at 10:23 AM Michael Ellerman wrote: > >>> Maybe that exact code path is only reachable on x86/ia64? But if so > >>> please explain why. > >>> > >>> Otherwise it looks like this series could break that driver on powerpc > >>> at least. > >> > >> Indeed. > > > > When I last looked into this, I sent a patch to use ioremap() > > on non-x86: > > > > https://lore.kernel.org/all/20191111192258.2234502-1-arnd@arndb.de/ > > OK thanks. > > Baoquan can you add that patch to the start of this series if/when you > post the next version? Sure, will do. Wondering if we need make change to cover powerpc other than x86 and ia64 in Arnd's patch as you and Geert pointed out.