From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD73C61DA4 for ; Tue, 7 Mar 2023 01:23:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 393646B0074; Mon, 6 Mar 2023 20:23:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 344886B0075; Mon, 6 Mar 2023 20:23:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E5606B0078; Mon, 6 Mar 2023 20:23:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 107DB6B0074 for ; Mon, 6 Mar 2023 20:23:45 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DB9DE80454 for ; Tue, 7 Mar 2023 01:23:44 +0000 (UTC) X-FDA: 80540355168.15.9E6C7F5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id C4F3F4000C for ; Tue, 7 Mar 2023 01:23:42 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MNC+K+wg; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678152222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VqFd56y4+LzHfJxq40JHsrzkzmxYaLDJMh6dCS+VZKQ=; b=aD2ykjjbR1GaQ4Isl63SO2dnbg8EtnGRZWTI2s0ms4at7Sn/N8Nj88SkO4fqk+aBF5JDBa LRKvJbpT/WJ3E7oLbfuVTaYtie1KQZdTiZ6+d4Qb/tungYw3r3EJ1dt/DueraRG6kjhEYp 6/PI+kLt130yMxyTy5GwGxEgclMqmo4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MNC+K+wg; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678152222; a=rsa-sha256; cv=none; b=20WGKpVAtKhtF/t8azndC/pd5C3xgRRxUIyjwRXD9DyyN3MprUjr5s9R0wxav+4DuxvHko iOlpaRx1bDcoft4VkkIePOoDeNFK3PhS3SQ3x7gRNtMLqG01Tv2ldd/5HJuzD6whDM367X Wg6eLJcz4gg+bb2B1amNINK8txmtndM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678152222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VqFd56y4+LzHfJxq40JHsrzkzmxYaLDJMh6dCS+VZKQ=; b=MNC+K+wgjATjw22BP1/FnVV2ugR6R+eX/DANMmyv3wNeRyrYanWTsbYlR7BpW9Evnmu+Wg LukI+HxbCzWla2G5EhdwQhLuEyXCT8BtA01ZajIvNz3a3OuoQwi3UXFVLfS5u+3JjIszh+ bhZJHXt8vuNv/DZobdbL6BzgKit3wOE= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-vc_p7jfRNpemI8M5KjoWDA-1; Mon, 06 Mar 2023 20:23:39 -0500 X-MC-Unique: vc_p7jfRNpemI8M5KjoWDA-1 Received: by mail-qk1-f197.google.com with SMTP id s21-20020a05620a0bd500b0074234f33f24so6485758qki.3 for ; Mon, 06 Mar 2023 17:23:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678152218; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VqFd56y4+LzHfJxq40JHsrzkzmxYaLDJMh6dCS+VZKQ=; b=ZVuV5b389SwhQJxMEWjnq9/GGUZ5+AnsjNIVWkqsUFRevxsx91SHhTqsm5XS7WMOb2 TiSu6irRbnc7QrhnsTn/3qjcRNmObUkUvxCuIVUAMuvjCHOueX9pGx/khcI/F/AiOYle 1k+TeexxxXVaGzos0u3iLCtEUhLHALrre2fEwGTMrwtRShyloCRv6DaIGqQoL6vsmshP KZbOnb7ZC/ZjbZYeKwqDstlRVR5ypt5dutc5kHbZt+Pf4+MVk93LFJuVHUU6eDsLyskR KXZZ55vbe/5r75lCK6GtbYoSytqJc1aRMxg1v7BiGz8yZBTv6TMAVrSuo/3yr+exczON Tv7g== X-Gm-Message-State: AO0yUKXq2lL/9BNjGR4Vz7AI7+vrW/9kH25yRtdJXiW/wYAwvzRq+ow9 6KDz7mN9+qkSKhpVHj9UCwGlLDarYtkKldhouQcCrEB1F5wgrQVkYx6/0oJROJqyANSQSWzJC4y K8D95qzHVGfA= X-Received: by 2002:ac8:4e49:0:b0:3b6:309e:dfe1 with SMTP id e9-20020ac84e49000000b003b6309edfe1mr22807068qtw.3.1678152218568; Mon, 06 Mar 2023 17:23:38 -0800 (PST) X-Google-Smtp-Source: AK7set9NpW+IRYzeTwvzpjcmeG0lCpLiSMH4ix2ZZfLC9vuxmSNZLU9/wHTDN/VWK1ddDO5/7LNY8w== X-Received: by 2002:ac8:4e49:0:b0:3b6:309e:dfe1 with SMTP id e9-20020ac84e49000000b003b6309edfe1mr22807045qtw.3.1678152218368; Mon, 06 Mar 2023 17:23:38 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id e15-20020ac85dcf000000b003bfad864e81sm8708948qtx.69.2023.03.06.17.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 17:23:37 -0800 (PST) Date: Mon, 6 Mar 2023 20:23:36 -0500 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Hugh Dickins , Jan Kara , "Liam R. Howlett" , Matthew Wilcox , Mike Kravetz , Mike Rapoport , Muchun Song , Nadav Amit , Shuah Khan , James Houghton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 5/5] mm: userfaultfd: add UFFDIO_CONTINUE_MODE_WP to install WP PTEs Message-ID: References: <20230306225024.264858-1-axelrasmussen@google.com> <20230306225024.264858-6-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20230306225024.264858-6-axelrasmussen@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C4F3F4000C X-Stat-Signature: 6iihn6rsmmginch5j9y936w5bni67b3j X-HE-Tag: 1678152222-602362 X-HE-Meta: U2FsdGVkX18HIe8f08gXzq2lnyUBTXLDc00WNiP2LdjxghFJnlNwlWQeHfmrOp3osNeIZDJkPrfeKrrpbwhmx4cjdah8Yb+PQT81zCK0TfVkRxx/yjA/A5jCPr/2Iy3lWnII3+Vw4w7GqFTChZuVH4VdMLpkLnniLv/+FuyojF6gE9XRBu3tl7vUCejRcQrZG0kQMkhr0sRfvLtGYQlQcjyU/9/bWMPWptVCaQwGQBjyqgcFO2xaD524WUhfbTi94wa6ZEcvpcACAz8ErWYrupKdlYzTK/tK54TOQaiVH4/aPbyuW83EgHm0NHGgJXQn/c/UPwVfhlxPjsVtzPoA9N+ozkTbZSe/qsHIrQgC8x9/peHkH/4Kzu468hZ1Q/5Bklb2O2/uCiT5n2gitrjGOOXRYkCVfVzSiZ5nB9qdeVfYeRJhjaEjXHK5SqgxzvhyUrJk7V/SgyC2VFZUkcGcnxgDXjpx8FdPGH8mcreCf9eWuccEHeDQnrC/gxfkTdNP9X8rJx7paae20DMgCm5rnM30AOvJK2D3M11xVqFT218VSdJ8YlH2tSk1dtI66fx85ZNmbwkNq/m0UhH39plwyia1NIazyqGg4VpW61L0rkiLqQMuohigreXckZzqUM1SN+JSSbsDRIkM9Smu4nF0iFZmBA1C/gmBbkPFWrvq6qjkbZSIq4yWvjECbqL8I11SdEjmVOiu+RM/zvJslqTxAuXtmaxCVF9d1WT6FYo0HITcKNKFcq9pElVOSkhdTEMQwTSyBUx4KygZXM1tVrKKWDkK2m78aQtKio0dLBm80B34Qr43PNqwcG2dsT7hXykrCLebZU0tJeGTaigmTlnjSB4CT/UKQeLGOtIH2zRsddZ4JwXxGBuxvahCEMHzcZkBRknXcFAOJP1FVpKRTMKSczuuX7z+MfNdErqmolN8d3Yj9ZRHE9ZmHqq5s0FxnQ/vzNXdVJHyxjyrGD7uu3f nijUU0O1 mAckc/eczuucSPSX2/0TYA1ERjj/7CNCMlJnvDVQDL1Gq904EcmjjBnabau/qAlLzSB0BJpPde5UJdHsv46FzWvR6LvWvxY63YQeUXOHlur7Nleh2MldAd9nsf+5CmUtXZ1sQwXxiPS6y8RgTRVlsNaa1lv5xAXJfHAZfiQH/1UY5Fdf7IH0ODTtVYB37QoMlgw2DjwPXJYbSgB8QZ11WA9/YU6zGOw85Crib6a053E3l78xHK2Q5v1V7/yIII1F7xz/PewkuRef5zMk5W7ElNwtiW3coYjHuRhlTACMFLQcfLfI7O9C07ThEhG/gqYLP6sh7+mpNVNzrOKZBLJpRQjxAJw5TfXNplK4/l7bVonU2V+jcNeuAdKD3FgjUFV1l0k6D3dK4ul6/R4TTt3GAq4WMnzAhZJFmwsGJRc0HUaGU7xgnS4xxm+ytJNSM8nutdeRnGZIXWZR99sTHXL28jqYrc3UifhZm7J8v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 06, 2023 at 02:50:24PM -0800, Axel Rasmussen wrote: > UFFDIO_COPY already has UFFDIO_COPY_MODE_WP, so when installing a new > PTE to resolve a missing fault, one can install a write-protected one. > This is useful when using UFFDIO_REGISTER_MODE_{MISSING,WP} in > combination. > > So, add an analogous UFFDIO_CONTINUE_MODE_WP, which does the same thing > but for *minor* faults. > > Update the selftest to do some very basic exercising of the new flag. > > Signed-off-by: Axel Rasmussen Some mentioning on the use case would be nice. :) No objection having it. Acked-by: Peter Xu Thanks, -- Peter Xu