From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC2BC64EC4 for ; Tue, 7 Mar 2023 01:04:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D902A280002; Mon, 6 Mar 2023 20:04:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4064280001; Mon, 6 Mar 2023 20:04:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE07A280002; Mon, 6 Mar 2023 20:04:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ABB02280001 for ; Mon, 6 Mar 2023 20:04:02 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 824881C6288 for ; Tue, 7 Mar 2023 01:04:02 +0000 (UTC) X-FDA: 80540305524.07.BF1C374 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 76998160016 for ; Tue, 7 Mar 2023 01:04:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JXnnTyVd; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678151040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DXzykjsiAcre19V+P05KPlN8nRLl9kRUfsGAPF8Sp98=; b=TV43gShgoRwfAeiSrd9WzRi8+vmS1k7wYYiXqdcEtFQ7WOa+bNg1alT6taJTHHBulppOVM MqJgutrE5lNnkFNVn1Dv2fLLI/keG0UIBOboLq6+MaQ1QnqIy+kaDaBU9J1qVB9LGS3Og8 Q0Cqjk9YDdlW6ciZhHaWOopKlGxoPdo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JXnnTyVd; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678151040; a=rsa-sha256; cv=none; b=EdnZ3tm3lexwQe9m8p7fVgIlt+MpR5ZLOpU3OrtrUj5NtwNE3mSXe0w87kvHZ3nSI0bwvf lAtqv0THM2u4FCF+ag0Tnz7KjLS5W48JQFq0jNOz+e23r+EGwVUQjkV3KeYNQFqCNAJ+lg iXTLc4BxnDPkscYuPOToqD8dqSXimtk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678151039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DXzykjsiAcre19V+P05KPlN8nRLl9kRUfsGAPF8Sp98=; b=JXnnTyVd437I/peBwFf8E1WTjhSOX3OHqls4t+XmBRd5n+StUf56dJ5qSsu6rwbaIMx4IV jcmkZHsFUU/ULSWJLQUmOPYPFcHi38NPVZEZ3/Ye0l/ObEdVqceiipjHk94SP1dB3xlO3e haNGIwFQtfcptk9/ssUR4M9JMKZdwSY= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-HJrniXqmOJevX10_oRy-HA-1; Mon, 06 Mar 2023 20:03:56 -0500 X-MC-Unique: HJrniXqmOJevX10_oRy-HA-1 Received: by mail-qk1-f200.google.com with SMTP id y1-20020a05620a09c100b0070630ecfd9bso6495158qky.20 for ; Mon, 06 Mar 2023 17:03:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678151035; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DXzykjsiAcre19V+P05KPlN8nRLl9kRUfsGAPF8Sp98=; b=dbpd724NWEKZDIp8kIXuSOpFpcULGLNK2UB3e9TPc1EcPgJaaDyplL5d2/+8u3rtQk dE34PB1d4m5qAcZKliLPc4QccR+UHvZASM46l1AibQAM4L9ke//lMbySVWlKOLKkzW2k c7B7+Kt3qdk6u6eGSIWGz32sN/gCTbCyNfD+gan5KnXVH8YNMLtU1cikDTNLz7dtN2xj T6BDvKI2/AdZeh3eAmm9eQaLsIymJlfTSI468RIf2I6TITqsGe7hC+xofHlQDitLPikW DioBn7M7JRImgQmbNrrQnZOh7CD2/QoMBpD+27BWAq4ZJhIWeNKSOy+BfBlBdkB7zYr0 OwWA== X-Gm-Message-State: AO0yUKUCAgFl53d5XyB9WD+T/xtOLiffABafKheIe2Eb5Rglz1ad4aWq AHUDzvABxwX7vKTSz+eqDmZsrX9oeIwI6ZcdCN17g0z0UuGAMO0A4IQG234g7C+KX4QYKQo0kkl 0T2NhhoMm8tzDyF8/ltc= X-Received: by 2002:ac8:5fc3:0:b0:3bf:f7d0:9ba9 with SMTP id k3-20020ac85fc3000000b003bff7d09ba9mr23995380qta.5.1678151035278; Mon, 06 Mar 2023 17:03:55 -0800 (PST) X-Google-Smtp-Source: AK7set8wu0A4lbdw7SyIrbGqAwWxKod4tbGGXx84xCdHz+aQ0B1ZzeoTvLl7C6vRV8e75opvM1ftkA== X-Received: by 2002:ac8:5fc3:0:b0:3bf:f7d0:9ba9 with SMTP id k3-20020ac85fc3000000b003bff7d09ba9mr23995363qta.5.1678151035048; Mon, 06 Mar 2023 17:03:55 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id 11-20020a37060b000000b00742663a2019sm8542044qkg.76.2023.03.06.17.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 17:03:54 -0800 (PST) Date: Mon, 6 Mar 2023 20:03:53 -0500 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Hugh Dickins , Jan Kara , "Liam R. Howlett" , Matthew Wilcox , Mike Kravetz , Mike Rapoport , Muchun Song , Nadav Amit , Shuah Khan , James Houghton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 1/5] mm: userfaultfd: rename functions for clarity + consistency Message-ID: References: <20230306225024.264858-1-axelrasmussen@google.com> <20230306225024.264858-2-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20230306225024.264858-2-axelrasmussen@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: g74epix31m9wm6m8scexmqdqjic8woni X-Rspam-User: X-Rspamd-Queue-Id: 76998160016 X-Rspamd-Server: rspam06 X-HE-Tag: 1678151040-277971 X-HE-Meta: U2FsdGVkX1/bmI39IfqFewUGZJBWLJ3vNy2VjhfFL8aNFCH9DhHauwtCNYYj8g1yEyB8M8RmsdAlIHK+xX1Z3aCXXFiPr8VPhwfJ0hU2SLwLsBymnA21APz0Me6UfNHr0brB9o91ghZKyLgyog+gRP9UkvQ28YaM5LxYsZF5MmNMgY8Ed4y/zA866chO2ZhPLdcUmBx6eLTgHVV//LxqRRbSYJlDbLlrh0+QhS8zS1hz+JzzCgbnOSF8NqQeXdqGx09H+vUCyxNAnpHaKCicZB/y2PzyERA21ArlBxcU5EjVdxNX3OpMr0yRijtrOW0fdFA83A7JNZsJFw1eoo4cU/vqJnwI2LqNqd3CaFt6lcAFPa+XEIKZhn62kThaR0zSCO4khjvXz8KZhQBamv1QLjIFd+QtoE1vubHvPrUO120wNrrPQ0g0hHiVTD4uMdtpc7qs455ZCo95BNeVdfNrdBwbE4Z9rRTkS+K2/QoIOJgxo5A8NXXmd5VWDYu+vvMadQuorJLhzOJ9iU0kT55qkf2a/+Su8ijHMrWcXzZ3S7ycfnHHqMlO2sRfSTXWU+dNU5zQnu/SHF0cmhRlclx5iCuu+11L0BAkv0GN0n6ZIrEQEUUueeiOrfv0PLwo68Ry0pWDSbRydN54Ihj3RqZI5DyIBwFbPkMHiCH5Dbaz+A+ci+aOHTxvuHnJREWWGiDfeqFBYLTJu9D27PQS+VQDyNFAVktV/FOJY1N3k8189Ce6EQV00yipZh1z47/s1Til0OL3BXvo/qP4r8SN8i+0ZGptILApWI5urwQzg/996V+6VUhGrSnfkIt5zqH5HBRUJdFbbsAOZH3riJNq5ZX0G0yAyvVE54bvW0G7iUM4bcQd+25XoVL0d8FcDNRP3CPk21ssNK4OFCn+wGSde6LRVvedUYNZkOvYsv0l/YBo3Tl0/rWbSqfbtnQF1Kr274rqF21t7ravqOB1BRniGvt VGIcDah9 g/JpSsvetDkb8i9oHuc3VKs2f7s5/XupKE3VhZ+l0uydu8X1vZ2GznIMejyAwtpArX1DfzPqG/26kiQymerRLBZsIe2ce1GmkI2drvgFCerYdUVL/N3zn5yEDC9tA098tpkMYzJS2sK03dJQ+pQcaBw6OOuWNwqY2I1XvRy3pyoBoBpPu2SsKvaaa8M3uzEwy+iDmbCZGy7/pg4Op1GyfYUBJ4O1aAILHf6zL3J/Rx8KiQx6xEk1UC/uV88Ar7aQPkOw3Tr6mmCs7NPeOHvneV0GHtzRppyP2bwq9arBSUt+rwGtr2zQxJ3IB47/bTGaeW556Nrd0eJHcuWw4ve8PUkhwyY1FrTtATJ2tPEZJf0V3oTCaWcx7+N8Fxn0fREWDPp5hRIH+JYghXBK5xb760i0cGJkRL1xddDZl3gr8VZGnA8E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 06, 2023 at 02:50:20PM -0800, Axel Rasmussen wrote: > The basic problem is, over time we've added new userfaultfd ioctls, and > we've refactored the code so functions which used to handle only one > case are now re-used to deal with several cases. While this happened, we > didn't bother to rename the functions. > > Similarly, as we added new functions, we cargo-culted pieces of the > now-inconsistent naming scheme, so those functions too ended up with > names that don't make a lot of sense. > > A key point here is, "copy" in most userfaultfd code refers specifically > to UFFDIO_COPY, where we allocate a new page and copy its contents from > userspace. There are many functions with "copy" in the name that don't > actually do this (at least in some cases). > > So, rename things into a consistent scheme. The high level idea is that > the call stack for userfaultfd ioctls becomes: > > userfaultfd_ioctl > -> userfaultfd_(particular ioctl) > -> mfill_atomic_(particular kind of fill operation) > -> mfill_atomic /* loops over pages in range */ > -> mfill_atomic_pte /* deals with single pages */ > -> mfill_atomic_pte_(particular kind of fill operation) > -> mfill_atomic_install_pte > > There are of course some special cases (shmem, hugetlb), but this is the > general structure which all function names now adhere to. > > Signed-off-by: Axel Rasmussen Acked-by: Peter Xu -- Peter Xu