From: Michal Hocko <mhocko@suse.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Uladzislau Rezki <urezki@gmail.com>,
Gao Xiang <hsiangkao@linux.alibaba.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@techsingularity.net>,
Baoquan He <bhe@redhat.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] mm, vmalloc: fix high order __GFP_NOFAIL allocations
Date: Mon, 6 Mar 2023 18:38:10 +0100 [thread overview]
Message-ID: <ZAYlAvZ/e52/XSLi@dhcp22.suse.cz> (raw)
In-Reply-To: <6452176f-4c17-8e09-8561-c659cbea4014@suse.cz>
Thanks. Here is an incremental diff
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index bef6cf2b4d46..b01295672a31 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -2938,7 +2938,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid,
/*
* Higher order nofail allocations are really expensive and
* potentially dangerous (pre-mature OOM, disruptive reclaim
- * and compaction etc.
+ * and compaction etc).
*/
alloc_gfp &= ~__GFP_NOFAIL;
nofail = true;
@@ -2965,7 +2965,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid,
/*
* Higher order allocations must be able to be treated as
- * indepdenent small pages by callers (as they can with
+ * independent small pages by callers (as they can with
* small-page vmallocs). Some drivers do their own refcounting
* on vmalloc_to_page() pages, some use page->mapping,
* page->lru, etc.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-03-06 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 5:30 [PATCH] mm/page_alloc: avoid high-order page allocation warn with __GFP_NOFAIL Gao Xiang
2023-03-06 7:51 ` Michal Hocko
2023-03-06 8:03 ` Gao Xiang
2023-03-06 12:14 ` Uladzislau Rezki
2023-03-06 14:03 ` [PATCH] mm, vmalloc: fix high order __GFP_NOFAIL allocations Michal Hocko
2023-03-06 16:37 ` Uladzislau Rezki
2023-03-06 17:29 ` Vlastimil Babka
2023-03-06 17:38 ` Michal Hocko [this message]
2023-03-07 0:58 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAYlAvZ/e52/XSLi@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=hch@lst.de \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox