From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D16F7C64EC4 for ; Mon, 6 Mar 2023 17:06:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 561156B0072; Mon, 6 Mar 2023 12:06:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 51DBC6B0073; Mon, 6 Mar 2023 12:06:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 400436B0074; Mon, 6 Mar 2023 12:06:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2E2396B0072 for ; Mon, 6 Mar 2023 12:06:57 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B1642120B6F for ; Mon, 6 Mar 2023 17:06:56 +0000 (UTC) X-FDA: 80539103232.07.7CFA008 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id BCD0F10001E for ; Mon, 6 Mar 2023 17:06:53 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678122413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Hz11Y/ZekVon9nIOxXGin3no8v/ljJ4be3FdaH7f9k=; b=NzZemioBmq5IOzkwrZAAwktsOny2uantpa0zWpBN3es6RhNnBo2XlPZ01uNgpmviBajUzj KWW7TaNj0EChPwDhqafWShg59ftYU5oKMKWSLvTe0E35BhVazYUjjiW+eVKFv91zmye6Cf wRgDjrjbaZR15Y2xaB/ZUxqcnWhQ+8w= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678122414; a=rsa-sha256; cv=none; b=tAFVQ494kXhpZheU6Kariis2secoOUQwiLicNdBmoRpFuWV+Fr82SmXRFLPHL8FV5xrDWz VQqeMYrfz8YzDPjPu/q7Bt1drTl5nd28aqg0tiuJ/do/s2CUl1OIfFnevpjHupkfdblEIb xM5T2G+BJxhYL4tniQDQ/b3I4DQ0aWY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4FFEEB80FC9; Mon, 6 Mar 2023 17:06:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81A21C433D2; Mon, 6 Mar 2023 17:06:47 +0000 (UTC) Date: Mon, 6 Mar 2023 17:06:44 +0000 From: Catalin Marinas To: Gerald Schaefer Cc: Andrew Morton , David Hildenbrand , Matthew Wilcox , Anshuman Khandual , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Alexander Gordeev , linux-mips , linux-power , linux-x86 , linux-s390 , LKML , linux-mm Subject: Re: [PATCH] mm: add PTE pointer parameter to flush_tlb_fix_spurious_fault() Message-ID: References: <20230306161548.661740-1-gerald.schaefer@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230306161548.661740-1-gerald.schaefer@linux.ibm.com> X-Stat-Signature: m7kmfg41x5ecy4ujermoqi3if9aidq8m X-Rspam-User: X-Rspamd-Queue-Id: BCD0F10001E X-Rspamd-Server: rspam06 X-HE-Tag: 1678122413-601384 X-HE-Meta: U2FsdGVkX1/jVMRkylIQ10mfqFxKQ0dnnzc23GkbyM+8w2S3YbftW05uhVqIEfiYcz6iYdVd4eUKvwxlHEzjlTmmkG47qlKxMVKG6vHKbPoH7NBR4q4MaO73e30FYfEoHZBwNCeZngbW0Mf0Oobyj+jonaRZEin+E7sBYqCgRMjXaWh3HXpUgzWmeP0JMaa5doHuXJVdO8itI29yd6YGlkWfnR5voBM1x9dGJ2+UgKsm3ByIqjAt0VrTveboc8+pJjaYKP1+0oGZsF4vn6+lrXYZnXBOQ/npyxwr79ZPU1auHgxqruyYTy4VuLFYMye1tESSzmeJ9fec14lVfu7YV2nO5bhEq6yGede5ZWxCs+Ogxp0B8LidrjwV2U3zb6rHWiVRbE71Sdx82Nu3h1qKutCMQXlmGUtrwPuDneZrOAUIL0Bpp6HIb4IrhgG4pHMtmk9pV25yhqUGMy6BfjZBZZ/AbEOZG2Vpf00fpd+C6e68mHZdbyHrz8jSFYJCgSna1bE8rbelZGp9mcYL0Fyy3+xfCIoqUiJoWPM/fLT64sE1+xnFvKnpQqNFE4DTes/dLR9iBzXPfCZpOqBaSEpmv+wg2eFmbAUuqOzPmcQ6A1rFHbZqHRIqCEajW9yPeiiAxOSpTLQEsYz9BbRUJEbSu+2QQQ7wiLEtWLZId2X/gO/KT42I1yhIQAM72y8Y2oyUmLNttMSBX3OWDMG9/q4+aYYC57BMr6un4nyRAvec10v5s19vVJcQB8fQG22iWpSD8yWFQke0yLWtkLhLnahEvdfNv9j5B7cJmp38AA6gN8P7zJT7d8Czq0a6Qyp4EQSy6C1XbEvHVyMYAXA4WEU93QAeKE54nAUhqQ68fcp3MImHhydpQuZ/bL6u1BYK/+Rew0alFseSbedjL2CMbcgQKCfmKdHmLlYPvfRm9XrtXimfwGmXeB2y/45sKPHhHkWnhByxzithltwu1Bmr/z0 crK6eeEI 12WoyGSMRi21WpjzGJF1cB8sS+DTIp9xeUzK68+M0gWdMs4oB9uCX2iVuwup+vGN+K0eheB8ScpqS/ma088SmMIq0YypWToSQd1XlyGDCSjSwke7aUA5jf5Pe28xHrZj1Hy1hNg66/h8voL9+Y6JhSAnTwMfINECDTZDMXNyZJIUBM8lWgoGWsVzm+dW+eLryKmvKQMBBFX0AEdG5xiwJsX3YIHTRYoHEb9Vj1bZu9rLSHkFUuKU1bn3ifNfpeD7lR4v4dknP/Ws46lCxyLkDTakDv3/UgC8dqkyuhN0yoEhR8FaC60Riy8QlF/v1yX+4uV2ShoolnaGUyA+DkFaueClH/w+KLj24pC9f+WFaxklpvAQYUL8LIl8287emcPnnaKNeP0ABLcRcNdT7Lh1T2k61lZKsJHbwyEgDlCj9dDmqDFKxi991TagSnRLLROh4R4/5hwpgub19r0tD46T5TO0uhe00SHtxleVkBPlFVFwy6UdFPniYbDEKG8eiKByR2V+ysxs5SQbDDekXkb3zLmEhqA7bxA/nTbn8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 06, 2023 at 05:15:48PM +0100, Gerald Schaefer wrote: > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index b6ba466e2e8a..0bd18de9fd97 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -57,7 +57,7 @@ static inline bool arch_thp_swp_supported(void) > * fault on one CPU which has been handled concurrently by another CPU > * does not need to perform additional invalidation. > */ > -#define flush_tlb_fix_spurious_fault(vma, address) do { } while (0) > +#define flush_tlb_fix_spurious_fault(vma, address, ptep) do { } while (0) For arm64: Acked-by: Catalin Marinas > diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h > index 2c70b4d1263d..c1f6b46ec555 100644 > --- a/arch/s390/include/asm/pgtable.h > +++ b/arch/s390/include/asm/pgtable.h > @@ -1239,7 +1239,8 @@ static inline int pte_allow_rdp(pte_t old, pte_t new) > } > > static inline void flush_tlb_fix_spurious_fault(struct vm_area_struct *vma, > - unsigned long address) > + unsigned long address, > + pte_t *ptep) > { > /* > * RDP might not have propagated the PTE protection reset to all CPUs, > @@ -1247,11 +1248,12 @@ static inline void flush_tlb_fix_spurious_fault(struct vm_area_struct *vma, > * NOTE: This will also be called when a racing pagetable update on > * another thread already installed the correct PTE. Both cases cannot > * really be distinguished. > - * Therefore, only do the local TLB flush when RDP can be used, to avoid > - * unnecessary overhead. > + * Therefore, only do the local TLB flush when RDP can be used, and the > + * PTE does not have _PAGE_PROTECT set, to avoid unnecessary overhead. > + * A local RDP can be used to do the flush. > */ > - if (MACHINE_HAS_RDP) > - asm volatile("ptlb" : : : "memory"); > + if (MACHINE_HAS_RDP && !(pte_val(*ptep) & _PAGE_PROTECT)) > + __ptep_rdp(address, ptep, 0, 0, 1); I wonder whether passing the actual entry is somewhat quicker as it avoids another memory access (though it might already be in the cache). -- Catalin