From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B015C61DA4 for ; Mon, 6 Mar 2023 08:46:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC0F06B0072; Mon, 6 Mar 2023 03:46:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A716A6B0073; Mon, 6 Mar 2023 03:46:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93887280001; Mon, 6 Mar 2023 03:46:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8062C6B0072 for ; Mon, 6 Mar 2023 03:46:53 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3D3F01A0B76 for ; Mon, 6 Mar 2023 08:46:53 +0000 (UTC) X-FDA: 80537843106.28.0B4AA46 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 7B9DA12000E for ; Mon, 6 Mar 2023 08:46:50 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z5Uzqyrd; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678092410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vSd8hwHPbmWReXdvpQsZ0BwbyP6BUUMBochFuTwRaSI=; b=X8V09yYn/kl9c/kVuqxbD3CsohGmhHlF1ufNU1/4r3lf5vdIz46fiEFGpmxGFJRI0reB+z IT7/aONUfB70un44eB8yMKAwFBmXMs7zPF5pj98GnpdOJXDPVwS+pCIMztL2qySVcrGsak VeVA/iTLqzHY+wRXiu6lo8aCkwJNLlU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z5Uzqyrd; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678092410; a=rsa-sha256; cv=none; b=HJ5cFk6rIgpUtMSUVAdNMAuZaIkpBX4WWyYTb7n9ackeJCPB5SfjxqxDJVePa+w209hDqi d3vfdtL1BcvvfO5+IDOaql+UU52zwPjxgn8OaPM7RfWwkhIkgYzh39tjATnwkF9BtQeBKI PgIHfgI7Ai0Qefll428rsFv/wUYy/uI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678092409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vSd8hwHPbmWReXdvpQsZ0BwbyP6BUUMBochFuTwRaSI=; b=Z5UzqyrdNuLHXYKFgTR+1L1jf9bCb254Gqyxo9Adl6EbwuplEOmF/1Gw2frSmvzgiqi/1d f7zeXthEWhRxPl0Uy3+veZU9ER6jJl+jEpgyXYrOmDbINPux2NKyusGg0iYNNlENvX3Euq pNnG8dA3bjrYo8n3Smdjvk00AnTQPeU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-100-LYVAfDgZPR-21MvuG0sNlw-1; Mon, 06 Mar 2023 03:46:44 -0500 X-MC-Unique: LYVAfDgZPR-21MvuG0sNlw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2893E802C18; Mon, 6 Mar 2023 08:46:43 +0000 (UTC) Received: from localhost (ovpn-12-63.pek2.redhat.com [10.72.12.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20EFAC16029; Mon, 6 Mar 2023 08:46:41 +0000 (UTC) Date: Mon, 6 Mar 2023 16:46:38 +0800 From: Baoquan He To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org, Geert Uytterhoeven , Luis Chamberlain , Christoph Hellwig , Thomas Bogendoerfer , Helge Deller , Serge Semin , Florian Fainelli , Huacai Chen , Jiaxun Yang , linux-mips@vger.kernel.org Subject: Re: [PATCH v3 1/2] mips: add including Message-ID: References: <20230303102817.212148-1-bhe@redhat.com> <20230303102817.212148-2-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspamd-Queue-Id: 7B9DA12000E X-Stat-Signature: sbdmf5egneqwdtzonb99d57xeo4jmq3m X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678092410-983963 X-HE-Meta: U2FsdGVkX18C9b6eX9e95FE9I20lyD8Q+z11LI9AWCB1yJV/ZnrOgCqxNJD8ScD6NxNz6gponAR2yQCEwlzBn1qLsOghBTcKWCmAn7GdnVPmTQVbPd3hwocPZaiUF8dxY8tuX7lloWqYcNjsNCihLmVyxmI/lorqg+cpep4BlNvViddZA4fAKbGqYJiDkO50WwdJqgaQ723royidV+pH02DHVf9N9Ll7MC3Ayj2ZTEFahLCJ8dR9/4JdtNKjXNuOwRRPAOuneCJCkf9gPzTl4K5pPZj2P//2IGHh2y1/qUBL5hunBDKFpzYqx2ExwfNbJqNuaouMjvNlQO0lxTTRRvQio7/1/2jJNyZqevD84vEkt2H/Oo30Yc5tOgzMRci5upFFWtPbUD8Ge77l8Z2j3xh36d1zKW0c906pstCbQ0s6Db331zLoK2Bj3yCbqhpGTHaZKNkhgJwPic31cT9saq8hGk6PZBpT6Rp1E4RttnEjozunaShg3WYyQyRURPi5yR6H1ZNL2MVS5XNgKXk3GFZ2zFaynYgDfcDtChw1SJxqwaJuQ+KHJjm6IP2IpLYnO+5Rrs/HZP0GWDkucoMveOr58+z3SDQ9t0FgBg0Ep09KwK3oHWWfjuy2JW8wYXlFudpWtqDGo0XE6IxlRzS7ZINDXx+uqi6ABD5gl0FcTqAsqNKUZpgzKSqWEUOsie+rAUOui+TehKPh/Jxd/27Bi39AOiZ2/S7sb8NLf7WNt9RPQTmcWYQi9gUCGZweXD07Vbq5oiTvBsBPgRlhiAVBBQeRqoOSjiz1eVO3top8FhsI275IGv+y/TLNvQjxZ+DuLiTlnJBY1I44K7Wq0SeBpI6CU86qPXu2H8tDlL1QZqtB2bbTw/Y4Xz7nrQINwqi+kTeqbekH/nfGdqJ5csKmPuWQM19+suUBB0eTD2Fcaa44Dgn3ZfVNSagsdqxUGBepuQ8mwEH65QcbXgKBTed vL95rQ4W 0xBz3nzVRgfKMp8kf6EutAOUPX2izqkXpdyWVjbmtIkRvVH64BMz8uobB/ycuZoHgEWyHAqSnT2r58/S0pFyuuUnPM4SnHD0VZlzMRZXpcTFqg60udU+/npzop6ZDiWlQ1A1WGK6I46bSiRJvBKBT7M4UntMPyqGuMZ3hB49UfQcPKd3M8bYszZ3g5gQba0Y0xE0WYpIVKLdjJNJLCzc1vuw/672eF0CnmdjfHei/ncEywRPs0WZ6ESsZcxKH1lofqujRolID1q7dMQKGwoGOd+80xzt9aIrWvlMQ1MZxVJnSc+UrwZ7zqbCEopNJQjR9ieg7zliMF2IqSpJjbcJO1u9+gweWgBl8F/sqyCr59JlkNUBSl+AszPd86444Q1UQ3dZg+fTDTwZT8uQYhQ4pgZJ/RmBn+4M7eu8KlE5XgSGnWeyXNkKsp/tNN8nBgCgrUhxW0XZwWb+enHjrF6CwPRFhgj6+RIB/N8GngVT9yNsVvFq3udOGuvciVV7HowWr4OQT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/03/23 at 01:40pm, Arnd Bergmann wrote: > On Fri, Mar 3, 2023, at 11:28, Baoquan He wrote: > > With the adding, some default ioremap_xx methods defined in > > asm-generic/io.h can be used. E.g the default ioremap_uc() returning > > NULL. > > > > Signed-off-by: Baoquan He > > Cc: Thomas Bogendoerfer > > Cc: Geert Uytterhoeven > > Cc: Helge Deller > > Cc: Serge Semin > > Cc: Florian Fainelli > > Cc: Huacai Chen > > Cc: Jiaxun Yang > > Cc: linux-mips@vger.kernel.org > > Reviewed-by: Arnd Bergmann > > I think this is all good. I had look at what cleanups we could do as > follow-ups: Thanks a lot for careful reviewing and great suggestions. > > > +#define phys_to_virt phys_to_virt > > static inline void * phys_to_virt(unsigned long address) > > { > > return __va(address); > > This is the same as the asm-generic version, so the mips definition > is no longer needed. Agree, I can clean this up with a followup patch. > > > @@ -359,6 +360,27 @@ __BUILD_MEMORY_PFX(__raw_, q, u64, 0) > > __BUILD_MEMORY_PFX(__mem_, q, u64, 0) > > #endif > > > > +#define readb readb > > +#define readw readw > > +#define readl readl > > +#define writeb writeb > > +#define writew writew > > +#define writel writel > > + > > +#ifdef CONFIG_64BIT > > +#define readq readq > > +#define writeq writeq > > +#define __raw_readq __raw_readq > > +#define __raw_writeq __raw_writeq > > +#endif > > + > > +#define __raw_readb __raw_readb > > +#define __raw_readw __raw_readw > > +#define __raw_readl __raw_readl > > +#define __raw_writeb __raw_writeb > > +#define __raw_writew __raw_writew > > +#define __raw_writel __raw_writel > > The mips code defines the __raw variants with slightly different > semantics on both barriers and byteswap, which makes it impractical > to share any of the above. > > > +#define memset_io memset_io > > static inline void memset_io(volatile void __iomem *addr, unsigned > > char val, int count) > > { > > memset((void __force *) addr, val, count); > > } > > +#define memcpy_fromio memcpy_fromio > > static inline void memcpy_fromio(void *dst, const volatile void > > __iomem *src, int count) > > { > > memcpy(dst, (void __force *) src, count); > > } > > +#define memcpy_toio memcpy_toio > > These are again the same as the generic version OK, can remove this with the above change.