[PATCH 00/17] MODULE_LICENSE removals, sixth tranche

[PATCH 00/17] MODULE_LICENSE removals, sixth tranche

[Nick Alcock]

This series, based on current modules-next, is part of a treewide cleanup
suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
files/objects that are not tristate.  Due to recent changes to kbuild, these
uses are now problematic.  See the commit logs for more details.

(The commit log prefixes and Cc lists are automatically determined.  I've
eyeballed them, and they seem reasonable: my apologies if they are not.)

This is the last tranche of patches in this series. (In total, there are 121
patches in this series.)


The series at a whole can be found here:
  https://github.com/nickalcock/linux module-license

(This is a respin with kbuild: prefixes dropped.  The previous series,
used in the mailouts of tranche 3 and earlier, is in the
module-license-kbuild-prefix branch.)

Cc: dri-devel@lists.freedesktop.org
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-mm@kvack.org
Cc: linux-modules@vger.kernel.org
Cc: x86@kernel.org

Nick Alcock (17):
  irqchip: remove MODULE_LICENSE in non-modules
  bus: remove MODULE_LICENSE in non-modules
  braille_console: remove MODULE_LICENSE in non-modules
  arm-cci: remove MODULE_LICENSE in non-modules
  drivers: bus: simple-pm-bus: remove MODULE_LICENSE in non-modules
  watch_queue: remove MODULE_LICENSE in non-modules
  btree: remove MODULE_LICENSE in non-modules
  lib: remove MODULE_LICENSE in non-modules
  fprobe: remove MODULE_LICENSE in non-modules
  tty: remove MODULE_LICENSE in non-modules
  unicode: remove MODULE_LICENSE in non-modules
  udmabuf: remove MODULE_LICENSE in non-modules
  regulator: stm32-pwr: remove MODULE_LICENSE in non-modules
  mm: remove MODULE_LICENSE in non-modules
  xen: remove MODULE_LICENSE in non-modules
  zpool: remove MODULE_LICENSE in non-modules
  zswap: remove MODULE_LICENSE in non-modules

 arch/x86/mm/debug_pagetables.c                  | 1 -
 drivers/accessibility/braille/braille_console.c | 1 -
 drivers/bus/arm-cci.c                           | 1 -
 drivers/bus/bt1-apb.c                           | 1 -
 drivers/bus/bt1-axi.c                           | 1 -
 drivers/bus/simple-pm-bus.c                     | 1 -
 drivers/dma-buf/udmabuf.c                       | 1 -
 drivers/irqchip/irq-ti-sci-inta.c               | 1 -
 drivers/irqchip/irq-ti-sci-intr.c               | 1 -
 drivers/regulator/stm32-pwr.c                   | 1 -
 drivers/tty/n_null.c                            | 1 -
 drivers/xen/grant-dma-ops.c                     | 1 -
 drivers/xen/xenbus/xenbus_probe.c               | 1 -
 fs/unicode/utf8-core.c                          | 1 -
 kernel/watch_queue.c                            | 1 -
 lib/btree.c                                     | 1 -
 lib/glob.c                                      | 1 -
 lib/test_fprobe.c                               | 1 -
 mm/zpool.c                                      | 1 -
 mm/zswap.c                                      | 1 -
 20 files changed, 20 deletions(-)

-- 
2.39.1.268.g9de2f9a303

[PATCH 16/17] zpool: remove MODULE_LICENSE in non-modules

[Nick Alcock]

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Dan Streetman <ddstreet@ieee.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
---
 mm/zpool.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/zpool.c b/mm/zpool.c
index 571f5c5031dda..6a19c4a58f77b 100644
--- a/mm/zpool.c
+++ b/mm/zpool.c
@@ -395,6 +395,5 @@ bool zpool_can_sleep_mapped(struct zpool *zpool)
 	return zpool->driver->sleep_mapped;
 }
 
-MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Dan Streetman <ddstreet@ieee.org>");
 MODULE_DESCRIPTION("Common API for compressed memory storage");
-- 
2.39.1.268.g9de2f9a303

[PATCH 17/17] zswap: remove MODULE_LICENSE in non-modules

[Nick Alcock]

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Seth Jennings <sjenning@redhat.com>
Cc: Dan Streetman <ddstreet@ieee.org>
Cc: Vitaly Wool <vitaly.wool@konsulko.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
---
 mm/zswap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/zswap.c b/mm/zswap.c
index f6c89049cf700..f2fc0373b9677 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -1540,6 +1540,5 @@ static int __init init_zswap(void)
 /* must be late so crypto has time to come up */
 late_initcall(init_zswap);
 
-MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Seth Jennings <sjennings@variantweb.net>");
 MODULE_DESCRIPTION("Compressed cache for swap pages");
-- 
2.39.1.268.g9de2f9a303

Re: [PATCH 00/17] MODULE_LICENSE removals, sixth tranche

[Luis Chamberlain]

Stupid question, if you're removing MODULE_LICENSE() than why keep the
other stupid MODULE_*() crap too? If its of no use, be gone!

  Luis

Re: [PATCH 00/17] MODULE_LICENSE removals, sixth tranche

[Nick Alcock]

(Sorry about this, MTA delivered a bunch of stuff very late.)

On 3 Mar 2023, Luis Chamberlain verbalised:

> Stupid question, if you're removing MODULE_LICENSE() than why keep the
> other stupid MODULE_*() crap too? If its of no use, be gone!

I wish, but when I tried it it broke stuff. At least some MODULE_ things
have side effects -- MODULE_DEVICE_TABLE, maybe MODULE_ALIAS etc...

... and also I was getting complaints when I sent a tree out that did
that, along the lines of "if MODULE_LICENSE is the problem why not just
remove that". It seems one cannot win here, both options elicit
complaints.