From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF33AC61DA3 for ; Fri, 3 Mar 2023 22:15:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49FC26B0071; Fri, 3 Mar 2023 17:15:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44DFB6B0073; Fri, 3 Mar 2023 17:15:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33CB46B0074; Fri, 3 Mar 2023 17:15:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 251EC6B0071 for ; Fri, 3 Mar 2023 17:15:04 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F35F340310 for ; Fri, 3 Mar 2023 22:15:03 +0000 (UTC) X-FDA: 80528993286.17.50367FE Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 561BFC0013 for ; Fri, 3 Mar 2023 22:15:02 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0lzI6C9X; spf=none (imf22.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677881702; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kI8/5p22vEnObQIn+bPz4hNfMUdIOhxE3ykG+foeASQ=; b=d1lzlOYXyFmMv5XCnIQro9KfXkBQNB1Gd8d6cji5/WzRI3/KbqPU/hUhac2yqJg2uXTNUR lraO7CLMNIZZKpwCZGZJhOD7rIXe3k6Em56NwGM5b+JLlYg4p3SK6yCQhYVFoejZoW2R4u 7n8ZNhk278M/fifF8MzSR8hhRFdCI2c= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0lzI6C9X; spf=none (imf22.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677881702; a=rsa-sha256; cv=none; b=0PhR1VZJd01QCYESUol1VN8i350lHhss2vgyM0rmv8Kk3lVOo31Xw9rxjyF0EDmrhOOrkq gpzh8EC11gIy5yZnd6TaJSMamN1XZCUv7qYBSJl28Mvg7oXdVDj4hhu852OjJfjZbKhsLV 8R6CY8xlaHIlXd0TSGsleW6T/5qzhqE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kI8/5p22vEnObQIn+bPz4hNfMUdIOhxE3ykG+foeASQ=; b=0lzI6C9XDd3RF6muzd4kjEvu++ VmGqdmnUwAf9jpeBvonsGnuiydMs3cgCXUcXShT2ouhwjGa/jeg1KTep8w/KNj85kz1/CqKCm7Dk6 ZIVhjpXPGsNFGIWw89lydkmraazH9K/lqcs/il7PcQZ0WXYUrLd7aJqKkM++Jq+qJfCEGZBKcyHdD YWOr0X5iCo4qy456D7vCP/+vOR5QXjmrONKLHbT0N20sJXm7c7i91XK09hE9w8ZsLUvC86tK0t6ke Gj0CEPEvuBHGGH5fciqP+nlvAzrVPE/fPQYkSm+TJmROBzzK9sYSZrpK2IpoqNTQR28iVJ1k83Ybf PwGyZp8Q==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYDfz-007iBH-J2; Fri, 03 Mar 2023 22:14:55 +0000 Date: Fri, 3 Mar 2023 14:14:55 -0800 From: Luis Chamberlain To: Keith Busch Cc: Matthew Wilcox , Theodore Ts'o , Pankaj Raghav , Daniel Gomez , Javier =?iso-8859-1?Q?Gonz=E1lez?= , lsf-pc@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [LSF/MM/BPF TOPIC] Cloud storage optimizations Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 1xrzfgcabhfnhxtdao9q7eo1pegjuzfr X-Rspamd-Queue-Id: 561BFC0013 X-HE-Tag: 1677881702-571508 X-HE-Meta: U2FsdGVkX1+ZTTR5uBBo4OWP2YrisPQ+Gjt6EV+g82Yx3NwXOL7CzHeiEheTCcSuwQ3GrJMSvOkqbwcbuU8oagFSJvJh4eJJEhsU89Wiwm1x2uSWs+TvZ4uNTP+VZaGfMsWOzu26z92pjzrIxYsH4gfO8pK9e1YP/QBF6vtNl8sod2J+DfqOUG+BiN/NbwBdVYymYDKGQOlW64EmtFdGL2Dah2dcLF1oWiIV32eivzAEtxSTEpOJ7GcRm+KZv/Cc0ztY83/tv24cu0K3cXk2lVfToHJejoXz5DmPpaI0oRztlZW323fLa/Oan4Jbikwth6/pDenzjMkVxPg5mLcDN0FlA36FJKaWfFd5pvJIe+x6OObqXepyP6rnUeVAWmGJTom1pkoMROHiUBYwr5gq5ez5C/0/FhUysqsyN2/RZ/4h3R/+qCW+KFRgEDieo4JQ/nieGRbI0tCO+VMOKgV+7Fsh9EEpZX08haF14NjFysv1zqlkro8n6G65WHzMPEdyxfuJTXldp6L1loLgTYZMsAi/U/0cRwVUu1Zj+/BO3rEcCd2q3D2/FMkQfXqE8mp+2COyo350rL/s2T2xAjxTgFPNXuk8lAF2kEYWSVyHu3cMkKcHeBmbpT/lXviAqYsMow63VAOkDTnLaxggPdL6HR3NBlIpuElgLjUa7y7qOPmutVdblMibO9GARRr0hn5dYK6Lt1ydUzsUQ5BC4yK8msIUjWQNrS9ILmBg+gBnZJHKPUiStP1Q4T7lB7NTsvs/8IcYsViCPUfSHC2NxpQlOEeKjEupqQ2bOYB3pSNyE7FV9yaWIi4UqH0UNCpCNXyRR/4tkaKvcj/w4QqfoWsn8iL5gGLW9HzdYYoLfzz0J6vXQzrft1eolENIRB7OMjapJJzjoO+TpMTxoeriDglPyRygm+4wdB3tv9HKjA5r+nwmBVUGTFhDUwF+7Pw1c6/K4/LOfLLNtaXoNYk3V2M Syp0/x7y RiXCiwYrKd6eQsKajql7gQdAsmwZ7wwbOKlbZXtQoEwcPF2LtsAhwiRnzSwBtAnwSk3IojKO06jGiQEYkg0L7cJ8kE/28YaB7M7PVCGwpky4PO00rA3UiFf/OhE4SFOWqkXad953k6UtdrYKt0tsTn4nxN8bgVk24UoQwXheWm9nobbhrazxmDzUEzJxSY61jaz4nbTSaoMSFm8LNehOfeKT+lUDebU2aE3fhn2QdqQ9Fq9cdKaCxshhcqYjlkRo7XpHngWeIHz25Xjo3rLNdcaqRM1A7mlfA2WVk5dkq2P0RDcR6cKwC/S7/FxMBRG8U+wkzFmfETZyzOEo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001170, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 03, 2023 at 03:07:55PM -0700, Keith Busch wrote: > On Fri, Mar 03, 2023 at 01:45:48PM -0800, Luis Chamberlain wrote: > > > > You'd hope most of it is left to FS + MM, but I'm not yet sure that's > > quite it yet. Initial experimentation shows just enabling > PAGE_SIZE > > physical & logical block NVMe devices gets brought down to 512 bytes. > > That seems odd to say the least. Would changing this be an issue now? > > I think you're talking about removing this part: > > --- > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index c2730b116dc68..2c528f56c2973 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -1828,17 +1828,7 @@ static void nvme_update_disk_info(struct gendisk *disk, > unsigned short bs = 1 << ns->lba_shift; > u32 atomic_bs, phys_bs, io_opt = 0; > > - /* > - * The block layer can't support LBA sizes larger than the page size > - * yet, so catch this early and don't allow block I/O. > - */ > - if (ns->lba_shift > PAGE_SHIFT) { > - capacity = 0; > - bs = (1 << 9); > - } > - > blk_integrity_unregister(disk); > - > atomic_bs = phys_bs = bs; Yes, clearly it says *yet* so that begs the question what would be required? Also, going down to 512 seems a bit dramatic, so why not just match the PAGE_SIZE so 4k? Would such a comprmise for now break some stuff? Luis