From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25CC8C61DA3 for ; Fri, 3 Mar 2023 22:11:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 898B26B0071; Fri, 3 Mar 2023 17:11:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 848F66B0073; Fri, 3 Mar 2023 17:11:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 738016B0074; Fri, 3 Mar 2023 17:11:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 624AB6B0071 for ; Fri, 3 Mar 2023 17:11:57 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3039380467 for ; Fri, 3 Mar 2023 22:11:57 +0000 (UTC) X-FDA: 80528985474.27.6151DE5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 8992C1C0007 for ; Fri, 3 Mar 2023 22:11:54 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=t1DRLpk0; spf=none (imf21.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677881514; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FA7uGsCNzQTX91SZa0qfeSXhiYIuU1/JhGPJURHOQ8U=; b=WbOSvBb7RwH9E0Eg+dhCYbEMBLuaMO9Va7zGQWKwutW+RLLfsQWbfyprGwyOe4pncgaLkF 2YUDUhG3vlBu083wIuUcU/3VqDHx+AFl+gZuRztj452VSwi9G1L9UtGxGWi4XV7WedfqGV eS1WkxsTd+SjArfYtZwej3fxue5cwnw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=t1DRLpk0; spf=none (imf21.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677881514; a=rsa-sha256; cv=none; b=7lM7uDN1cTx+ixFvFq8SHqHmXExIZSnQZgta4Go+zLrJWmC+IrbomeMY0NjjuzEhzjzdRv lxY32YnV2iHKD5uvUIWjCygZ8jCRqGXf4JJuYWX4B+emBRwZ2t8BcFekoXmSTBh7NsewIP 8goXNXDtNYNjl6wx+DThBuMi/lN+ww0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FA7uGsCNzQTX91SZa0qfeSXhiYIuU1/JhGPJURHOQ8U=; b=t1DRLpk0min/n/ZU4WczyXFDVW ryVT2b9FcFpkwIibnFsuQE6SI2jp1MUYCxnI8z2q1uFhPZbYpfI0HWzVFrERZOVrWeLmQlgihQEII zCcyytDs7ADaZDk263+X2+PIkCW+XhNmxFIgugyqGjLWJ4s+lkutfU0kvgApHcNmtLuWY7BL67qrq 3tBdxSF19BFC+BAMGOnhyRJOpaMgHhqfafWk7+WgbWaXEESs7zULP4z+Y2FFAAHhfy1Y+1FWjrBGj umwyLL1lneibUf+JyKHs9uF5ONZ9rSzbZ5hivSEMQuR8M0g29myNQwQ9Igft62cmli8Z800K87Kyh 01vGbzaw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYDcv-007hzR-Gy; Fri, 03 Mar 2023 22:11:45 +0000 Date: Fri, 3 Mar 2023 14:11:45 -0800 From: Luis Chamberlain To: ye.xingchen@zte.com.cn Cc: keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, linmiaohe@huawei.com, chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: =?iso-8859-1?Q?compaction?= =?iso-8859-1?Q?=3A_limit_illegal_input_parameters_of=A0compact=5Fmemor?= =?iso-8859-1?Q?y?= interface Message-ID: References: <202303030844412743985@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202303030844412743985@zte.com.cn> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8992C1C0007 X-Rspam-User: X-Stat-Signature: fqzxugutohbdx6tk7kgdyrmqr4en4a54 X-HE-Tag: 1677881514-856083 X-HE-Meta: U2FsdGVkX18qaFAiSQESjr6j/RwmdeVBlJJlkCe/OH5Qye/EkEChWFE0v0WSPszV6+aApdHrw3oTg995Za85Hs4uJEBAcstjUxp9BVveIbtLZ5e04RMuwdpR7/KJZgT7DNNvQNUsLQbZBO/bLqXc1CytwwSKlZSpschQLCx2Yz27/6KhlNK0mxdM4nzo3gJr2hoa7t8Qbwa9IU5yBDB8b5nRpUux8+wi58Yn9jMLYcGUrrDTUQN0C6O35w2o07FXv9AiMJbAjWZfiWGaAEKhv7ZQggqJumhxXrJY5ufB8aZF2g2tLD8AoROjN7pI9DHtVQcRXHJC4vdHdiW8+tKLIgk+Z1yNlIbUrumux4zqiEUhj49gfa8T8R7Q3eSHDIVcX5SLqbpOyXhkRXbBrkIqRRIgPLlGwPasL9cOHJ46b3A1TAcXhyaoWnjIpX3xOPqR9jNqba3Ao3pmfVPIwVNPHbG6xT/3VpDqYbQSOdJTpDykABQkPbqP2AUy/bnI5WKt7qPzEsaCxdXg2OjLeS7X/QfBzI5yOnIB2suGEuaAX9z65Nhk9jWyxTZQLRt20YwXdkZjzIyxOzqOZ+vzErZ4c7VIH0weIUr+E0GFF3R6PEaMn13Vu3KAFettFAzQ4KeQxJsjsT8C+XSOd47Y2EZxFm501ZXaTKWLNhMuJ2N2zCrYbRiMn/uOx0quB8W0iyYRDFODzmfeBfIwqM85RUxXmPFxyR/KV+NlE+B5Kas9BkDSDm4esR3loxO8K55DYdJf5D8LpMGQV9viGbDtauQZH8ida6zonNFUUWc098putDVK7VB5lr+kym0PlDU0EcWy+8htsV25t80oxkCeYhM+ETRwkl2EZyRnTDfRFqvbrI4sbOsYTpcq4Ukxwr4xDHjj1zqAn0W8Fv0N+aK91jC3Aa7AlBuiNxzxw6AB6NeMUmgNVZ/5A2mA4Tc+4luWchK0Y3Dx1umzDOC8e7gjbi6 0ohdYRFQ QcnLrh8etxziAsvAYfBCV0NgtjYSsUGkXMZ3AgkjiHu3cq8TOVfmnw5pk9+Y+w3sAJTFz1awQnNpmumjW6Cl6a3xat8lwFk/I8FYnnKWKDKkYFoF+CYy/R0Ol00p3ECAkVskA/dkR9DzLKzx1awvEdjRwRHFfUAY+MJfKsQQmoomIRvucxh1G3gyXuoS2pKZidkU43tLHe1e8N56abUfINjKqDAy2fnSGuqQCXK4jRxuxCsKQPO9dcUKobRsz058t5mkPdQIyZNWr4G+uEDD5nw986hs4qNYjIrF5l8263WlJfMns8ovvQ5qwR14OkhvzneuzRDq9vwY3QGiiMf3dJZ3EuWHjKBqoKUl3tHC/7lehY/2M1TuOODQNNBCIbNxcM+VWL4Jh02xbRcV8nAxY+0B0zGBOZjheBVCoFWtU8JNEp/M4UAvAZ1obFh236q5syo5RQgDKKcAYICwsVOn2+0ZiOEUP1lAyLSNzfGN2zWbY99PEDOqfQ2Ow6HWFK9u3SJs3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 03, 2023 at 08:44:41AM +0800, ye.xingchen@zte.com.cn wrote: > From: Minghao Chi > > Available only when CONFIG_COMPACTION is set. When 1 is written to > the file, all zones are compacted such that free memory is available > in contiguous blocks where possible. > But echo others-parameter > compact_memory, this function will be > triggered by writing parameters to the interface. > > Applied this patch, > sh/$ echo 1.1 > /proc/sys/vm/compact_memory > sh/$ sh: write error: Invalid argument > The start and end time of printing triggering compact_memory. > > Signed-off-by: Minghao Chi > Signed-off-by: Ye Xingchen Do a huge favor and while you're at it split this into two patches, one which takes this out of kernel/sysctl.c and move it to mm/compaction.c and a second one that does your change here. Since kernel/sysctl.c is being trimmed you can base your changes on sysctl-next [0] and I'm happy to take in there if Andrew agrees to it. [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next Luis